mbox series

[0/3] V3 /proc/pressure buildstats

Message ID 20220622192105.2177756-1-aryaman.gupta@windriver.com
Headers show
Series V3 /proc/pressure buildstats | expand

Message

Aryaman Gupta June 22, 2022, 7:21 p.m. UTC 
Changes in V3:
- In V2, it was assumed that heartbeat events arrived once per second
  but on the Autobuilder, the BB_HEARTBEAT_EVENT is set to 60 seconds.
  Hence, revert the requirement to restrict sampling only to heartbeat
  events. 

- Make sample return a bool indicating that a new sample was collected,
  and that the datastore should be updated.

- Expand and explain why min_seconds has a tolerance of 0.01 seconds.

While any testing is useful, it would be better if this change was
tested along with a patch that caused rebuilds to occur. 

Regards,
Aryaman Gupta (3):
  buildstats.py: enable collection of /proc/pressure data
  pybootchartgui: render cpu and io pressure
  buildstats.bbclass: correct sampling of system stats

 meta/classes/buildstats.bbclass               |  3 +-
 meta/lib/buildstats.py                        | 80 ++++++++++++++----
 scripts/pybootchartgui/pybootchartgui/draw.py | 77 ++++++++++++++++++
 .../pybootchartgui/pybootchartgui/parsing.py  | 28 +++++++
 .../pybootchartgui/pybootchartgui/samples.py  | 17 ++++
 5 files changed, 190 insertions(+), 15 deletions(-)

Comments

Richard Purdie June 30, 2022, 10:52 a.m. UTC | #1 
On Wed, 2022-06-22 at 15:21 -0400, Aryaman Gupta wrote:
> Changes in V3:
> - In V2, it was assumed that heartbeat events arrived once per second
>   but on the Autobuilder, the BB_HEARTBEAT_EVENT is set to 60 seconds.
>   Hence, revert the requirement to restrict sampling only to heartbeat
>   events. 
> 
> - Make sample return a bool indicating that a new sample was collected,
>   and that the datastore should be updated.
> 
> - Expand and explain why min_seconds has a tolerance of 0.01 seconds.
> 
> While any testing is useful, it would be better if this change was
> tested along with a patch that caused rebuilds to occur. 

Unfortunately I suspect this has broken the performance worker testing:

https://autobuilder.yoctoproject.org/typhoon/#/builders/132/builds/427/steps/11/logs/stdio

Cheers,

Richard