diff mbox series

Simple cleanup of explanation of minimum version requirements

Message ID 727b1435-c923-6c06-c2df-e1ff35c8968c@crashcourse.ca
State New
Headers show
Series Simple cleanup of explanation of minimum version requirements | expand

Commit Message

Robert P. J. Day May 26, 2025, 9:23 a.m. UTC
Trivial list rendering and grammar fixes.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

Comments

Quentin Schulz May 26, 2025, 9:29 a.m. UTC | #1
Hi Robert,

On 5/26/25 11:23 AM, Robert P. J. Day via lists.yoctoproject.org wrote:
> 
> Trivial list rendering and grammar fixes.
> 
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> 
> ---
> 
> diff --git a/documentation/brief-yoctoprojectqs/index.rst b/documentation/brief-yoctoprojectqs/index.rst
> index 2f6e4cf02..a8d877a54 100644
> --- a/documentation/brief-yoctoprojectqs/index.rst
> +++ b/documentation/brief-yoctoprojectqs/index.rst
> @@ -57,7 +57,7 @@ following requirements:
>      :ref:`dev-manual/start:preparing the build host`
>      section in the Yocto Project Development Tasks Manual.
> 
> --
> +-  Ensure that the following utilities have these minimum version numbers:
> 
>      -  Git &MIN_GIT_VERSION; or greater
>      -  tar &MIN_TAR_VERSION; or greater
> @@ -65,7 +65,7 @@ following requirements:
>      -  gcc &MIN_GCC_VERSION; or greater.
>      -  GNU make &MIN_MAKE_VERSION; or greater
> 
> -If your build host does not meet any of these three listed version
> +If your build host does not meet any of the above version

Not a native speaker here, but should we rather say "does not meet all 
the above version requirements"?

In any case:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin
Robert P. J. Day May 26, 2025, 9:33 a.m. UTC | #2
On Mon, 26 May 2025, Quentin Schulz wrote:

> Hi Robert,
>
> On 5/26/25 11:23 AM, Robert P. J. Day via lists.yoctoproject.org wrote:
> >
> > Trivial list rendering and grammar fixes.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > ---
> >
> > diff --git a/documentation/brief-yoctoprojectqs/index.rst
> > b/documentation/brief-yoctoprojectqs/index.rst
> > index 2f6e4cf02..a8d877a54 100644
> > --- a/documentation/brief-yoctoprojectqs/index.rst
> > +++ b/documentation/brief-yoctoprojectqs/index.rst
> > @@ -57,7 +57,7 @@ following requirements:
> >      :ref:`dev-manual/start:preparing the build host`
> >      section in the Yocto Project Development Tasks Manual.
> >
> > --
> > +-  Ensure that the following utilities have these minimum version numbers:
> >
> >      -  Git &MIN_GIT_VERSION; or greater
> >      -  tar &MIN_TAR_VERSION; or greater
> > @@ -65,7 +65,7 @@ following requirements:
> >      -  gcc &MIN_GCC_VERSION; or greater.
> >      -  GNU make &MIN_MAKE_VERSION; or greater
> >
> > -If your build host does not meet any of these three listed version
> > +If your build host does not meet any of the above version
>
> Not a native speaker here, but should we rather say "does not meet all the
> above version requirements"?
>
> In any case:
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

  ah, exactly so, will resubmit v2.

rday
diff mbox series

Patch

diff --git a/documentation/brief-yoctoprojectqs/index.rst b/documentation/brief-yoctoprojectqs/index.rst
index 2f6e4cf02..a8d877a54 100644
--- a/documentation/brief-yoctoprojectqs/index.rst
+++ b/documentation/brief-yoctoprojectqs/index.rst
@@ -57,7 +57,7 @@  following requirements:
    :ref:`dev-manual/start:preparing the build host`
    section in the Yocto Project Development Tasks Manual.

--
+-  Ensure that the following utilities have these minimum version numbers:

    -  Git &MIN_GIT_VERSION; or greater
    -  tar &MIN_TAR_VERSION; or greater
@@ -65,7 +65,7 @@  following requirements:
    -  gcc &MIN_GCC_VERSION; or greater.
    -  GNU make &MIN_MAKE_VERSION; or greater

-If your build host does not meet any of these three listed version
+If your build host does not meet any of the above version
 requirements, you can take steps to prepare the system so that you
 can still use the Yocto Project. See the
 :ref:`ref-manual/system-requirements:required git, tar, python, make and gcc versions`