diff mbox series

[1/3] set_versions.py: remove duplicate and unneeded logic

Message ID 20260212-fix-switchers-js-v1-1-16d95c74c328@bootlin.com
State New
Headers show
Series Rework the logic of the switcher menu and improve it | expand

Commit Message

Antonin Godard Feb. 12, 2026, 8:37 a.m. UTC 
The following commit will make it unneeded to pass the version to the
script directly, as it will be automatically deduced no matter which
branch we're on. We can therefore the ourversion assignment. We still
want the "getlatest" special argument, so read it from sys.argv
directly.

Add a comment mentioning that the order here is important for getlatest
to work.

Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
---
 documentation/set_versions.py | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
diff mbox series

Patch

diff --git a/documentation/set_versions.py b/documentation/set_versions.py
index 78d0518c1..64b58f103 100755
--- a/documentation/set_versions.py
+++ b/documentation/set_versions.py
@@ -18,20 +18,13 @@  import os
 import itertools
 import re
 
-ourversion = None
-if len(sys.argv) == 2:
-    ourversion = sys.argv[1]
-
-ourversion = None
-if len(sys.argv) == 2:
-    ourversion = sys.argv[1]
-
+# Order matters: most recent to least recent
 activereleases = ["whinlatter", "scarthgap", "kirkstone"]
 devbranch = "wrynose"
 ltsseries = ["wrynose", "scarthgap", "kirkstone"]
 
 # used by run-docs-builds to get the default page
-if ourversion == "getlatest":
+if len(sys.argv) > 1 and sys.argv[1] == "getlatest":
     print(activereleases[0])
     sys.exit(0)
 
@@ -96,6 +89,7 @@  poky_mapping = {
     "3.1" : "23.0",
 }
 
+ourversion = None
 ourseries = None
 ourbranch = None
 bitbakeversion = None