diff mbox series

[2/5] Makefile: fix rsvg-convert --format capitalization

Message ID 20251205-build-docs-container-tlmgr-v1-2-de30623e664d@bootlin.com
State New
Headers show
Series Add missing CentOS Stream / RockyLinux distros to the system-requirements.rst doc | expand

Commit Message

Antonin Godard Dec. 5, 2025, 2:51 p.m. UTC
On some versions of rsvg-convert, capitalized formats are unknown.

For example on CentOS Stream 9:

  $ rsvg-convert --format=Png --output=ref-manual/svg/releases.png ref-manual/svg/releases.svg
  Unknown output format.

While the same command with "png" runs fine.

On Ubuntu 22.04, both are accepted.

Switch to the un-capitalized options, compatible with all versions.

Signed-off-by: Antonin Godard <antonin.godard@bootlin.com>
---
 documentation/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz Dec. 5, 2025, 3:03 p.m. UTC | #1
Hi Antonin,

On 12/5/25 3:51 PM, Antonin Godard via lists.yoctoproject.org wrote:
> On some versions of rsvg-convert, capitalized formats are unknown.
> 
> For example on CentOS Stream 9:
> 
>    $ rsvg-convert --format=Png --output=ref-manual/svg/releases.png ref-manual/svg/releases.svg
>    Unknown output format.
> 
> While the same command with "png" runs fine.
> 
> On Ubuntu 22.04, both are accepted.
> 
> Switch to the un-capitalized options, compatible with all versions.
> 

rsvg-convert doc only mentions all lowercase format options, so looks 
fine to me

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

FYI, --format=pdf is a "moving" target, that is it isn't always the same 
PDF version depending on rsvg-convert's own version. They mention it can 
be an issue with some latexpdf versions only supporting older PDF 
versions. See 
https://github.com/GNOME/librsvg/blob/main/rsvg-convert.rst#pdf-versions

At least you're aware of it now, no idea if we should be doing something 
about it. I guess we could try to be smart and detect the max PDF 
version supported by latexmk at runtime and select the pdf version for 
rsvg-convert based on that.

Thanks!
Quentin
diff mbox series

Patch

diff --git a/documentation/Makefile b/documentation/Makefile
index bade78fe8..e144a50b4 100644
--- a/documentation/Makefile
+++ b/documentation/Makefile
@@ -43,11 +43,11 @@  PNGs := $(foreach dir, $(IMAGEDIRS), $(patsubst %.svg,%.png,$(wildcard $(SOURCED
 
 # Pattern rule for converting SVG to PDF
 %.pdf : %.svg
-	$(SVG2PDF) --format=Pdf --output=$@ $<
+	$(SVG2PDF) --format=pdf --output=$@ $<
 
 # Pattern rule for converting SVG to PNG
 %.png : %.svg
-	$(SVG2PNG) --format=Png --output=$@ $<
+	$(SVG2PNG) --format=png --output=$@ $<
 
 clean:
 	@rm -rf $(BUILDDIR) $(PNGs) $(PDFs) poky.yaml sphinx-static/switchers.js releases.rst