diff mbox series

start.rst: added missing command in Optimize your VHDX file using DiskPart

Message ID 20250719160642.15601-1-m.cavallini@koansoftware.com
State New
Headers show
Series start.rst: added missing command in Optimize your VHDX file using DiskPart | expand

Commit Message

Marco Cavallini July 19, 2025, 4:06 p.m. UTC
Signed-off-by: Marco Cavallini <m.cavallini@koansoftware.com>
---
 documentation/dev-manual/start.rst | 1 +
 1 file changed, 1 insertion(+)

Comments

Antonin Godard July 21, 2025, 7 a.m. UTC | #1
Hi Marco,

Thanks for the patch. Could you describe the issue you had in the commit
message? It's hard for anyone to understand the context here, and having a
commit message would help understand why this change is required.

Antonin
Marco Cavallini July 22, 2025, 5:33 p.m. UTC | #2
On 21/07/25 09:00, Antonin Godard via lists.yoctoproject.org wrote:
> Hi Marco,
> 
> Thanks for the patch. Could you describe the issue you had in the commit
> message? It's hard for anyone to understand the context here, and having a
> commit message would help understand why this change is required.
> 
> Antonin


Hi Antonin,
any news about my Patch v2 ?
--
Marco
Antonin Godard July 23, 2025, 6:49 a.m. UTC | #3
On Tue Jul 22, 2025 at 7:33 PM CEST, Marco Cavallini wrote:
> On 21/07/25 09:00, Antonin Godard via lists.yoctoproject.org wrote:
>> Hi Marco,
>> 
>> Thanks for the patch. Could you describe the issue you had in the commit
>> message? It's hard for anyone to understand the context here, and having a
>> commit message would help understand why this change is required.
>> 
>> Antonin
>
>
> Hi Antonin,
> any news about my Patch v2 ?

I merged your patch on master-next, it will be merged to master on the next pull
request. You will receive an email from me when that happens.

Thanks for reworking the commit message!

Antonin
diff mbox series

Patch

diff --git a/documentation/dev-manual/start.rst b/documentation/dev-manual/start.rst
index e10367752..803ea2601 100644
--- a/documentation/dev-manual/start.rst
+++ b/documentation/dev-manual/start.rst
@@ -554,6 +554,7 @@  your Yocto Project build host:
          DISKPART> select vdisk file="<path_to_VHDX_file>"
          DISKPART> attach vdisk readonly
          DISKPART> compact vdisk
+         DISKPART> detach
          DISKPART> exit
 
 .. note::