diff mbox series

[v1,6/6] migration: replace dashes by colons

Message ID 20240405143453.2281900-7-joaomarcos.costa@bootlin.com
State New
Headers show
Series Add Miscellaneous changes and QEMU changes | expand

Commit Message

Joao Marcos Costa April 5, 2024, 2:34 p.m. UTC
From: Joao Marcos Costa <joaomarcos.costa@bootlin.com>

Signed-off-by: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
---
 documentation/migration-guides/migration-5.0.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Opdenacker April 5, 2024, 3:04 p.m. UTC | #1
Hi João,

On 4/5/24 at 16:34, joaomarcos.costa@bootlin.com wrote:
> From: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
>
> Signed-off-by: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
> ---
>   documentation/migration-guides/migration-5.0.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/documentation/migration-guides/migration-5.0.rst b/documentation/migration-guides/migration-5.0.rst
> index 301b7a3d2..888a1c60d 100644
> --- a/documentation/migration-guides/migration-5.0.rst
> +++ b/documentation/migration-guides/migration-5.0.rst
> @@ -90,11 +90,11 @@ Removed variables
>   The following variables have been removed:
>   
>   -  ``DEPLOY_DIR_TAR``.
> --  ``PYTHON_PN`` - Python 2 has been removed, leaving Python 3 as the sole
> +-  ``PYTHON_PN``: Python 2 has been removed, leaving Python 3 as the sole
>      major version. Therefore, an abstraction to differentiate both versions is
>      no longer needed.
>   -  ``oldincludedir``.
> --  ``USE_L10N`` - previously deprecated, and now removed.
> +-  ``USE_L10N``: previously deprecated, and now removed.
>   -  ``CVE_SOCKET_TIMEOUT``.
>   
>   .. _migration-5.0-removed-recipes:

Thanks, but don't show us your fixes to your own code. In the git 
history, we want only "clean" commits whenever possible.

You should squash 4/6 and 6/6 into 1/6.

Actually, your commits could all be grouped into a single one, as they 
touch the same file. It's better not to have too many commits.

Except for 5/6, I'll take care of squashing it into the commit it fixes.
So, rebase your changes against master-next in a few minutes.

Thanks
Michael.
diff mbox series

Patch

diff --git a/documentation/migration-guides/migration-5.0.rst b/documentation/migration-guides/migration-5.0.rst
index 301b7a3d2..888a1c60d 100644
--- a/documentation/migration-guides/migration-5.0.rst
+++ b/documentation/migration-guides/migration-5.0.rst
@@ -90,11 +90,11 @@  Removed variables
 The following variables have been removed:
 
 -  ``DEPLOY_DIR_TAR``.
--  ``PYTHON_PN`` - Python 2 has been removed, leaving Python 3 as the sole
+-  ``PYTHON_PN``: Python 2 has been removed, leaving Python 3 as the sole
    major version. Therefore, an abstraction to differentiate both versions is
    no longer needed.
 -  ``oldincludedir``.
--  ``USE_L10N`` - previously deprecated, and now removed.
+-  ``USE_L10N``: previously deprecated, and now removed.
 -  ``CVE_SOCKET_TIMEOUT``.
 
 .. _migration-5.0-removed-recipes: