diff mbox series

dev-manual: packages: clarify shared PR service constraint

Message ID 20240221211648.104003-1-michael.opdenacker@bootlin.com
State New
Headers show
Series dev-manual: packages: clarify shared PR service constraint | expand

Commit Message

Michael Opdenacker Feb. 21, 2024, 9:16 p.m. UTC
From: Michael Opdenacker <michael.opdenacker@bootlin.com>

Explicit the problems previous described as "obvious".

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
---
 documentation/dev-manual/packages.rst | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

Comments

Quentin Schulz March 4, 2024, 11:19 a.m. UTC | #1
Hi Michael,

On 2/21/24 22:16, Michael Opdenacker via lists.yoctoproject.org wrote:
> From: Michael Opdenacker <michael.opdenacker@bootlin.com>
> 
> Explicit the problems previous described as "obvious".
> 
> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> ---
>   documentation/dev-manual/packages.rst | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/documentation/dev-manual/packages.rst b/documentation/dev-manual/packages.rst
> index 0e991e409a..d90ff7110e 100644
> --- a/documentation/dev-manual/packages.rst
> +++ b/documentation/dev-manual/packages.rst
> @@ -205,9 +205,14 @@ history, see the
>      The OpenEmbedded build system does not maintain :term:`PR` information as
>      part of the shared state (sstate) packages. If you maintain an sstate
>      feed, it's expected that either all your building systems that
> -   contribute to the sstate feed use a shared PR Service, or you do not
> -   run a PR Service on any of your building systems. Having some systems
> -   use a PR Service while others do not leads to obvious problems.
> +   contribute to the sstate feed use a shared PR service, or you do not
> +   run a PR Service on any of your building systems.
> +

The first line makes service lowercase, while the second line is 
capitalized.

> +   That's because if you had multiple machines sharing a PR service but > +   not their sstate feed, you could end up with "diverging" hashes for
> +   the same output artefacts. When presented to the share PR service,

Here lowercase as well, so I guess we wanted lowercase in the second (+) 
line above?

Cheers,
Quentin
diff mbox series

Patch

diff --git a/documentation/dev-manual/packages.rst b/documentation/dev-manual/packages.rst
index 0e991e409a..d90ff7110e 100644
--- a/documentation/dev-manual/packages.rst
+++ b/documentation/dev-manual/packages.rst
@@ -205,9 +205,14 @@  history, see the
    The OpenEmbedded build system does not maintain :term:`PR` information as
    part of the shared state (sstate) packages. If you maintain an sstate
    feed, it's expected that either all your building systems that
-   contribute to the sstate feed use a shared PR Service, or you do not
-   run a PR Service on any of your building systems. Having some systems
-   use a PR Service while others do not leads to obvious problems.
+   contribute to the sstate feed use a shared PR service, or you do not
+   run a PR Service on any of your building systems.
+
+   That's because if you had multiple machines sharing a PR service but
+   not their sstate feed, you could end up with "diverging" hashes for
+   the same output artefacts. When presented to the share PR service,
+   each would be considered as new and would increase the revision
+   number, causing many unnecessary package upgrades.
 
    For more information on shared state, see the
    ":ref:`overview-manual/concepts:shared state cache`"