| Message ID | 20240201165046.28589-1-simone.p.weiss@posteo.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | dev-manual: gen-tapdevs need iptables installed | expand |
Hi Simone On 2/1/24 at 17:50, Simone Weiß wrote: > From: Simone Weiß <simone.p.weiss@posteo.com> > > Add the hint to the test setup that runqemu-gen-tapdevs will need the > iptables package installed. > > Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com> > --- > documentation/dev-manual/runtime-testing.rst | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/documentation/dev-manual/runtime-testing.rst b/documentation/dev-manual/runtime-testing.rst > index be1e8c02e..1a2e9ec4f 100644 > --- a/documentation/dev-manual/runtime-testing.rst > +++ b/documentation/dev-manual/runtime-testing.rst > @@ -52,6 +52,8 @@ In order to run tests, you need to do the following: > - Be sure to use an absolute path when calling this script > with sudo. > > + - Ensure that your host has the package ``iptables`` installed. > + > - The package recipe ``qemu-helper-native`` is required to run > this script. Build the package using the following command:: > Thanks for the patch, but it doesn't apply with "git am" on "master-next". Did you send it with "git send-email", or was the patch messed-up by your mail server? Applying: dev-manual: gen-tapdevs need iptables installed error: patch failed: documentation/dev-manual/runtime-testing.rst:52 error: documentation/dev-manual/runtime-testing.rst: patch does not apply Patch failed at 0001 dev-manual: gen-tapdevs need iptables installed hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Of course, I could re-create the patch, but that's interesting to solve this issue for next time. Cheers Michael
Hi Simone On 2/2/24 at 15:38, Michael Opdenacker via lists.yoctoproject.org wrote: > Hi Simone > > On 2/1/24 at 17:50, Simone Weiß wrote: >> From: Simone Weiß <simone.p.weiss@posteo.com> >> >> Add the hint to the test setup that runqemu-gen-tapdevs will need the >> iptables package installed. >> >> Signed-off-by: Simone Weiß <simone.p.weiss@posteo.com> >> --- >> documentation/dev-manual/runtime-testing.rst | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/documentation/dev-manual/runtime-testing.rst >> b/documentation/dev-manual/runtime-testing.rst >> index be1e8c02e..1a2e9ec4f 100644 >> --- a/documentation/dev-manual/runtime-testing.rst >> +++ b/documentation/dev-manual/runtime-testing.rst >> @@ -52,6 +52,8 @@ In order to run tests, you need to do the following: >> - Be sure to use an absolute path when calling this script >> with sudo. >> + - Ensure that your host has the package ``iptables`` >> installed. >> + >> - The package recipe ``qemu-helper-native`` is required >> to run >> this script. Build the package using the following >> command:: > > > Thanks for the patch, but it doesn't apply with "git am" on > "master-next". Did you send it with "git send-email", or was the patch > messed-up by your mail server? > > Applying: dev-manual: gen-tapdevs need iptables installed > > error: patch failed: documentation/dev-manual/runtime-testing.rst:52 > > error: documentation/dev-manual/runtime-testing.rst: patch does not apply > > Patch failed at 0001 dev-manual: gen-tapdevs need iptables installed > > hint: Use 'git am --show-current-patch=diff' to see the failed patch > > When you have resolved this problem, run "git am --continue". > > If you prefer to skip this patch, run "git am --skip" instead. > > To restore the original branch and stop patching, run "git am --abort". > > Of course, I could re-create the patch, but that's interesting to > solve this issue for next time. Never mind, the problem is probably on my side. It seems I tried to apply it twice, so everything's OK now and the patch is in "master-next". Thanks again Michael.
diff --git a/documentation/dev-manual/runtime-testing.rst b/documentation/dev-manual/runtime-testing.rst index be1e8c02e..1a2e9ec4f 100644 --- a/documentation/dev-manual/runtime-testing.rst +++ b/documentation/dev-manual/runtime-testing.rst @@ -52,6 +52,8 @@ In order to run tests, you need to do the following: - Be sure to use an absolute path when calling this script with sudo. + - Ensure that your host has the package ``iptables`` installed. + - The package recipe ``qemu-helper-native`` is required to run this script. Build the package using the following command::