diff mbox series

dev-manual: fix testimage usage instructions

Message ID 20231003151741.1255292-1-tgamblin@baylibre.com
State New
Headers show
Series dev-manual: fix testimage usage instructions | expand

Commit Message

Trevor Gamblin Oct. 3, 2023, 3:17 p.m. UTC
The proper way to inherit the testimage class is now

IMAGE_CLASSES += "testimage"

so change lines with 'INHERIT += "testimage"' to match. This makes the
dev-manual consistent with the migration guide, which already specifies
that the old way causes an error.

Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
---
 documentation/dev-manual/runtime-testing.rst   | 4 ++--
 documentation/dev-manual/upgrading-recipes.rst | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Opdenacker Oct. 5, 2023, 8:30 a.m. UTC | #1
Hi Trevor

On 03.10.23 at 17:17, Trevor Gamblin wrote:
> The proper way to inherit the testimage class is now
>
> IMAGE_CLASSES += "testimage"
>
> so change lines with 'INHERIT += "testimage"' to match. This makes the
> dev-manual consistent with the migration guide, which already specifies
> that the old way causes an error.
>
> Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
> ---
>   documentation/dev-manual/runtime-testing.rst   | 4 ++--
>   documentation/dev-manual/upgrading-recipes.rst | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/documentation/dev-manual/runtime-testing.rst b/documentation/dev-manual/runtime-testing.rst
> index c5c5653be..af3fe2c1d 100644
> --- a/documentation/dev-manual/runtime-testing.rst
> +++ b/documentation/dev-manual/runtime-testing.rst
> @@ -229,7 +229,7 @@ The final thing you need to do when setting :term:`TEST_TARGET` to
>      statements in your ``local.conf`` file::
>   
>         IMAGE_FSTYPES += "tar.gz"
> -      INHERIT += "testimage"
> +      IMAGE_CLASSES += "testimage"
>         TEST_TARGET = "SystemdbootTarget"
>         TEST_TARGET_IP = "192.168.2.3"
>   
> @@ -335,7 +335,7 @@ You can start the tests automatically or manually:
>      inherit the :ref:`ref-classes-testimage` class by editing your
>      ``local.conf`` file::
>   
> -      INHERIT += "testimage"
> +      IMAGE_CLASSES += "testimage"
>   
>      Next, use BitBake to run the tests::
>   
> diff --git a/documentation/dev-manual/upgrading-recipes.rst b/documentation/dev-manual/upgrading-recipes.rst
> index 947ef138a..4fac78bdf 100644
> --- a/documentation/dev-manual/upgrading-recipes.rst
> +++ b/documentation/dev-manual/upgrading-recipes.rst
> @@ -117,7 +117,7 @@ The following steps describe how to set up the AUH utility:
>         class, which is optional, you need to have the following set in
>         your ``conf/local.conf`` file::
>   
> -         INHERIT += "testimage"
> +         IMAGE_CLASSES += "testimage"
>   
>         .. note::


Many thanks for the update!
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
and merged into "master-next".

Cheers
Michael.
diff mbox series

Patch

diff --git a/documentation/dev-manual/runtime-testing.rst b/documentation/dev-manual/runtime-testing.rst
index c5c5653be..af3fe2c1d 100644
--- a/documentation/dev-manual/runtime-testing.rst
+++ b/documentation/dev-manual/runtime-testing.rst
@@ -229,7 +229,7 @@  The final thing you need to do when setting :term:`TEST_TARGET` to
    statements in your ``local.conf`` file::
 
       IMAGE_FSTYPES += "tar.gz"
-      INHERIT += "testimage"
+      IMAGE_CLASSES += "testimage"
       TEST_TARGET = "SystemdbootTarget"
       TEST_TARGET_IP = "192.168.2.3"
 
@@ -335,7 +335,7 @@  You can start the tests automatically or manually:
    inherit the :ref:`ref-classes-testimage` class by editing your
    ``local.conf`` file::
 
-      INHERIT += "testimage"
+      IMAGE_CLASSES += "testimage"
 
    Next, use BitBake to run the tests::
 
diff --git a/documentation/dev-manual/upgrading-recipes.rst b/documentation/dev-manual/upgrading-recipes.rst
index 947ef138a..4fac78bdf 100644
--- a/documentation/dev-manual/upgrading-recipes.rst
+++ b/documentation/dev-manual/upgrading-recipes.rst
@@ -117,7 +117,7 @@  The following steps describe how to set up the AUH utility:
       class, which is optional, you need to have the following set in
       your ``conf/local.conf`` file::
 
-         INHERIT += "testimage"
+         IMAGE_CLASSES += "testimage"
 
       .. note::