diff mbox series

[v2,5/5] contributor-guide: style-guide: discourage using Pending patch status

Message ID 20230922100006.756477-5-rhi@pengutronix.de
State New
Headers show
Series [v2,1/5] contributor-guide: recipe-style-guide: add more patch tagging examples | expand

Commit Message

Roland Hieber Sept. 22, 2023, 10 a.m. UTC
Suggested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Suggested-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
PATCH v2:
 * new patch in v2, based on feedback by Michael Opdenacker in v1
   https://lore.kernel.org/yocto-docs/12ef125b-5466-408c-ec8c-c5bef1510bc7@bootlin.com/
   and Alexander Kanavin in
   https://lore.kernel.org/yocto-docs/CANNYZj-7C_DeNgVCyRuHRCXZNX-2JPcnysKLn7gQq8w-4aAkNA@mail.gmail.com/
---
 documentation/contributor-guide/recipe-style-guide.rst | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Michael Opdenacker Sept. 22, 2023, 1:14 p.m. UTC | #1
Hi Roland

On 22.09.23 at 12:00, Roland Hieber wrote:
> Suggested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> Suggested-by: Alexander Kanavin <alex.kanavin@gmail.com>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> PATCH v2:
>   * new patch in v2, based on feedback by Michael Opdenacker in v1
>     https://lore.kernel.org/yocto-docs/12ef125b-5466-408c-ec8c-c5bef1510bc7@bootlin.com/
>     and Alexander Kanavin in
>     https://lore.kernel.org/yocto-docs/CANNYZj-7C_DeNgVCyRuHRCXZNX-2JPcnysKLn7gQq8w-4aAkNA@mail.gmail.com/
> ---
>   documentation/contributor-guide/recipe-style-guide.rst | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)


Many thanks for these updates!
For all of them: Reviewed-by: Michael Opdenacker 
<michael.opdenacker@bootlin.com>
Merged into "master-next".

Thanks to you, the Contributor Guide has made nice progress this week, 
and we now have a better and up to date reference for people adding 
patches to recipes.

Come back anytime :)

Cheers
Michael.
Roland Hieber Sept. 25, 2023, 10:48 a.m. UTC | #2
On Fri, Sep 22, 2023 at 03:14:25PM +0200, Michael Opdenacker via lists.yoctoproject.org wrote:
> Hi Roland
> 
> On 22.09.23 at 12:00, Roland Hieber wrote:
> > Suggested-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
> > Suggested-by: Alexander Kanavin <alex.kanavin@gmail.com>
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > ---
> > PATCH v2:
> >   * new patch in v2, based on feedback by Michael Opdenacker in v1
> >     https://lore.kernel.org/yocto-docs/12ef125b-5466-408c-ec8c-c5bef1510bc7@bootlin.com/
> >     and Alexander Kanavin in
> >     https://lore.kernel.org/yocto-docs/CANNYZj-7C_DeNgVCyRuHRCXZNX-2JPcnysKLn7gQq8w-4aAkNA@mail.gmail.com/
> > ---
> >   documentation/contributor-guide/recipe-style-guide.rst | 8 +++++++-
> >   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> 
> Many thanks for these updates!
> For all of them: Reviewed-by: Michael Opdenacker
> <michael.opdenacker@bootlin.com>
> Merged into "master-next".
> 
> Thanks to you, the Contributor Guide has made nice progress this week, and
> we now have a better and up to date reference for people adding patches to
> recipes.

Whee \o/ And thanks for your fixups too!

 - Roland

> Come back anytime :)
> 
> Cheers
> Michael.
> 
> -- 
> 
> Michael Opdenacker, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#4296): https://lists.yoctoproject.org/g/docs/message/4296
> Mute This Topic: https://lists.yoctoproject.org/mt/101518215/5053951
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/docs/unsub [rhi@pengutronix.de]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/documentation/contributor-guide/recipe-style-guide.rst b/documentation/contributor-guide/recipe-style-guide.rst
index c69e4a92c992..c24ec267d394 100644
--- a/documentation/contributor-guide/recipe-style-guide.rst
+++ b/documentation/contributor-guide/recipe-style-guide.rst
@@ -271,7 +271,13 @@  Then, you should also add an ``Upstream-Status:`` tag containing one of the
 following status strings:
 
 ``Pending``
-   No determination has been made yet or not yet submitted to upstream.
+   No determination has been made yet, or patch has not yet been submitted to
+   upstream.
+
+   Keep in mind that every patch submitted upstream reduces the maintainance
+   burden in Yocto in the long run, so this patch status should only be used in
+   exceptional cases if there are genuine obstacles to submitting a patch
+   upstream; the reason for that should be included in the patch.
 
 ``Submitted [where]``
    Submitted to upstream, waiting for approval. Optionally include where