diff mbox series

Increase minimum GCC version to 8.0

Message ID 20230404155620.3278946-1-ross.burton@arm.com
State New
Headers show
Series Increase minimum GCC version to 8.0 | expand

Commit Message

Ross Burton April 4, 2023, 3:56 p.m. UTC
We've increased the minimum GCC version to 8.0[1] so update the
documentation to match.

[1] sanity.bbclass: Update minimum gcc version to 8.0

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 documentation/poky.yaml.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Opdenacker April 4, 2023, 4:50 p.m. UTC | #1
Hi Ross,

On 04.04.23 at 17:56, Ross Burton wrote:
> We've increased the minimum GCC version to 8.0[1] so update the
> documentation to match.
>
> [1] sanity.bbclass: Update minimum gcc version to 8.0
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>   documentation/poky.yaml.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/documentation/poky.yaml.in b/documentation/poky.yaml.in
> index dc0c257e5..1c072c1d0 100644
> --- a/documentation/poky.yaml.in
> +++ b/documentation/poky.yaml.in
> @@ -39,7 +39,7 @@ PIP3_HOST_PACKAGES_DOC : "$ sudo pip3 install sphinx sphinx_rtd_theme pyyaml"
>   MIN_PYTHON_VERSION : "3.8.0"
>   MIN_TAR_VERSION : "1.28"
>   MIN_GIT_VERSION : "1.8.3.1"
> -MIN_GCC_VERSION : "7.5"
> +MIN_GCC_VERSION : "8.0"
>   MIN_MAKE_VERSION : "4.0"
>   # Disk space (Gbytes) needed to generate qemux86-64 core-image-sato on Ubuntu 22.04 (x86-64), rounded up from 87
>   MIN_DISK_SPACE : "90"


Thanks for the patch! I saw the change too.
However, I'll wait for the change to be applied to Poky master before 
applying it.
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

Thanks again
Michael.
Richard Purdie April 4, 2023, 9:09 p.m. UTC | #2
On Tue, 2023-04-04 at 18:50 +0200, Michael Opdenacker via
lists.yoctoproject.org wrote:
> Hi Ross,
> 
> On 04.04.23 at 17:56, Ross Burton wrote:
> > We've increased the minimum GCC version to 8.0[1] so update the
> > documentation to match.
> > 
> > [1] sanity.bbclass: Update minimum gcc version to 8.0
> > 
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> >   documentation/poky.yaml.in | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/documentation/poky.yaml.in b/documentation/poky.yaml.in
> > index dc0c257e5..1c072c1d0 100644
> > --- a/documentation/poky.yaml.in
> > +++ b/documentation/poky.yaml.in
> > @@ -39,7 +39,7 @@ PIP3_HOST_PACKAGES_DOC : "$ sudo pip3 install sphinx sphinx_rtd_theme pyyaml"
> >   MIN_PYTHON_VERSION : "3.8.0"
> >   MIN_TAR_VERSION : "1.28"
> >   MIN_GIT_VERSION : "1.8.3.1"
> > -MIN_GCC_VERSION : "7.5"
> > +MIN_GCC_VERSION : "8.0"
> >   MIN_MAKE_VERSION : "4.0"
> >   # Disk space (Gbytes) needed to generate qemux86-64 core-image-sato on Ubuntu 22.04 (x86-64), rounded up from 87
> >   MIN_DISK_SPACE : "90"
> 
> 
> Thanks for the patch! I saw the change too.
> However, I'll wait for the change to be applied to Poky master before 
> applying it.
> Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>

FWIW I've merged this with the other change.

Cheers,

Richard
diff mbox series

Patch

diff --git a/documentation/poky.yaml.in b/documentation/poky.yaml.in
index dc0c257e5..1c072c1d0 100644
--- a/documentation/poky.yaml.in
+++ b/documentation/poky.yaml.in
@@ -39,7 +39,7 @@  PIP3_HOST_PACKAGES_DOC : "$ sudo pip3 install sphinx sphinx_rtd_theme pyyaml"
 MIN_PYTHON_VERSION : "3.8.0"
 MIN_TAR_VERSION : "1.28"
 MIN_GIT_VERSION : "1.8.3.1"
-MIN_GCC_VERSION : "7.5"
+MIN_GCC_VERSION : "8.0"
 MIN_MAKE_VERSION : "4.0"
 # Disk space (Gbytes) needed to generate qemux86-64 core-image-sato on Ubuntu 22.04 (x86-64), rounded up from 87
 MIN_DISK_SPACE : "90"