[V2] Improvements for gdbserver configuration

Message ID 20220415155838.375378-1-sundeep.kokkonda@gmail.com
State New
Headers show
Series [V2] Improvements for gdbserver configuration | expand

Commit Message

Sundeep KOKKONDA April 15, 2022, 3:58 p.m. UTC
[Yocto #13722]
The Yocto bug reports a few improvements in the gdbserver configuration which improves the configuration of gdb more easier for novice users.

Signed-off-by: Sundeep KOKKONDA <sundeep.kokkonda@gmail.com>
---
 documentation/dev-manual/common-tasks.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz April 19, 2022, 8:42 a.m. UTC | #1
Hi Sundeep,

This looks like a diff applied to your previous patch (the "v1"). Since 
your previous patch is not merged yet, you need to create a new patch 
which has the old content but with the diff you are sending in this one 
applied. In short, both v1 and v2 in one single patch.

This is usually done during development by using `git commit --amend` 
instead of just `git commit`. It then "merges" the changes currently 
staged by git into the last commit.

Since you already have both commits in your git history, you have (at 
least) two ways to create the new version of the patch correctly:

git rebase -i HEAD^^

and then replace `pick` by `fixup` in the second patch and save+exit the 
text editor.

OR

git reset --soft HEAD^
git commit --amend

Please send this new version of the patch as a v3.

Thanks!
Quentin

On 4/15/22 17:58, Sundeep KOKKONDA wrote:
> [Yocto #13722]
> The Yocto bug reports a few improvements in the gdbserver configuration which improves the configuration of gdb more easier for novice users.
> 
> Signed-off-by: Sundeep KOKKONDA <sundeep.kokkonda@gmail.com>
> ---
>   documentation/dev-manual/common-tasks.rst | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
> index 0e989f78e..2301e3ba0 100644
> --- a/documentation/dev-manual/common-tasks.rst
> +++ b/documentation/dev-manual/common-tasks.rst
> @@ -10181,7 +10181,7 @@ debugger.
>      an image recipe::
>   
>         IMAGE_INSTALL:append = " gdbserver"
> -      EXTRA_IMAGE_FEATURES_append = " tools-debug"
> +      EXTRA_IMAGE_FEATURES:append = " tools-debug"
>   
>      The change makes
>      sure the ``gdbserver`` package is included.
> @@ -10235,7 +10235,7 @@ debugger.
>   
>      Install the SDK (if you built one) and then source the correct
>      environment file. Sourcing the environment file puts the SDK in your
> -   ``PATH`` environment variable and sets $GDB to the SDK's debugger.
> +   ``PATH`` environment variable and sets ``$GDB`` to the SDK's debugger.
>   
>      If you are using the build system, Gdb is located in
>      `build-dir`\ ``/tmp/sysroots/``\ `host`\ ``/usr/bin/``\ `architecture`\ ``/``\ `architecture`\ ``-gdb``
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#2778): https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.yoctoproject.org_g_docs_message_2778&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=zzre_8g6GYTVIULf1Pzmq36fFweUrcQ4b26bOTcpB6bWFpl_Lmux6y0nvo8WNuq8&s=TuY-GfBjLCHoS4eINDBYR6f0m1gvjV3_2MsPyZSOajQ&e=
> Mute This Topic: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.yoctoproject.org_mt_90489657_6293953&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=zzre_8g6GYTVIULf1Pzmq36fFweUrcQ4b26bOTcpB6bWFpl_Lmux6y0nvo8WNuq8&s=TWmwe9ePZP1QxeZXj3lKPcBF00EMppZkTBUfOpJ0sq4&e=
> Group Owner: docs+owner@lists.yoctoproject.org
> Unsubscribe: https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.yoctoproject.org_g_docs_unsub&d=DwIFaQ&c=_sEr5x9kUWhuk4_nFwjJtA&r=LYjLexDn7rXIzVmkNPvw5ymA1XTSqHGq8yBP6m6qZZ4njZguQhZhkI_-172IIy1t&m=zzre_8g6GYTVIULf1Pzmq36fFweUrcQ4b26bOTcpB6bWFpl_Lmux6y0nvo8WNuq8&s=epq9IX-B6gGwsvh80SPeBnUCX7xdknqxd7UV0BWUw5c&e=  [quentin.schulz@theobroma-systems.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Patch

diff --git a/documentation/dev-manual/common-tasks.rst b/documentation/dev-manual/common-tasks.rst
index 0e989f78e..2301e3ba0 100644
--- a/documentation/dev-manual/common-tasks.rst
+++ b/documentation/dev-manual/common-tasks.rst
@@ -10181,7 +10181,7 @@  debugger.
    an image recipe::
 
       IMAGE_INSTALL:append = " gdbserver"
-      EXTRA_IMAGE_FEATURES_append = " tools-debug"
+      EXTRA_IMAGE_FEATURES:append = " tools-debug"
 
    The change makes
    sure the ``gdbserver`` package is included.
@@ -10235,7 +10235,7 @@  debugger.
 
    Install the SDK (if you built one) and then source the correct
    environment file. Sourcing the environment file puts the SDK in your
-   ``PATH`` environment variable and sets $GDB to the SDK's debugger.
+   ``PATH`` environment variable and sets ``$GDB`` to the SDK's debugger.
 
    If you are using the build system, Gdb is located in
    `build-dir`\ ``/tmp/sysroots/``\ `host`\ ``/usr/bin/``\ `architecture`\ ``/``\ `architecture`\ ``-gdb``