| Message ID | 20260423153721.1275354-3-gyorgy.szing@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] scripts/runfvp: check available terminal types | expand |
diff --git a/scripts/runfvp b/scripts/runfvp index 8e6fe655..10a8ad1c 100755 --- a/scripts/runfvp +++ b/scripts/runfvp @@ -86,8 +86,9 @@ def start_fvp(args, fvpconf, extra_args): except FileNotFoundError as e: logger.error(f"FVP executable not found ({e})") finally: - return fvp.stop() + rv=fvp.stop() + return rv def runfvp(cli_args): args, extra_args = parse_args(cli_args)
Returning from the finally block at the end of the start_fvp() function is discarding exceptions. Since start_fvp() is near to the top off the call tree, this hides uncaught exceptions thrown by most of the code, which makes detecting and debugging issues hard. This is resolved by removing the return statement from the finally block, allowing exceptions to propagate normally. Signed-off-by: Gyorgy Szing <gyorgy.szing@arm.com> --- scripts/runfvp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)