diff mbox series

Align PSA Crypto structs with TF-Mv2.1.1

Message ID 20250506165045.509-2-ali.oezaslan@arm.com
State New
Headers show
Series corstone1000: Align PSA crypto structs with TF-M | expand

Commit Message

Ali Ozaslan May 6, 2025, 4:50 p.m. UTC
From: Ali Can Ozaslan <ali.oezaslan@arm.com>

The psa_client_key_attributes_s struct had to be aligned with the
psa_key_attributes_s struct in TF-M.

Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>
---
 components/service/crypto/include/psa/crypto_client_struct.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Ross Burton May 12, 2025, 5:23 p.m. UTC | #1
On 6 May 2025, at 17:50, ali.oezaslan via lists.yoctoproject.org <ali.oezaslan=arm.com@lists.yoctoproject.org> wrote:
> 
> From: Ali Can Ozaslan <ali.oezaslan@arm.com>
> 
> The psa_client_key_attributes_s struct had to be aligned with the
> psa_key_attributes_s struct in TF-M.
> 
> Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>
> ---
> components/service/crypto/include/psa/crypto_client_struct.h | 1 -

I’m guessing that you’re doing git-format-patch and then git-send-email manually, because the cover letter is correct but this is a patch for TF-M, not meta-arm.

Can you re-send?

Ross
Jon Mason May 13, 2025, 12:59 p.m. UTC | #2
I applied the walnascar one to master (and am currently merging both).
The Pending thing is an issue that needs to be addressed, but we can
do that after (given the proximity of the release)

On Mon, May 12, 2025 at 1:23 PM Ross Burton via lists.yoctoproject.org
<ross.burton=arm.com@lists.yoctoproject.org> wrote:
>
> On 6 May 2025, at 17:50, ali.oezaslan via lists.yoctoproject.org <ali.oezaslan=arm.com@lists.yoctoproject.org> wrote:
> >
> > From: Ali Can Ozaslan <ali.oezaslan@arm.com>
> >
> > The psa_client_key_attributes_s struct had to be aligned with the
> > psa_key_attributes_s struct in TF-M.
> >
> > Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>
> > ---
> > components/service/crypto/include/psa/crypto_client_struct.h | 1 -
>
> I’m guessing that you’re doing git-format-patch and then git-send-email manually, because the cover letter is correct but this is a patch for TF-M, not meta-arm.
>
> Can you re-send?
>
> Ross
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6497): https://lists.yoctoproject.org/g/meta-arm/message/6497
> Mute This Topic: https://lists.yoctoproject.org/mt/112652834/3616920
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [jdmason@kudzu.us]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Ali Ozaslan May 13, 2025, 2:56 p.m. UTC | #3
Thanks for the feedback and for applying the walnascar patch to master.
As for the pending issue you mentioned, it will be addressed.

You're right — I had manually prepared the patch using `git format-patch` and `git send-email`

Ali Can Ozaslan
________________________________
From: Jon Mason <jdmason@kudzu.us>
Sent: Tuesday, May 13, 2025 1:59 PM
To: Ross Burton <Ross.Burton@arm.com>
Cc: Ali Ozaslan <Ali.Oezaslan@arm.com>; meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
Subject: Re: [meta-arm] [PATCH] Align PSA Crypto structs with TF-Mv2.1.1

I applied the walnascar one to master (and am currently merging both).
The Pending thing is an issue that needs to be addressed, but we can
do that after (given the proximity of the release)

On Mon, May 12, 2025 at 1:23 PM Ross Burton via lists.yoctoproject.org
<ross.burton=arm.com@lists.yoctoproject.org> wrote:
>
> On 6 May 2025, at 17:50, ali.oezaslan via lists.yoctoproject.org <ali.oezaslan=arm.com@lists.yoctoproject.org> wrote:
> >
> > From: Ali Can Ozaslan <ali.oezaslan@arm.com>
> >
> > The psa_client_key_attributes_s struct had to be aligned with the
> > psa_key_attributes_s struct in TF-M.
> >
> > Signed-off-by: Ali Can Ozaslan <ali.oezaslan@arm.com>
> > ---
> > components/service/crypto/include/psa/crypto_client_struct.h | 1 -
>
> I’m guessing that you’re doing git-format-patch and then git-send-email manually, because the cover letter is correct but this is a patch for TF-M, not meta-arm.
>
> Can you re-send?
>
> Ross
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6497): https://lists.yoctoproject.org/g/meta-arm/message/6497
> Mute This Topic: https://lists.yoctoproject.org/mt/112652834/3616920
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [jdmason@kudzu.us]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/components/service/crypto/include/psa/crypto_client_struct.h b/components/service/crypto/include/psa/crypto_client_struct.h
index ebc4008..f0c8cad 100644
--- a/components/service/crypto/include/psa/crypto_client_struct.h
+++ b/components/service/crypto/include/psa/crypto_client_struct.h
@@ -38,7 +38,6 @@  struct psa_client_key_attributes_s
     uint32_t alg;
     uint32_t alg2;
     uint32_t id;
-    int32_t owner_id;
 };
 
 #define PSA_CLIENT_KEY_ATTRIBUTES_INIT {0, 0, 0, 0, 0, 0}