diff mbox series

[styhead] arm-system-ready/arm-systemready-ir-acs: add version to download filename

Message ID 20250326132032.423938-1-ross.burton@arm.com
State New
Headers show
Series [styhead] arm-system-ready/arm-systemready-ir-acs: add version to download filename | expand

Commit Message

Ross Burton March 26, 2025, 1:20 p.m. UTC 
The download filename wasn't versioned so multiple versions would write
to the same file on disk and conflict, causing repeated downloads and
fetch failures.

Add the PV to the filename on disk to resolve this.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Jon Mason <jon.mason@arm.com>
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../arm-systemready-acs/arm-systemready-ir-acs.bb             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jon Mason March 27, 2025, 5:02 p.m. UTC | #1 
On Wed, 26 Mar 2025 13:20:32 +0000, Ross Burton wrote:
> The download filename wasn't versioned so multiple versions would write
> to the same file on disk and conflict, causing repeated downloads and
> fetch failures.
> 
> Add the PV to the filename on disk to resolve this.
> 
> 
> [...]

Applied, thanks!

[1/1] arm-system-ready/arm-systemready-ir-acs: add version to download filename
      commit: 9c548d16e099c9981b9b557ef2df4481605ffcf4

Best regards,
diff mbox series

Patch

diff --git a/meta-arm-systemready/recipes-test/arm-systemready-acs/arm-systemready-ir-acs.bb b/meta-arm-systemready/recipes-test/arm-systemready-acs/arm-systemready-ir-acs.bb
index 83257b30..eef1c045 100644
--- a/meta-arm-systemready/recipes-test/arm-systemready-acs/arm-systemready-ir-acs.bb
+++ b/meta-arm-systemready/recipes-test/arm-systemready-acs/arm-systemready-ir-acs.bb
@@ -49,9 +49,9 @@  PV = "2.0.0"
 PV_DATE = "23.03"
 FULL_PV = "v${PV_DATE}_${PV}"
 ARM_SYSTEMREADY_IR_ACS_BRANCH ?= "main"
-IMAGE_FILENAME = "ir-acs-live-image-generic-arm64.wic"
+IMAGE_FILENAME = "ir-acs-live-image-generic-arm64-${PV}.wic"
 SRC_URI = " \
-    https://github.com/ARM-software/arm-systemready/raw/${ARM_SYSTEMREADY_IR_ACS_BRANCH}/IR/prebuilt_images/${FULL_PV}/${IMAGE_FILENAME}.xz;name=acs-img \
+    https://github.com/ARM-software/arm-systemready/raw/${ARM_SYSTEMREADY_IR_ACS_BRANCH}/IR/prebuilt_images/${FULL_PV}/ir-acs-live-image-generic-arm64.wic.xz;name=acs-img;downloadfilename=${IMAGE_FILENAME}.xz \
     git://git.gitlab.arm.com/systemready/systemready-ir-template.git;protocol=https;nobranch=1;destsuffix=systemready-ir-template;name=sr-ir-template \
 "
 SRC_URI[acs-img.sha256sum] = "ea52f84dab44bde97de3e2d2224d883acaae35724dd8e2bdfb125de49040f9b3"