diff mbox series

[v4,01/13] qemuarm64-secureboot: Introduce uefi-secureboot machine feature

Message ID 20240829163209.47945-2-javier.tia@linaro.org
State New
Headers show
Series qemuarm64-secureboot: Add UEFI Secure Boot | expand

Commit Message

Javier Tia Aug. 29, 2024, 4:31 p.m. UTC
Signed-off-by: Javier Tia <javier.tia@linaro.org>
---
 meta-arm/conf/machine/qemuarm64-secureboot.conf | 1 +
 1 file changed, 1 insertion(+)

Comments

Jon Mason Aug. 30, 2024, 3:42 p.m. UTC | #1
On Thu, Aug 29, 2024 at 10:31:57AM -0600, Javier Tia wrote:
> Signed-off-by: Javier Tia <javier.tia@linaro.org>
> ---
>  meta-arm/conf/machine/qemuarm64-secureboot.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-arm/conf/machine/qemuarm64-secureboot.conf b/meta-arm/conf/machine/qemuarm64-secureboot.conf
> index 78a39c03..2483c4ac 100644
> --- a/meta-arm/conf/machine/qemuarm64-secureboot.conf
> +++ b/meta-arm/conf/machine/qemuarm64-secureboot.conf
> @@ -22,3 +22,4 @@ WKS_FILE_DEPENDS = "trusted-firmware-a"
>  IMAGE_BOOT_FILES = "${KERNEL_IMAGETYPE}"
>  
>  MACHINE_FEATURES += "optee-ftpm"
> +MACHINE_FEATURES += "uefi-secureboot"

This should be squashed into another patch.  I'm thinking there should
really just be 3.  

1.  Add support for UEFI secure boot to all of the packages (kernel,
u-boot, etc)
2.  add systemd (if it is really needed)
3.  Add support for UEFI secure boot to qemuarm64-secureboot

With an overall philosophy of "Each patch should do 1 unique thing and
be git bisectable".  As they are now, they are not in a bisectable
order, and are so small that I have to go back-and-forth between the
emails to understand the concepts and make sure there is nothing
missing overall.  I apologize for not saying this in prior revisions,
but per my previous email, I don't really look at patches until they
pass CI.

Thanks,
Jon

> -- 
> 2.46.0
> 
>
diff mbox series

Patch

diff --git a/meta-arm/conf/machine/qemuarm64-secureboot.conf b/meta-arm/conf/machine/qemuarm64-secureboot.conf
index 78a39c03..2483c4ac 100644
--- a/meta-arm/conf/machine/qemuarm64-secureboot.conf
+++ b/meta-arm/conf/machine/qemuarm64-secureboot.conf
@@ -22,3 +22,4 @@  WKS_FILE_DEPENDS = "trusted-firmware-a"
 IMAGE_BOOT_FILES = "${KERNEL_IMAGETYPE}"
 
 MACHINE_FEATURES += "optee-ftpm"
+MACHINE_FEATURES += "uefi-secureboot"