diff mbox series

test-pacbti: Switch away from S = WORKDIR

Message ID 20240527103734.2224649-1-martin.jansa@gmail.com
State New
Headers show
Series test-pacbti: Switch away from S = WORKDIR | expand

Commit Message

Martin Jansa May 27, 2024, 10:37 a.m. UTC
* like oe-core did in:
  https://git.openembedded.org/openembedded-core/commit/?id=d9328e3b0b062f0621de3d114584b44f384a1c02

* it's fatal for parsing now:
  https://git.openembedded.org/openembedded-core/commit/?id=32cba1cc916ad530c5e6630a927e74ca6f06289b
  ERROR: meta-arm/meta-arm/recipes-test/pacbti/test-pacbti.bb: Using S = ${WORKDIR} is no longer supported
  ERROR: Parsing halted due to errors, see error messages above

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
---
 meta-arm/recipes-test/pacbti/test-pacbti.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jon Mason May 30, 2024, 1:43 p.m. UTC | #1
On Mon, May 27, 2024 at 12:37:34PM +0200, Martin Jansa wrote:
> * like oe-core did in:
>   https://git.openembedded.org/openembedded-core/commit/?id=d9328e3b0b062f0621de3d114584b44f384a1c02
> 
> * it's fatal for parsing now:
>   https://git.openembedded.org/openembedded-core/commit/?id=32cba1cc916ad530c5e6630a927e74ca6f06289b
>   ERROR: meta-arm/meta-arm/recipes-test/pacbti/test-pacbti.bb: Using S = ${WORKDIR} is no longer supported
>   ERROR: Parsing halted due to errors, see error messages above
> 
> Signed-off-by: Martin Jansa <martin.jansa@gmail.com>

Ryan sent a patch to address the same issue on Friday.  Since his was
first, I'll take that one.  Unfortunately, I need to delay applying it
for a couple of weeks due to an upcoming BSP release.

Thanks,
Jon

> ---
>  meta-arm/recipes-test/pacbti/test-pacbti.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arm/recipes-test/pacbti/test-pacbti.bb b/meta-arm/recipes-test/pacbti/test-pacbti.bb
> index 331c5854..b0ce1988 100644
> --- a/meta-arm/recipes-test/pacbti/test-pacbti.bb
> +++ b/meta-arm/recipes-test/pacbti/test-pacbti.bb
> @@ -4,7 +4,8 @@ LIC_FILES_CHKSUM = "file://pacbti.c;beginline=2;endline=2;md5=6ec41034e04432ee37
>  
>  SRC_URI = "file://pacbti.c"
>  
> -S = "${WORKDIR}"
> +S = "${WORKDIR}/sources"
> +UNPACKDIR = "${S}"
>  
>  do_compile() {
>      # Compile with -zforce-bti with fatal warnings, so the link fails if PAC/BTI
> -- 
> 2.45.1
> 
>
diff mbox series

Patch

diff --git a/meta-arm/recipes-test/pacbti/test-pacbti.bb b/meta-arm/recipes-test/pacbti/test-pacbti.bb
index 331c5854..b0ce1988 100644
--- a/meta-arm/recipes-test/pacbti/test-pacbti.bb
+++ b/meta-arm/recipes-test/pacbti/test-pacbti.bb
@@ -4,7 +4,8 @@  LIC_FILES_CHKSUM = "file://pacbti.c;beginline=2;endline=2;md5=6ec41034e04432ee37
 
 SRC_URI = "file://pacbti.c"
 
-S = "${WORKDIR}"
+S = "${WORKDIR}/sources"
+UNPACKDIR = "${S}"
 
 do_compile() {
     # Compile with -zforce-bti with fatal warnings, so the link fails if PAC/BTI