diff mbox series

[1/2] CI: remove redundant variables in testimage.yml

Message ID 20230918111622.650459-1-ross.burton@arm.com
State New
Headers show
Series [1/2] CI: remove redundant variables in testimage.yml | expand

Commit Message

Ross Burton Sept. 18, 2023, 11:16 a.m. UTC 
From: Ross Burton <ross.burton@arm.com>

QEMU_USE_SLIRP is no longer needed[1] as adding slirp to
TEST_RUNQEMUPARAMS is sufficient, so remove that.

Setting TEST_SERVER_IP also isn't needed as there's a default value now,
and we disable the package management tests that would use the server
IP.  When they work the correct IP can be set.

[1] As of oe-core f4e8650

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 ci/testimage.yml | 2 --
 1 file changed, 2 deletions(-)

Comments

Jon Mason Sept. 19, 2023, 12:45 p.m. UTC | #1 
On Mon, 18 Sep 2023 12:16:21 +0100, ross.burton@arm.com wrote:
> QEMU_USE_SLIRP is no longer needed[1] as adding slirp to
> TEST_RUNQEMUPARAMS is sufficient, so remove that.
> 
> Setting TEST_SERVER_IP also isn't needed as there's a default value now,
> and we disable the package management tests that would use the server
> IP.  When they work the correct IP can be set.
> 
> [...]

Applied, thanks!

[1/2] CI: remove redundant variables in testimage.yml
      commit: 9f2e78698e8ab3a53fbdec12a883039003f3406a
[2/2] arm-bsp: change port mapping for SSH to port 2222
      commit: db5a3093f3f597d769c2608b04e2a2615f02fbc8

Best regards,
Jon Mason Sept. 22, 2023, 6:20 p.m. UTC | #2 
On Mon, 18 Sep 2023 12:16:21 +0100, ross.burton@arm.com wrote:
> QEMU_USE_SLIRP is no longer needed[1] as adding slirp to
> TEST_RUNQEMUPARAMS is sufficient, so remove that.
> 
> Setting TEST_SERVER_IP also isn't needed as there's a default value now,
> and we disable the package management tests that would use the server
> IP.  When they work the correct IP can be set.
> 
> [...]

Applied, thanks!

[1/2] CI: remove redundant variables in testimage.yml
      commit: 9f2e78698e8ab3a53fbdec12a883039003f3406a
[2/2] arm-bsp: change port mapping for SSH to port 2222
      commit: db5a3093f3f597d769c2608b04e2a2615f02fbc8

Best regards,
diff mbox series

Patch

diff --git a/ci/testimage.yml b/ci/testimage.yml
index f496ec1c..a0e90250 100644
--- a/ci/testimage.yml
+++ b/ci/testimage.yml
@@ -11,8 +11,6 @@  local_conf_header:
     QEMU_USE_KVM = ""
   slirp: |
     TEST_RUNQEMUPARAMS = "slirp"
-    TEST_SERVER_IP = "127.0.0.1"
-    QEMU_USE_SLIRP = "1"
   sshd: |
     IMAGE_FEATURES:append = " ssh-server-dropbear"
   sshkeys: |