| Message ID | 20230515111522.657505-1-claus.stovgaard@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | arm-toolchain/gcc: Workaround for missing libcrypt | expand |
On Mon, May 15, 2023 at 01:15:22PM +0200, Claus Stovgaard wrote: > gcc-arm-none-eabi and gcc-aarch64-none-elf both fails when packaged as > RPM for sdk with > > nothing provides libcrypt.so.1()(64bit) needed by nativesdk-gcc-arm-none-eabi-12.2.rel1-r0.x86_64_nativesdk > > This is a workaround by skipping the FILEDEPS A little more verbosity here would be nice. Something describing how prebuilt libraries might link to libraries that aren't present and becuse they are prebuilt, we don't control the dependencies. We don't need a book, just 3-4 sentences. Also, missing your Signed-off-by line > --- > .../external-arm-toolchain/arm-binary-toolchain.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc > index 528b0061..4d7241c5 100644 > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc > @@ -24,3 +24,5 @@ INHIBIT_PACKAGE_DEBUG_SPLIT = "1" > PRIVATE_LIBS = "libgcc_s.so.1 libstdc++.so.6" > > BBCLASSEXTEND = "native nativesdk" > + It would be nice to have a comment here about why this was added, to save people from looking at the log when doing quick edits. Perhaps something like: # skipping file deps because of libcrypt issue > +SKIP_FILEDEPS="1" > -- > 2.39.3 > >
On Tue, 2023-05-16 at 10:55 -0400, Jon Mason wrote: > On Mon, May 15, 2023 at 01:15:22PM +0200, Claus Stovgaard wrote: > > gcc-arm-none-eabi and gcc-aarch64-none-elf both fails when packaged > > as > > RPM for sdk with > > > > nothing provides libcrypt.so.1()(64bit) needed by nativesdk-gcc- > > arm-none-eabi-12.2.rel1-r0.x86_64_nativesdk > > > > This is a workaround by skipping the FILEDEPS > > A little more verbosity here would be nice. Something describing how > prebuilt libraries might link to libraries that aren't present and > becuse they are prebuilt, we don't control the dependencies. We > don't > need a book, just 3-4 sentences. > > Also, missing your Signed-off-by line > Thanks for your review and sory for the delay in following up. Will send a V2 shortly, fixing it. > > --- > > > > BBCLASSEXTEND = "native nativesdk" > > + > > It would be nice to have a comment here about why this was added, to > save people from looking at the log when doing quick edits. Perhaps > something like: > > # skipping file deps because of libcrypt issue > > > +SKIP_FILEDEPS="1" > > -- Good point - have added a bit more description Regards Claus
On Mon, 15 May 2023 13:15:22 +0200, Claus Stovgaard wrote: > gcc-arm-none-eabi and gcc-aarch64-none-elf both fails when packaged as > RPM for sdk with > > nothing provides libcrypt.so.1()(64bit) needed by nativesdk-gcc-arm-none-eabi-12.2.rel1-r0.x86_64_nativesdk > > This is a workaround by skipping the FILEDEPS Applied, thanks! [1/1] arm-toolchain/gcc: Workaround for missing libcrypt commit: 3fcafa3a945aa57d58ca4f1a0f6d20280df7cdbd Best regards,
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc index 528b0061..4d7241c5 100644 --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc @@ -24,3 +24,5 @@ INHIBIT_PACKAGE_DEBUG_SPLIT = "1" PRIVATE_LIBS = "libgcc_s.so.1 libstdc++.so.6" BBCLASSEXTEND = "native nativesdk" + +SKIP_FILEDEPS="1"