diff mbox series

arm/oeqa: Fix regex warning in linuxboot test case

Message ID 20220726153536.3573383-1-peter.hoyes@arm.com
State New
Headers show
Series arm/oeqa: Fix regex warning in linuxboot test case | expand

Commit Message

Peter Hoyes July 26, 2022, 3:35 p.m. UTC 
From: Peter Hoyes <Peter.Hoyes@arm.com>

The linuxboot test case prints the following in log.do_testimage, only
when executing testimage without a pycache:

  linuxboot.py:18: DeprecationWarning: invalid escape sequence \:
    self.target.expect(self.console, "login\:", timeout=10*60)

Fix the warning by escaping the ':' character correctly in the pexpect
regex.

Issue-Id: SCM-4957
Signed-off-by: Peter Hoyes <Peter.Hoyes@arm.com>
Change-Id: I8ad54c7df6b7d1d1ddeab31cf66daff1ab84e227
---
 meta-arm/lib/oeqa/runtime/cases/linuxboot.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jon Mason July 26, 2022, 8:48 p.m. UTC | #1 
On Tue, 26 Jul 2022 16:35:36 +0100, Peter Hoyes wrote:
> The linuxboot test case prints the following in log.do_testimage, only
> when executing testimage without a pycache:
> 
>   linuxboot.py:18: DeprecationWarning: invalid escape sequence \:
>     self.target.expect(self.console, "login\:", timeout=10*60)
> 
> Fix the warning by escaping the ':' character correctly in the pexpect
> regex.

Applied, thanks!

[1/1] arm/oeqa: Fix regex warning in linuxboot test case
      commit: ef879b5fb87910b80ed19e7bf036d3c6b0684f89

Best regards,
Peter Hoyes July 27, 2022, 9:29 a.m. UTC | #2 
On 26/07/2022 21:48, Jon Mason wrote:
> On Tue, 26 Jul 2022 16:35:36 +0100, Peter Hoyes wrote:
>> The linuxboot test case prints the following in log.do_testimage, only
>> when executing testimage without a pycache:
>>
>>    linuxboot.py:18: DeprecationWarning: invalid escape sequence \:
>>      self.target.expect(self.console, "login\:", timeout=10*60)
>>
>> Fix the warning by escaping the ':' character correctly in the pexpect
>> regex.
> Applied, thanks!
>
> [1/1] arm/oeqa: Fix regex warning in linuxboot test case
>        commit: ef879b5fb87910b80ed19e7bf036d3c6b0684f89
>
> Best regards,
Please can this patch be backported to kirkstone.
Jon Mason July 27, 2022, 9:53 p.m. UTC | #3 
On Wed, Jul 27, 2022 at 10:29:22AM +0100, Peter Hoyes wrote:
> On 26/07/2022 21:48, Jon Mason wrote:
> > On Tue, 26 Jul 2022 16:35:36 +0100, Peter Hoyes wrote:
> > > The linuxboot test case prints the following in log.do_testimage, only
> > > when executing testimage without a pycache:
> > > 
> > >    linuxboot.py:18: DeprecationWarning: invalid escape sequence \:
> > >      self.target.expect(self.console, "login\:", timeout=10*60)
> > > 
> > > Fix the warning by escaping the ':' character correctly in the pexpect
> > > regex.
> > Applied, thanks!
> > 
> > [1/1] arm/oeqa: Fix regex warning in linuxboot test case
> >        commit: ef879b5fb87910b80ed19e7bf036d3c6b0684f89
> > 
> > Best regards,
> Please can this patch be backported to kirkstone.
> 
Done
diff mbox series

Patch

diff --git a/meta-arm/lib/oeqa/runtime/cases/linuxboot.py b/meta-arm/lib/oeqa/runtime/cases/linuxboot.py
index 19e6e18..8994405 100644
--- a/meta-arm/lib/oeqa/runtime/cases/linuxboot.py
+++ b/meta-arm/lib/oeqa/runtime/cases/linuxboot.py
@@ -15,4 +15,4 @@  class LinuxBootTest(OERuntimeTestCase):
 
     def test_linux_boot(self):
         self.logger.info(f"{self.console}: Waiting for login prompt")
-        self.target.expect(self.console, "login\:", timeout=10*60)
+        self.target.expect(self.console, r"login\:", timeout=10*60)