[1/3] arm-toolchain/androidclang: strip meaningless RPATHS

Message ID 20220616112252.3326107-1-ross.burton@arm.com
State New
Headers show
Series [1/3] arm-toolchain/androidclang: strip meaningless RPATHS | expand

Commit Message

Ross Burton June 16, 2022, 11:22 a.m. UTC
As per [1], target builds of androidclang produce useless-rpath errors.

/usr/share/clang-r416183b/python3/lib/python3.9/lib-dynload/_posixsubprocess.cpython-39-x86_64-linux-gnu.so
contains probably-redundant RPATH /../lib [useless-rpaths]

Those RPATHs are of no use, so we can remove them entirely.

[1] https://errors.yoctoproject.org/Errors/Details/640604/

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/androidclang_r416183b.bb           | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Ross Burton June 16, 2022, 1:25 p.m. UTC | #1
Retracting this, it turns out it is needed.

Ross

> On 16 Jun 2022, at 12:22, Ross Burton via lists.yoctoproject.org <ross.burton=arm.com@lists.yoctoproject.org> wrote:
> 
> This file isn't used, so remove it.
> 
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> .../external-arm-toolchain/external-arm-toolchain.bb            | 2 --
> .../recipes-devtools/external-arm-toolchain/files/SUPPORTED     | 1 -
> 2 files changed, 3 deletions(-)
> delete mode 100644 meta-arm-toolchain/recipes-devtools/external-arm-toolchain/files/SUPPORTED
> 
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> index dcc8ebf0..ae605aad 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain.bb
> @@ -55,8 +55,6 @@ PV = "${EAT_VER_MAIN}"
> 
> BINV = "${EAT_VER_GCC}"
> 
> -SRC_URI = "file://SUPPORTED"
> -
> do_install() {
> 	# Add stubs for files OE-core expects
> 	install -d ${S}/nscd/
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/files/SUPPORTED b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/files/SUPPORTED
> deleted file mode 100644
> index 9615075e..00000000
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/files/SUPPORTED
> +++ /dev/null
> @@ -1 +0,0 @@
> -POSIX
> -- 
> 2.25.1
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#3509): https://lists.yoctoproject.org/g/meta-arm/message/3509
> Mute This Topic: https://lists.yoctoproject.org/mt/91796807/6875888
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [ross.burton@arm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Jon Mason June 16, 2022, 3:35 p.m. UTC | #2
On Thu, 16 Jun 2022 12:22:50 +0100, Ross Burton wrote:
> As per [1], target builds of androidclang produce useless-rpath errors.
> 
> /usr/share/clang-r416183b/python3/lib/python3.9/lib-dynload/_posixsubprocess.cpython-39-x86_64-linux-gnu.so
> contains probably-redundant RPATH /../lib [useless-rpaths]
> 
> Those RPATHs are of no use, so we can remove them entirely.
> 
> [...]

Applied, thanks!

[1/3] arm-toolchain/androidclang: strip meaningless RPATHS
      commit: c4041b667dbab0285145bdc78decc85e341e0072
[2/3] arm-toolchain/androidclang: move to libexecdir
      commit: 70132043376ea3104c95f94ef19932aa36f4dd52
[3/3] arm-toolchain/external-arm-toolchain: remove pointless SUPPORTED file
      (no commit info)

Best regards,

Patch

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/androidclang_r416183b.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/androidclang_r416183b.bb
index 82133886..c8640d76 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/androidclang_r416183b.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/androidclang_r416183b.bb
@@ -33,6 +33,8 @@  do_install() {
     install -d ${D}${datadir}/${ANDROID_CLANG_VERSION}/
 
     cp --no-preserve=ownership -r ${S}/. ${D}${datadir}/${ANDROID_CLANG_VERSION}/
+    # Strip bad RPATHs in the embedded python3
+    chrpath -d ${D}${datadir}/${ANDROID_CLANG_VERSION}/python3/lib/python*/lib-dynload/*.so
 
     install -d ${D}${bindir}
     # Symlink all executables into bindir
@@ -43,7 +45,7 @@  do_install() {
 
 INHIBIT_DEFAULT_DEPS = "1"
 
-INSANE_SKIP:${PN} = "already-stripped libdir staticdev file-rdeps arch dev-so useless-rpaths"
+INSANE_SKIP:${PN} = "already-stripped libdir staticdev file-rdeps arch dev-so"
 
 INHIBIT_SYSROOT_STRIP = "1"
 INHIBIT_PACKAGE_STRIP = "1"