diff mbox series

poky-tiny: correct override syntax in poky-tiny.conf

Message ID 20250328193233.21309-1-peter.marko@siemens.com (mailing list archive)
State New
Headers show
Series poky-tiny: correct override syntax in poky-tiny.conf | expand

Commit Message

Peter Marko March 28, 2025, 7:32 p.m. UTC
From: Peter Marko <peter.marko@siemens.com>

it's a comment but should be anyway migrated to new override syntax

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta-poky/conf/distro/poky-tiny.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Khem Raj March 28, 2025, 8:55 p.m. UTC | #1
On Fri, Mar 28, 2025 at 12:33 PM Peter Marko via
lists.yoctoproject.org
<peter.marko=siemens.com@lists.yoctoproject.org> wrote:
>
> From: Peter Marko <peter.marko@siemens.com>
>
> it's a comment but should be anyway migrated to new override syntax
>
> Signed-off-by: Peter Marko <peter.marko@siemens.com>
> ---
>  meta-poky/conf/distro/poky-tiny.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-poky/conf/distro/poky-tiny.conf b/meta-poky/conf/distro/poky-tiny.conf
> index 20c13e6f60..075702a32c 100644
> --- a/meta-poky/conf/distro/poky-tiny.conf
> +++ b/meta-poky/conf/distro/poky-tiny.conf
> @@ -39,7 +39,7 @@ TCLIBC = "musl"
>  FULL_OPTIMIZATION = "-Os"
>
>  # FIXME: consider adding a new "tiny" feature

Is this comment still valid, I wonder. I know its in there from day 1
of this file.

> -#DISTRO_FEATURES_append = " tiny"
> +#DISTRO_FEATURES:append = " tiny"
>
>  # Distro config is evaluated after the machine config, so we have to explicitly
>  # set the kernel provider to override a machine config.
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#13582): https://lists.yoctoproject.org/g/poky/message/13582
> Mute This Topic: https://lists.yoctoproject.org/mt/111960658/1997914
> Group Owner: poky+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/poky/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Richard Purdie March 31, 2025, 8:30 a.m. UTC | #2
On Fri, 2025-03-28 at 13:55 -0700, Khem Raj via lists.yoctoproject.org
wrote:
> On Fri, Mar 28, 2025 at 12:33 PM Peter Marko via
> lists.yoctoproject.org
> <peter.marko=siemens.com@lists.yoctoproject.org> wrote:
> > 
> > From: Peter Marko <peter.marko@siemens.com>
> > 
> > it's a comment but should be anyway migrated to new override syntax
> > 
> > Signed-off-by: Peter Marko <peter.marko@siemens.com>
> > ---
> >  meta-poky/conf/distro/poky-tiny.conf | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-poky/conf/distro/poky-tiny.conf b/meta-
> > poky/conf/distro/poky-tiny.conf
> > index 20c13e6f60..075702a32c 100644
> > --- a/meta-poky/conf/distro/poky-tiny.conf
> > +++ b/meta-poky/conf/distro/poky-tiny.conf
> > @@ -39,7 +39,7 @@ TCLIBC = "musl"
> >  FULL_OPTIMIZATION = "-Os"
> > 
> >  # FIXME: consider adding a new "tiny" feature
> 
> Is this comment still valid, I wonder. I know its in there from day 1
> of this file.

I merged a different version of this which just removes the line and
the comment.

Cheers,

Richard
diff mbox series

Patch

diff --git a/meta-poky/conf/distro/poky-tiny.conf b/meta-poky/conf/distro/poky-tiny.conf
index 20c13e6f60..075702a32c 100644
--- a/meta-poky/conf/distro/poky-tiny.conf
+++ b/meta-poky/conf/distro/poky-tiny.conf
@@ -39,7 +39,7 @@  TCLIBC = "musl"
 FULL_OPTIMIZATION = "-Os"
 
 # FIXME: consider adding a new "tiny" feature
-#DISTRO_FEATURES_append = " tiny"
+#DISTRO_FEATURES:append = " tiny"
 
 # Distro config is evaluated after the machine config, so we have to explicitly
 # set the kernel provider to override a machine config.