| Message ID | 20231106171051.3741517-1-raj.khem@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | poky: Do not inherit uninative on ppc64le and riscv64 hosts | expand |
On Mon, 2023-11-06 at 09:10 -0800, Khem Raj wrote: > uninative tarballs for these architectures is not available > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta-poky/conf/distro/poky.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta-poky/conf/distro/poky.conf b/meta-poky/conf/distro/poky.conf > index e742666b4e5..ccad9c835a7 100644 > --- a/meta-poky/conf/distro/poky.conf > +++ b/meta-poky/conf/distro/poky.conf > @@ -62,7 +62,7 @@ require conf/distro/include/poky-world-exclude.inc > require conf/distro/include/no-static-libs.inc > require conf/distro/include/yocto-uninative.inc > require conf/distro/include/security_flags.inc > -INHERIT += "uninative" > +INHERIT += "${@bb.utils.contains_any('BUILD_ARCH', 'ppc64le riscv64', '', 'uninative', d)}" > > BB_SIGNATURE_HANDLER ?= "OEEquivHash" > BB_HASHSERVE ??= "auto" I really don't like conditional inherits and I suspect there are other architectures this doesn't work. It would probably better to improve the uninative code itself. Cheers, Richard
On Mon, Nov 6, 2023 at 9:24 AM Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > > On Mon, 2023-11-06 at 09:10 -0800, Khem Raj wrote: > > uninative tarballs for these architectures is not available > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta-poky/conf/distro/poky.conf | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta-poky/conf/distro/poky.conf b/meta-poky/conf/distro/poky.conf > > index e742666b4e5..ccad9c835a7 100644 > > --- a/meta-poky/conf/distro/poky.conf > > +++ b/meta-poky/conf/distro/poky.conf > > @@ -62,7 +62,7 @@ require conf/distro/include/poky-world-exclude.inc > > require conf/distro/include/no-static-libs.inc > > require conf/distro/include/yocto-uninative.inc > > require conf/distro/include/security_flags.inc > > -INHERIT += "uninative" > > +INHERIT += "${@bb.utils.contains_any('BUILD_ARCH', 'ppc64le riscv64', '', 'uninative', d)}" > > > > BB_SIGNATURE_HANDLER ?= "OEEquivHash" > > BB_HASHSERVE ??= "auto" > > I really don't like conditional inherits and I suspect there are other > architectures this doesn't work. Yes, there are perhaps everything besides x86/arm64 because we need uninative tarballs and for them we need host machines with those architectures. so essentially this restricts bootstrapping a new architecture for build unless its in AB, it seems we need to build uninative tarballs as first step. > > It would probably better to improve the uninative code itself. yeah, maybe add a diagnostic and logic to do no harm if uninative tarball is not supported > > Cheers, > > Richard >
diff --git a/meta-poky/conf/distro/poky.conf b/meta-poky/conf/distro/poky.conf index e742666b4e5..ccad9c835a7 100644 --- a/meta-poky/conf/distro/poky.conf +++ b/meta-poky/conf/distro/poky.conf @@ -62,7 +62,7 @@ require conf/distro/include/poky-world-exclude.inc require conf/distro/include/no-static-libs.inc require conf/distro/include/yocto-uninative.inc require conf/distro/include/security_flags.inc -INHERIT += "uninative" +INHERIT += "${@bb.utils.contains_any('BUILD_ARCH', 'ppc64le riscv64', '', 'uninative', d)}" BB_SIGNATURE_HANDLER ?= "OEEquivHash" BB_HASHSERVE ??= "auto"
uninative tarballs for these architectures is not available Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-poky/conf/distro/poky.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)