| Message ID | 20230213143557.766119-1-u.oelmann@pengutronix.de |
|---|---|
| State | Accepted |
| Commit | b66c035970f860b65cf712285f2d5a023620e6c3 |
| Headers | show |
| Series | [1/3] kernel-dev,ref-manual: fix old override syntax | expand |
Hi Ulrich, Thanks for the patches. For the whole series: Reviewed-by: Quentin Schulz <foss+yocto@0leil.net> Cheers, Quentin On 2/13/23 15:35, Ulrich Ölmann wrote: > Additionally use more common syntax to indicate that an actual machine name is > supposed to be filled in for a concrete use case as has been suggested by Peter > Kjellerstedt (and particularly no KMACHINE). Furthermore add missing quotes in > the reference manual. > > Suggested-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> > Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> > --- > documentation/kernel-dev/common.rst | 2 +- > documentation/ref-manual/variables.rst | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/documentation/kernel-dev/common.rst b/documentation/kernel-dev/common.rst > index dff8f504fd6f..3c8e0b74e9b5 100644 > --- a/documentation/kernel-dev/common.rst > +++ b/documentation/kernel-dev/common.rst > @@ -649,7 +649,7 @@ append files, you can direct the OpenEmbedded build system to use a > To specify an "in-tree" ``defconfig`` file, use the following statement > form:: > > - KBUILD_DEFCONFIG_KMACHINE ?= "defconfig_file" > + KBUILD_DEFCONFIG:<machine> ?= "defconfig_file" > > Here is an example > that assigns the :term:`KBUILD_DEFCONFIG` variable based on "raspberrypi2" > diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst > index a36c4c6df962..54da54f71d72 100644 > --- a/documentation/ref-manual/variables.rst > +++ b/documentation/ref-manual/variables.rst > @@ -4275,7 +4275,7 @@ system and gives an overview of their function and contents. > To use the variable, set it in the append file for your kernel recipe > using the following form:: > > - KBUILD_DEFCONFIG_KMACHINE ?= defconfig_file > + KBUILD_DEFCONFIG:<machine> ?= "defconfig_file" > > Here is an example from a "raspberrypi2" :term:`KMACHINE` build that uses > a ``defconfig`` file named "bcm2709_defconfig"::
Ulrich, Many thanks for the patches! Quentin, Peter, Thanks for the reviews! On 13.02.23 at 15:59, Quentin Schulz via lists.yoctoproject.org wrote: > Hi Ulrich, > > Thanks for the patches. > > For the whole series: > Reviewed-by: Quentin Schulz <foss+yocto@0leil.net> Merged into "master-next". Never too late for further comments, if any, of course. Thanks again Michael.
diff --git a/documentation/kernel-dev/common.rst b/documentation/kernel-dev/common.rst index dff8f504fd6f..3c8e0b74e9b5 100644 --- a/documentation/kernel-dev/common.rst +++ b/documentation/kernel-dev/common.rst @@ -649,7 +649,7 @@ append files, you can direct the OpenEmbedded build system to use a To specify an "in-tree" ``defconfig`` file, use the following statement form:: - KBUILD_DEFCONFIG_KMACHINE ?= "defconfig_file" + KBUILD_DEFCONFIG:<machine> ?= "defconfig_file" Here is an example that assigns the :term:`KBUILD_DEFCONFIG` variable based on "raspberrypi2" diff --git a/documentation/ref-manual/variables.rst b/documentation/ref-manual/variables.rst index a36c4c6df962..54da54f71d72 100644 --- a/documentation/ref-manual/variables.rst +++ b/documentation/ref-manual/variables.rst @@ -4275,7 +4275,7 @@ system and gives an overview of their function and contents. To use the variable, set it in the append file for your kernel recipe using the following form:: - KBUILD_DEFCONFIG_KMACHINE ?= defconfig_file + KBUILD_DEFCONFIG:<machine> ?= "defconfig_file" Here is an example from a "raspberrypi2" :term:`KMACHINE` build that uses a ``defconfig`` file named "bcm2709_defconfig"::
Additionally use more common syntax to indicate that an actual machine name is supposed to be filled in for a concrete use case as has been suggested by Peter Kjellerstedt (and particularly no KMACHINE). Furthermore add missing quotes in the reference manual. Suggested-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de> --- documentation/kernel-dev/common.rst | 2 +- documentation/ref-manual/variables.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)