| Message ID | 20221031114719.2725967-12-alex@linutronix.de |
|---|---|
| State | Accepted, archived |
| Commit | 40d24b0b5c7a405bf9fd7ec7fa57ec61a6af3d01 |
| Headers | show |
| Series | [01/13] cargo-update-recipe-crates.bbclass: add a class to generate SRC_URI crate lists from Cargo.lock | expand |
On Mon, 2022-10-31 at 12:47 +0100, Alexander Kanavin wrote: > Note: it will not be reviewed until RP signs the google CLA > (link in the PR). > > Signed-off-by: Alexander Kanavin <alex@linutronix.de> > --- > meta/recipes-devtools/go/go/filter-build-paths.patch | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-devtools/go/go/filter-build-paths.patch b/meta/recipes-devtools/go/go/filter-build-paths.patch > index a1aa37c2a4..a036f177e0 100644 > --- a/meta/recipes-devtools/go/go/filter-build-paths.patch > +++ b/meta/recipes-devtools/go/go/filter-build-paths.patch > @@ -8,7 +8,9 @@ embedded in the go binary so that builds are reproducible regardless of build > location. This codepath is hit for statically linked go binaries such as those > on mips/ppc. > > -Upstream-Status: Pending > +Upstream-Status: Submitted [https://github.com/golang/go/pull/56410] > +Note: RP needs to sign Google CLA for the PR to proceed. > + I did sort that, I'm not sure I quite wanted to get into a larger discussion on how to do it properly and to rewrite the patch and run more tests though... Cheers, Richard
On Mon, 31 Oct 2022 at 22:55, Richard Purdie <richard.purdie@linuxfoundation.org> wrote: > I did sort that, I'm not sure I quite wanted to get into a larger > discussion on how to do it properly and to rewrite the patch and run > more tests though... I wasn't inspired by those review comments either, perhaps we can convince upstream to take the existing patch as a 'bug report' and leave the actual fix to them. Alex
diff --git a/meta/recipes-devtools/go/go/filter-build-paths.patch b/meta/recipes-devtools/go/go/filter-build-paths.patch index a1aa37c2a4..a036f177e0 100644 --- a/meta/recipes-devtools/go/go/filter-build-paths.patch +++ b/meta/recipes-devtools/go/go/filter-build-paths.patch @@ -8,7 +8,9 @@ embedded in the go binary so that builds are reproducible regardless of build location. This codepath is hit for statically linked go binaries such as those on mips/ppc. -Upstream-Status: Pending +Upstream-Status: Submitted [https://github.com/golang/go/pull/56410] +Note: RP needs to sign Google CLA for the PR to proceed. + Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> ---
Note: it will not be reviewed until RP signs the google CLA (link in the PR). Signed-off-by: Alexander Kanavin <alex@linutronix.de> --- meta/recipes-devtools/go/go/filter-build-paths.patch | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)