python3-idna: Drop from OE-Core

Message ID 20211216132218.857571-1-richard.purdie@linuxfoundation.org
State New
Headers show
Series python3-idna: Drop from OE-Core | expand

Commit Message

Richard Purdie Dec. 16, 2021, 1:22 p.m. UTC
The only recipe mentioning python3-idna in OE-Core is python3-jsonschema.
python3-jsonschema only depends on it if the nongpl package config option
is set. We don't set this option.

The idna recipe has license issues with questions around the Unicode license
(still in meta-oe) and which version variant it should mean. We see QA warnings
in automated testing from this:

do_populate_lic: QA Issue: python3-idna: No generic license file exists for: Unicode in any provider [license-exists]

Lets drop the recipe and if needed, it can be in meta-oe.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/conf/distro/include/maintainers.inc      |  1 -
 .../python/python3-idna_3.3.bb                | 19 -------------------
 2 files changed, 20 deletions(-)
 delete mode 100644 meta/recipes-devtools/python/python3-idna_3.3.bb

Comments

Quentin Schulz Dec. 16, 2021, 5:25 p.m. UTC | #1
Hi Richard,

On December 16, 2021 2:22:18 PM GMT+01:00, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
>The only recipe mentioning python3-idna in OE-Core is python3-jsonschema.
>python3-jsonschema only depends on it if the nongpl package config option
>is set. We don't set this option.
>

That is unfortunately incorrect, it is also part of the format PACKAGECONFIG which is by default included.

>The idna recipe has license issues with questions around the Unicode license
>(still in meta-oe) and which version variant it should mean. We see QA warnings
>in automated testing from this:
>

I still shall open an issue on the GitHub tracker of the project to raise this.

Cheers,
Quentin

>do_populate_lic: QA Issue: python3-idna: No generic license file exists for: Unicode in any provider [license-exists]
>
>Lets drop the recipe and if needed, it can be in meta-oe.
>
>Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>---
> meta/conf/distro/include/maintainers.inc      |  1 -
> .../python/python3-idna_3.3.bb                | 19 -------------------
> 2 files changed, 20 deletions(-)
> delete mode 100644 meta/recipes-devtools/python/python3-idna_3.3.bb
>
>diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
>index 8e86ea45d2f..85d8a5396aa 100644
>--- a/meta/conf/distro/include/maintainers.inc
>+++ b/meta/conf/distro/include/maintainers.inc
>@@ -605,7 +605,6 @@ RECIPE_MAINTAINER:pn-python3-extras = "Oleksandr Kravchuk <open.source@oleksandr
> RECIPE_MAINTAINER:pn-python3-git = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
> RECIPE_MAINTAINER:pn-python3-gitdb = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
> RECIPE_MAINTAINER:pn-python3-hypothesis = "Tim Orling <timothy.t.orling@intel.com>"
>-RECIPE_MAINTAINER:pn-python3-idna = "Bruce Ashfield <bruce.ashfield@gmail.com>"
> RECIPE_MAINTAINER:pn-python3-importlib-metadata = "Tim Orling <timothy.t.orling@intel.com>"
> RECIPE_MAINTAINER:pn-python3-iniconfig = "Tim Orling <timothy.t.orling@intel.com>"
> RECIPE_MAINTAINER:pn-python3-iniparse = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
>diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
>deleted file mode 100644
>index a0e6b79a565..00000000000
>--- a/meta/recipes-devtools/python/python3-idna_3.3.bb
>+++ /dev/null
>@@ -1,19 +0,0 @@
>-SUMMARY = "Internationalised Domain Names in Applications"
>-HOMEPAGE = "https://github.com/kjd/idna"
>-LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
>-LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
>-
>-SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
>-
>-inherit pypi setuptools3
>-
>-# Remove bundled egg-info
>-do_compile:prepend() {
>-    rm -rf ${S}/idna.egg-info
>-}
>-
>-RDEPENDS:${PN}:class-target = "\
>-    ${PYTHON_PN}-codecs \
>-"
>-
>-BBCLASSEXTEND = "native nativesdk"
Richard Purdie Dec. 16, 2021, 8:55 p.m. UTC | #2
On Thu, 2021-12-16 at 18:25 +0100, Quentin Schulz wrote:
> Hi Richard,
> 
> On December 16, 2021 2:22:18 PM GMT+01:00, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
> > The only recipe mentioning python3-idna in OE-Core is python3-jsonschema.
> > python3-jsonschema only depends on it if the nongpl package config option
> > is set. We don't set this option.
> > 
> 
> That is unfortunately incorrect, it is also part of the format PACKAGECONFIG which is by default included.
> 
> > The idna recipe has license issues with questions around the Unicode license
> > (still in meta-oe) and which version variant it should mean. We see QA warnings
> > in automated testing from this:
> > 
> 
> I still shall open an issue on the GitHub tracker of the project to raise this.

I don't know how I didn't see the line in the format PACKAGECONFIG. I've sent a
patch to update it to Unicode-TOC as I think that matches what the header talks
about.

Cheers,

Richard

Patch

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index 8e86ea45d2f..85d8a5396aa 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -605,7 +605,6 @@  RECIPE_MAINTAINER:pn-python3-extras = "Oleksandr Kravchuk <open.source@oleksandr
 RECIPE_MAINTAINER:pn-python3-git = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
 RECIPE_MAINTAINER:pn-python3-gitdb = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
 RECIPE_MAINTAINER:pn-python3-hypothesis = "Tim Orling <timothy.t.orling@intel.com>"
-RECIPE_MAINTAINER:pn-python3-idna = "Bruce Ashfield <bruce.ashfield@gmail.com>"
 RECIPE_MAINTAINER:pn-python3-importlib-metadata = "Tim Orling <timothy.t.orling@intel.com>"
 RECIPE_MAINTAINER:pn-python3-iniconfig = "Tim Orling <timothy.t.orling@intel.com>"
 RECIPE_MAINTAINER:pn-python3-iniparse = "Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>"
diff --git a/meta/recipes-devtools/python/python3-idna_3.3.bb b/meta/recipes-devtools/python/python3-idna_3.3.bb
deleted file mode 100644
index a0e6b79a565..00000000000
--- a/meta/recipes-devtools/python/python3-idna_3.3.bb
+++ /dev/null
@@ -1,19 +0,0 @@ 
-SUMMARY = "Internationalised Domain Names in Applications"
-HOMEPAGE = "https://github.com/kjd/idna"
-LICENSE = "BSD-3-Clause & Python-2.0 & Unicode"
-LIC_FILES_CHKSUM = "file://LICENSE.md;md5=239668a7c6066d9e0c5382e9c8c6c0e1"
-
-SRC_URI[sha256sum] = "9d643ff0a55b762d5cdb124b8eaa99c66322e2157b69160bc32796e824360e6d"
-
-inherit pypi setuptools3
-
-# Remove bundled egg-info
-do_compile:prepend() {
-    rm -rf ${S}/idna.egg-info
-}
-
-RDEPENDS:${PN}:class-target = "\
-    ${PYTHON_PN}-codecs \
-"
-
-BBCLASSEXTEND = "native nativesdk"