| Message ID | 20260401071852.406134-1-asusmith@qti.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-networking] networkmanager: enable modemmanager for 'phone' devices | expand |
On Wed, Apr 1, 2026 at 11:53 AM Akula Susmitha via lists.openembedded.org <asusmith=qti.qualcomm.com@lists.openembedded.org> wrote: > > Enable ModemManager in NetworkManager when the 'phone' > MACHINE_FEATURE is enabled. > > Signed-off-by: Akula Susmitha <asusmith@qti.qualcomm.com> > --- > .../recipes-connectivity/networkmanager/networkmanager_1.56.0.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb > index de163fe00e..31d9f1d2b0 100644 > --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb > +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb > @@ -91,6 +91,7 @@ PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ > ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit ppp', d)} \ > ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', '', d)} \ > ${@bb.utils.contains('DISTRO_FEATURES_BACKFILL_CONSIDERED', 'gobject-introspection-data', '', 'vala', d)} \ > + ${@bb.utils.contains('MACHINE_FEATURES', 'phone', ' modemmanager ', '', d)} \ > " I think it's not that simple. What if there are 2 MACHINEs having the same TUNE_PKGARCH and only one of them has phone in MACHINE_FEATURES? It will cause this recipe (and everything which might (r)depend on it) effectively MACHINE_ARCH without PACKAGE_ARCH being set like that. I guess this would be the first case of using 'phone' as MACHINE_FEATURES, would be nice to document it somewhere and figure out how to support different features effectively (without making everything MACHINE_ARCH). Regards,
diff --git a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb index de163fe00e..31d9f1d2b0 100644 --- a/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb +++ b/meta-networking/recipes-connectivity/networkmanager/networkmanager_1.56.0.bb @@ -91,6 +91,7 @@ PACKAGECONFIG ??= "readline nss ifupdown dnsmasq nmcli \ ${@bb.utils.filter('DISTRO_FEATURES', 'wifi polkit ppp', d)} \ ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', 'selinux audit', '', d)} \ ${@bb.utils.contains('DISTRO_FEATURES_BACKFILL_CONSIDERED', 'gobject-introspection-data', '', 'vala', d)} \ + ${@bb.utils.contains('MACHINE_FEATURES', 'phone', ' modemmanager ', '', d)} \ " inherit ${@bb.utils.contains('PACKAGECONFIG', 'vala', 'vala', '', d)}
Enable ModemManager in NetworkManager when the 'phone' MACHINE_FEATURE is enabled. Signed-off-by: Akula Susmitha <asusmith@qti.qualcomm.com> --- .../recipes-connectivity/networkmanager/networkmanager_1.56.0.bb | 1 + 1 file changed, 1 insertion(+)