| Message ID | 20260401061229.2588515-1-khem.raj@oss.qualcomm.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | libtirpc: fix bindresvport build with clang-22/C23 | expand |
Thank you for your submission. Patchtest identified one or more issues with the patch. Please see the log below for more information: --- Testing patch /home/patchtest/share/mboxes/libtirpc-fix-bindresvport-build-with-clang-22-C23.patch FAIL: test commit message presence: Please include a commit message on your patch explaining the change (test_mbox.TestMbox.test_commit_message_presence) PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format) PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence) PASS: test Signed-off-by presence (test_patch.TestPatch.test_signed_off_by_presence) PASS: test Upstream-Status presence (test_patch.TestPatch.test_upstream_status_presence_format) PASS: test author valid (test_mbox.TestMbox.test_author_valid) PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags) PASS: test mbox format (test_mbox.TestMbox.test_mbox_format) PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade) PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format) PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length) PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list) SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint) SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format) SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint) SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head) --- Please address the issues identified and submit a new revision of the patch, or alternatively, reply to this email with an explanation of why the patch should be accepted. If you believe these results are due to an error in patchtest, please submit a bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category under 'Yocto Project Subprojects'). For more information on specific failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank you!
diff --git a/meta/recipes-extended/libtirpc/libtirpc/0001-libtirpc-fix-bindresvport-build-with-clang-22-C23.patch b/meta/recipes-extended/libtirpc/libtirpc/0001-libtirpc-fix-bindresvport-build-with-clang-22-C23.patch new file mode 100644 index 0000000000..4e5844e18e --- /dev/null +++ b/meta/recipes-extended/libtirpc/libtirpc/0001-libtirpc-fix-bindresvport-build-with-clang-22-C23.patch @@ -0,0 +1,32 @@ +From 0ae4371ee63e25a48777a83c0601c85c5747cbac Mon Sep 17 00:00:00 2001 +From: Khem Raj <khem.raj@oss.qualcomm.com> +Date: Tue, 31 Mar 2026 23:07:09 -0700 +Subject: [PATCH] libtirpc: fix bindresvport build with clang-22/C23 + +bindresvport() is defined using old K&R-style syntax, which breaks when +building libtirpc with clang-22 in gnu23 mode. + +Convert it to a prototype-style definition. This is a no-op change +intended only to restore compatibility with modern C compilers. + +Upstream-Status: Submitted [https://lore.kernel.org/linux-nfs/20260401060943.2578248-1-khem.raj@oss.qualcomm.com/T/#u] +Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com> +--- + src/bindresvport.c | 4 +--- + 1 file changed, 1 insertion(+), 3 deletions(-) + +diff --git a/src/bindresvport.c b/src/bindresvport.c +index 7b2056d..eea6589 100644 +--- a/src/bindresvport.c ++++ b/src/bindresvport.c +@@ -57,9 +57,7 @@ extern pthread_mutex_t port_lock; + * Bind a socket to a privileged IP port + */ + int +-bindresvport(sd, sin) +- int sd; +- struct sockaddr_in *sin; ++bindresvport(int sd, struct sockaddr_in *sin) + { + return bindresvport_sa(sd, (struct sockaddr *)sin); + } diff --git a/meta/recipes-extended/libtirpc/libtirpc_1.3.7.bb b/meta/recipes-extended/libtirpc/libtirpc_1.3.7.bb index edc75a8366..cef541e3d0 100644 --- a/meta/recipes-extended/libtirpc/libtirpc_1.3.7.bb +++ b/meta/recipes-extended/libtirpc/libtirpc_1.3.7.bb @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=f835cce8852481e4b2bbbdd23b5e47f3 \ PROVIDES = "virtual/librpc" SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.bz2 \ + file://0001-libtirpc-fix-bindresvport-build-with-clang-22-C23.patch \ " UPSTREAM_CHECK_URI = "https://sourceforge.net/projects/libtirpc/files/libtirpc/" UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)/"
Signed-off-by: Khem Raj <khem.raj@oss.qualcomm.com> --- ...bindresvport-build-with-clang-22-C23.patch | 32 +++++++++++++++++++ .../libtirpc/libtirpc_1.3.7.bb | 1 + 2 files changed, 33 insertions(+) create mode 100644 meta/recipes-extended/libtirpc/libtirpc/0001-libtirpc-fix-bindresvport-build-with-clang-22-C23.patch