| Message ID | 20260317-fix-invalid-appends-v2-3-5c65ae5787d9@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Confusing and invalid conditional appends | expand |
On Mon, Mar 16, 2026 at 5:03 PM Michal Sieron via lists.openembedded.org <michalwsieron=gmail.com@lists.openembedded.org> wrote: > While in this case `EXTRA_OECMAKE:class-native +=` wouldn't result in > any unwanted override, there is no guarantee there won't be a change, > which would be hidden by this override. To avoid any surprises in the > future let's use `:append:class-native =` syntax here. > > Signed-off-by: Michal Sieron <michalwsieron@gmail.com> > --- > meta/recipes-core/expat/expat_2.7.4.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-core/expat/expat_2.7.4.bb > b/meta/recipes-core/expat/expat_2.7.4.bb > index 95a1ed52c4..b3a9d8aa2d 100644 > --- a/meta/recipes-core/expat/expat_2.7.4.bb > +++ b/meta/recipes-core/expat/expat_2.7.4.bb > @@ -17,7 +17,7 @@ UPSTREAM_CHECK_REGEX = "releases/tag/R_(?P<pver>.+)" > > SRC_URI[sha256sum] = > "e6af11b01e32e5ef64906a5cca8809eabc4beb7ff2f9a0e6aabbd42e825135d0" > > -EXTRA_OECMAKE:class-native += "-DEXPAT_BUILD_DOCS=OFF" > +EXTRA_OECMAKE:append:class-native = " -DEXPAT_BUILD_DOCS=OFF" > This is the only EXTRA_OECMAKE setting in recipe. Perhaps just drop += here. > > RDEPENDS:${PN}-ptest += "bash" > > > -- > 2.53.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#233276): > https://lists.openembedded.org/g/openembedded-core/message/233276 > Mute This Topic: https://lists.openembedded.org/mt/118356435/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta/recipes-core/expat/expat_2.7.4.bb b/meta/recipes-core/expat/expat_2.7.4.bb index 95a1ed52c4..b3a9d8aa2d 100644 --- a/meta/recipes-core/expat/expat_2.7.4.bb +++ b/meta/recipes-core/expat/expat_2.7.4.bb @@ -17,7 +17,7 @@ UPSTREAM_CHECK_REGEX = "releases/tag/R_(?P<pver>.+)" SRC_URI[sha256sum] = "e6af11b01e32e5ef64906a5cca8809eabc4beb7ff2f9a0e6aabbd42e825135d0" -EXTRA_OECMAKE:class-native += "-DEXPAT_BUILD_DOCS=OFF" +EXTRA_OECMAKE:append:class-native = " -DEXPAT_BUILD_DOCS=OFF" RDEPENDS:${PN}-ptest += "bash"
While in this case `EXTRA_OECMAKE:class-native +=` wouldn't result in any unwanted override, there is no guarantee there won't be a change, which would be hidden by this override. To avoid any surprises in the future let's use `:append:class-native =` syntax here. Signed-off-by: Michal Sieron <michalwsieron@gmail.com> --- meta/recipes-core/expat/expat_2.7.4.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)