| Message ID | 20260317-fix-invalid-appends-v2-1-5c65ae5787d9@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | Confusing and invalid conditional appends | expand |
On Mon, Mar 16, 2026 at 5:03 PM Michal Sieron via lists.openembedded.org <michalwsieron=gmail.com@lists.openembedded.org> wrote: > `EXTRA_OECONF:class-native +=` was actually overriding previously set > `EXTRA_OECONF`. > > Signed-off-by: Michal Sieron <michalwsieron@gmail.com> > --- > meta/recipes-support/libffi/libffi_3.5.2.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/recipes-support/libffi/libffi_3.5.2.bb > b/meta/recipes-support/libffi/libffi_3.5.2.bb > index f648a33a46..2b2a368151 100644 > --- a/meta/recipes-support/libffi/libffi_3.5.2.bb > +++ b/meta/recipes-support/libffi/libffi_3.5.2.bb > @@ -16,7 +16,7 @@ SRC_URI = > "${GITHUB_BASE_URI}/download/v${PV}/${BPN}-${PV}.tar.gz \ > SRC_URI[sha256sum] = > "f3a3082a23b37c293a4fcd1053147b371f2ff91fa7ea1b2a52e335676bac82dc" > > EXTRA_OECONF += "--disable-builddir --disable-exec-static-tramp" > -EXTRA_OECONF:class-native += "--with-gcc-arch=generic" > +EXTRA_OECONF:append:class-native = " --with-gcc-arch=generic" > Usually we want to use default options for native builds and accidentally this was being done when you fix it, I think it is better to assess that and see if it should be appended or it should be overridden, In this case override seems more appropriate, making it EXTRA_OECONF:class-native = "--with-gcc-arch=generic" might be closer to intention. EXTRA_OEMAKE:class-target = "LIBTOOLFLAGS='--tag=CC'" > > inherit autotools texinfo multilib_header github-releases > > -- > 2.53.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#233274): > https://lists.openembedded.org/g/openembedded-core/message/233274 > Mute This Topic: https://lists.openembedded.org/mt/118356433/1997914 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta/recipes-support/libffi/libffi_3.5.2.bb b/meta/recipes-support/libffi/libffi_3.5.2.bb index f648a33a46..2b2a368151 100644 --- a/meta/recipes-support/libffi/libffi_3.5.2.bb +++ b/meta/recipes-support/libffi/libffi_3.5.2.bb @@ -16,7 +16,7 @@ SRC_URI = "${GITHUB_BASE_URI}/download/v${PV}/${BPN}-${PV}.tar.gz \ SRC_URI[sha256sum] = "f3a3082a23b37c293a4fcd1053147b371f2ff91fa7ea1b2a52e335676bac82dc" EXTRA_OECONF += "--disable-builddir --disable-exec-static-tramp" -EXTRA_OECONF:class-native += "--with-gcc-arch=generic" +EXTRA_OECONF:append:class-native = " --with-gcc-arch=generic" EXTRA_OEMAKE:class-target = "LIBTOOLFLAGS='--tag=CC'" inherit autotools texinfo multilib_header github-releases
`EXTRA_OECONF:class-native +=` was actually overriding previously set `EXTRA_OECONF`. Signed-off-by: Michal Sieron <michalwsieron@gmail.com> --- meta/recipes-support/libffi/libffi_3.5.2.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)