| Message ID | 20260212182929.8047-1-eric.meyers@arthrex.com |
|---|---|
| State | Under Review |
| Headers | show |
| Series | [meta-oe,v2] redis: Remove debug paths to avoid TMPDIR [buildpaths] errors | expand |
On 2/12/26 19:29, Eric Meyers via lists.openembedded.org wrote: > Takes similar approach to valkey recipe seen here: > > https://github.com/openembedded/meta-openembedded/commit/1b820b98afd55c881822beb9057162dc67ecb386 > > Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> > --- > meta-oe/recipes-extended/redis/redis_7.2.12.bb | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/meta-oe/recipes-extended/redis/redis_7.2.12.bb b/meta-oe/recipes-extended/redis/redis_7.2.12.bb > index 8abf758930..589ffd6fb2 100644 > --- a/meta-oe/recipes-extended/redis/redis_7.2.12.bb > +++ b/meta-oe/recipes-extended/redis/redis_7.2.12.bb > @@ -52,6 +52,11 @@ do_compile:prepend() { > } > > do_install() { > + # Remove debug paths to avoid TMPDIR [buildpaths] errors > + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-benchmark > + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-server > + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-cli > + If I check the file type of these files, I get this: https://gist.githubusercontent.com/OldManYellsAtCloud/5892bde7408475a93d2faa699ae65aea/raw/3309eb40e0467bd7e2a2bcbd540c822b071242d4/gistfile1.txt These are binary files, cutting out parts with sed will break them most probably. I think this will need another solution (will take a look at valkey also, if it has the same) > export PREFIX=${D}/${prefix} > oe_runmake install > install -d ${D}/${sysconfdir}/redis > @@ -71,6 +76,8 @@ do_install() { > fi > } > > +INSANE_SKIP:${PN} += "already-stripped" > + > CONFFILES:${PN} = "${sysconfdir}/redis/redis.conf" > > INITSCRIPT_NAME = "redis-server" > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#124360): https://lists.openembedded.org/g/openembedded-devel/message/124360 > Mute This Topic: https://lists.openembedded.org/mt/117779563/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On 2/12/26 22:09, Gyorgy Sarvari via lists.openembedded.org wrote: > On 2/12/26 19:29, Eric Meyers via lists.openembedded.org wrote: >> Takes similar approach to valkey recipe seen here: >> >> https://github.com/openembedded/meta-openembedded/commit/1b820b98afd55c881822beb9057162dc67ecb386 >> >> Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> >> --- >> meta-oe/recipes-extended/redis/redis_7.2.12.bb | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/meta-oe/recipes-extended/redis/redis_7.2.12.bb b/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> index 8abf758930..589ffd6fb2 100644 >> --- a/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> +++ b/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> @@ -52,6 +52,11 @@ do_compile:prepend() { >> } >> >> do_install() { >> + # Remove debug paths to avoid TMPDIR [buildpaths] errors >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-benchmark >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-server >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-cli >> + > If I check the file type of these files, I get this: > https://gist.githubusercontent.com/OldManYellsAtCloud/5892bde7408475a93d2faa699ae65aea/raw/3309eb40e0467bd7e2a2bcbd540c822b071242d4/gistfile1.txt > > These are binary files, cutting out parts with sed will break them most > probably. I think this will need another solution (will take a look at > valkey also, if it has the same) > I have sent an alternative proposal[1] - do you think you could test it if works for you also? [1]: https://lists.openembedded.org/g/openembedded-devel/message/124363 > >> export PREFIX=${D}/${prefix} >> oe_runmake install >> install -d ${D}/${sysconfdir}/redis >> @@ -71,6 +76,8 @@ do_install() { >> fi >> } >> >> +INSANE_SKIP:${PN} += "already-stripped" >> + >> CONFFILES:${PN} = "${sysconfdir}/redis/redis.conf" >> >> INITSCRIPT_NAME = "redis-server" >> >> >> > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#124361): https://lists.openembedded.org/g/openembedded-devel/message/124361 > Mute This Topic: https://lists.openembedded.org/mt/117779563/6084445 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Thu, Feb 12, 2026 at 2:39 PM Gyorgy Sarvari via lists.openembedded.org <skandigraun=gmail.com@lists.openembedded.org> wrote: > On 2/12/26 22:09, Gyorgy Sarvari via lists.openembedded.org wrote: > > On 2/12/26 19:29, Eric Meyers via lists.openembedded.org wrote: > >> Takes similar approach to valkey recipe seen here: > >> > >> > https://github.com/openembedded/meta-openembedded/commit/1b820b98afd55c881822beb9057162dc67ecb386 > >> > >> Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> > >> --- > >> meta-oe/recipes-extended/redis/redis_7.2.12.bb | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/meta-oe/recipes-extended/redis/redis_7.2.12.bb > b/meta-oe/recipes-extended/redis/redis_7.2.12.bb > >> index 8abf758930..589ffd6fb2 100644 > >> --- a/meta-oe/recipes-extended/redis/redis_7.2.12.bb > >> +++ b/meta-oe/recipes-extended/redis/redis_7.2.12.bb > >> @@ -52,6 +52,11 @@ do_compile:prepend() { > >> } > >> > >> do_install() { > >> + # Remove debug paths to avoid TMPDIR [buildpaths] errors > >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-benchmark > >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-server > >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-cli > >> + > > If I check the file type of these files, I get this: > > > https://gist.githubusercontent.com/OldManYellsAtCloud/5892bde7408475a93d2faa699ae65aea/raw/3309eb40e0467bd7e2a2bcbd540c822b071242d4/gistfile1.txt > > > > These are binary files, cutting out parts with sed will break them most > > probably. I think this will need another solution (will take a look at > > valkey also, if it has the same) > > > > I have sent an alternative proposal[1] - do you think you could test it > if works for you also? > > [1]: https://lists.openembedded.org/g/openembedded-devel/message/124363 > > yeah I think this would ensure that LDFLAGS behaviour prior to OE-core change so I would take the patch proposed in [1] > > > >> export PREFIX=${D}/${prefix} > >> oe_runmake install > >> install -d ${D}/${sysconfdir}/redis > >> @@ -71,6 +76,8 @@ do_install() { > >> fi > >> } > >> > >> +INSANE_SKIP:${PN} += "already-stripped" > >> + > >> CONFFILES:${PN} = "${sysconfdir}/redis/redis.conf" > >> > >> INITSCRIPT_NAME = "redis-server" > >> > >> > >> > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#124364): > https://lists.openembedded.org/g/openembedded-devel/message/124364 > Mute This Topic: https://lists.openembedded.org/mt/117779563/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
On Thu, Feb 12, 2026 at 8:46 PM Khem Raj <raj.khem@gmail.com> wrote: > > > On Thu, Feb 12, 2026 at 2:39 PM Gyorgy Sarvari via lists.openembedded.org > <skandigraun=gmail.com@lists.openembedded.org> wrote: > >> On 2/12/26 22:09, Gyorgy Sarvari via lists.openembedded.org wrote: >> > On 2/12/26 19:29, Eric Meyers via lists.openembedded.org wrote: >> >> Takes similar approach to valkey recipe seen here: >> >> >> >> >> https://github.com/openembedded/meta-openembedded/commit/1b820b98afd55c881822beb9057162dc67ecb386 >> >> >> >> Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> >> >> --- >> >> meta-oe/recipes-extended/redis/redis_7.2.12.bb | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> >> >> diff --git a/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> b/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> >> index 8abf758930..589ffd6fb2 100644 >> >> --- a/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> >> +++ b/meta-oe/recipes-extended/redis/redis_7.2.12.bb >> >> @@ -52,6 +52,11 @@ do_compile:prepend() { >> >> } >> >> >> >> do_install() { >> >> + # Remove debug paths to avoid TMPDIR [buildpaths] errors >> >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-benchmark >> >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-server >> >> + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-cli >> >> + >> > If I check the file type of these files, I get this: >> > >> https://gist.githubusercontent.com/OldManYellsAtCloud/5892bde7408475a93d2faa699ae65aea/raw/3309eb40e0467bd7e2a2bcbd540c822b071242d4/gistfile1.txt >> > >> > These are binary files, cutting out parts with sed will break them most >> > probably. I think this will need another solution (will take a look at >> > valkey also, if it has the same) >> > >> >> I have sent an alternative proposal[1] - do you think you could test it >> if works for you also? >> >> [1]: https://lists.openembedded.org/g/openembedded-devel/message/124363 >> >> > yeah I think this would ensure that LDFLAGS behaviour prior to OE-core > change so I would > take the patch proposed in [1] > > >> > >> >> export PREFIX=${D}/${prefix} >> >> oe_runmake install >> >> install -d ${D}/${sysconfdir}/redis >> >> @@ -71,6 +76,8 @@ do_install() { >> >> fi >> >> } >> >> >> >> +INSANE_SKIP:${PN} += "already-stripped" >> >> + >> >> CONFFILES:${PN} = "${sysconfdir}/redis/redis.conf" >> >> >> >> INITSCRIPT_NAME = "redis-server" >> >> >> >> >> >> >> > >> > >> > >> >> >> -=-=-=-=-=-=-=-=-=-=-=- >> Links: You receive all messages sent to this group. >> View/Reply Online (#124364): >> https://lists.openembedded.org/g/openembedded-devel/message/124364 >> Mute This Topic: https://lists.openembedded.org/mt/117779563/1997914 >> Group Owner: openembedded-devel+owner@lists.openembedded.org >> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ >> raj.khem@gmail.com] >> -=-=-=-=-=-=-=-=-=-=-=- >> >> I'm okay with using patch [1]. Things seem to be building on my end after pruning sstate/cleaning.
diff --git a/meta-oe/recipes-extended/redis/redis_7.2.12.bb b/meta-oe/recipes-extended/redis/redis_7.2.12.bb index 8abf758930..589ffd6fb2 100644 --- a/meta-oe/recipes-extended/redis/redis_7.2.12.bb +++ b/meta-oe/recipes-extended/redis/redis_7.2.12.bb @@ -52,6 +52,11 @@ do_compile:prepend() { } do_install() { + # Remove debug paths to avoid TMPDIR [buildpaths] errors + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-benchmark + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-server + sed -i -e 's#${TMPDIR}##g' ${S}/src/redis-cli + export PREFIX=${D}/${prefix} oe_runmake install install -d ${D}/${sysconfdir}/redis @@ -71,6 +76,8 @@ do_install() { fi } +INSANE_SKIP:${PN} += "already-stripped" + CONFFILES:${PN} = "${sysconfdir}/redis/redis.conf" INITSCRIPT_NAME = "redis-server"
Takes similar approach to valkey recipe seen here: https://github.com/openembedded/meta-openembedded/commit/1b820b98afd55c881822beb9057162dc67ecb386 Signed-off-by: Eric Meyers <eric.meyers@arthrex.com> --- meta-oe/recipes-extended/redis/redis_7.2.12.bb | 7 +++++++ 1 file changed, 7 insertions(+)