diff mbox series

[meta-oe] valkey: Upgrade 9.0.1 -> 9.0.2

Message ID 20260204143603.1103031-1-leon.anavi@konsulko.com
State Accepted
Headers show
Series [meta-oe] valkey: Upgrade 9.0.1 -> 9.0.2 | expand

Commit Message

Leon Anavi Feb. 4, 2026, 2:36 p.m. UTC
Upgrade to release 9.0.2:

- Avoid memory leak of new argv when HEXPIRE commands target only
  non-exiting fields
- Fix HINCRBY and HINCRBYFLOAT to update volatile key tracking
- Avoid empty hash object when HSETEX added no fields
- Fix case-sensitive check for the FNX and FXX arguments in HSETEX
- Prevent assertion in active expiration job after a hash with
  volatile fields is overwritten
- Fix HRANDFIELD to return null response when no field could be
  found
- Fix HEXPIRE to not delete items when validation rules fail and
  expiration is in the past
- Fix how hash is handling overriding of expired fields overwrite
- HSETEX - Always issue keyspace notifications after validation
- Make zero a valid TTL for hash fields during import mode and data
  loading
- Trigger prepareCommand on argc change in module command filters
- Restrict TTL from being negative and avoid crash in import-mode
- Fix chained replica crash when doing dual channel replication
- Skip slot cache optimization for AOF client to prevent key
  duplication and data corruption
- Fix used_memory_dataset underflow due to miscalculated
  used_memory_overhead
- Avoid duplicate calculations of network-bytes-out in slot stats
  with copy-avoidance
- Fix XREAD returning error on empty stream with + ID
- Track reply bytes in I/O threads if commandlog-reply-larger-than
  is -1
- This makes it possible to mitigate a performance regression in
  9.0.1 caused by the related bug fix

Fixes references to TMPDIR [buildpaths] and avoids [already-stripped].

Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
---
 .../valkey/{valkey_9.0.1.bb => valkey_9.0.2.bb}        | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
 rename meta-oe/recipes-extended/valkey/{valkey_9.0.1.bb => valkey_9.0.2.bb} (87%)

Comments

Anuj Mittal Feb. 5, 2026, 7:32 a.m. UTC | #1
On Wed, Feb 4, 2026 at 10:36 PM Leon Anavi via lists.openembedded.org
<leon.anavi=konsulko.com@lists.openembedded.org> wrote:
>
> Upgrade to release 9.0.2:
>
> - Avoid memory leak of new argv when HEXPIRE commands target only
>   non-exiting fields
> - Fix HINCRBY and HINCRBYFLOAT to update volatile key tracking
> - Avoid empty hash object when HSETEX added no fields
> - Fix case-sensitive check for the FNX and FXX arguments in HSETEX
> - Prevent assertion in active expiration job after a hash with
>   volatile fields is overwritten
> - Fix HRANDFIELD to return null response when no field could be
>   found
> - Fix HEXPIRE to not delete items when validation rules fail and
>   expiration is in the past
> - Fix how hash is handling overriding of expired fields overwrite
> - HSETEX - Always issue keyspace notifications after validation
> - Make zero a valid TTL for hash fields during import mode and data
>   loading
> - Trigger prepareCommand on argc change in module command filters
> - Restrict TTL from being negative and avoid crash in import-mode
> - Fix chained replica crash when doing dual channel replication
> - Skip slot cache optimization for AOF client to prevent key
>   duplication and data corruption
> - Fix used_memory_dataset underflow due to miscalculated
>   used_memory_overhead
> - Avoid duplicate calculations of network-bytes-out in slot stats
>   with copy-avoidance
> - Fix XREAD returning error on empty stream with + ID
> - Track reply bytes in I/O threads if commandlog-reply-larger-than
>   is -1
> - This makes it possible to mitigate a performance regression in
>   9.0.1 caused by the related bug fix
>
> Fixes references to TMPDIR [buildpaths] and avoids [already-stripped].
>
> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
> ---
>  .../valkey/{valkey_9.0.1.bb => valkey_9.0.2.bb}        | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>  rename meta-oe/recipes-extended/valkey/{valkey_9.0.1.bb => valkey_9.0.2.bb} (87%)
>
> diff --git a/meta-oe/recipes-extended/valkey/valkey_9.0.1.bb b/meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
> similarity index 87%
> rename from meta-oe/recipes-extended/valkey/valkey_9.0.1.bb
> rename to meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
> index 1f27224772..3334f57599 100644
> --- a/meta-oe/recipes-extended/valkey/valkey_9.0.1.bb
> +++ b/meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
> @@ -15,7 +15,7 @@ SRC_URI = "git://github.com/valkey-io/valkey.git;branch=9.0;protocol=https;tag=$
>             file://0001-src-Do-not-reset-FINAL_LIBS.patch \
>             file://GNU_SOURCE-7.patch \
>             "
> -SRCREV = "ab3c953b80289d88991095f53c1235fc2f8b44d6"
> +SRCREV = "1ac4cfe4c877a6cb8cb2e28fa7094055ac06f64b"
>
>  RPROVIDES:${PN} = "virtual-redis"
>
> @@ -44,6 +44,11 @@ do_compile() {
>  }
>
>  do_install() {
> +    # Remove debug paths to avoid TMPDIR [buildpaths] errors
> +    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-benchmark
> +    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-server
> +    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-cli
> +

I think these should be using ${S} instead or the files in ${D} should
be changed after install.

>      export PREFIX=${D}/${prefix}
>      oe_runmake install
>      install -d ${D}/${sysconfdir}/valkey
> @@ -63,6 +68,7 @@ do_install() {
>      fi
>  }
>
> +
>  CONFFILES:${PN} = "${sysconfdir}/valkey/valkey.conf"
>
>  INITSCRIPT_NAME = "valkey-server"
> @@ -71,3 +77,5 @@ INITSCRIPT_PARAMS = "defaults 87"
>  SYSTEMD_SERVICE:${PN} = "valkey.service"
>
>  CVE_STATUS[CVE-2022-3734] = "not-applicable-platform: CVE only applies for Windows."
> +
> +INSANE_SKIP:${PN} = "already-stripped"
> --
> 2.47.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#124129): https://lists.openembedded.org/g/openembedded-devel/message/124129
> Mute This Topic: https://lists.openembedded.org/mt/117634817/3616702
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [anuj.mittal@oss.qualcomm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Leon Anavi Feb. 5, 2026, 9:24 a.m. UTC | #2
Hi Anuj,

On 2/5/26 09:32, Anuj Mittal wrote:
> On Wed, Feb 4, 2026 at 10:36 PM Leon Anavi via lists.openembedded.org
> <leon.anavi=konsulko.com@lists.openembedded.org> wrote:
>> Upgrade to release 9.0.2:
>>
>> - Avoid memory leak of new argv when HEXPIRE commands target only
>>    non-exiting fields
>> - Fix HINCRBY and HINCRBYFLOAT to update volatile key tracking
>> - Avoid empty hash object when HSETEX added no fields
>> - Fix case-sensitive check for the FNX and FXX arguments in HSETEX
>> - Prevent assertion in active expiration job after a hash with
>>    volatile fields is overwritten
>> - Fix HRANDFIELD to return null response when no field could be
>>    found
>> - Fix HEXPIRE to not delete items when validation rules fail and
>>    expiration is in the past
>> - Fix how hash is handling overriding of expired fields overwrite
>> - HSETEX - Always issue keyspace notifications after validation
>> - Make zero a valid TTL for hash fields during import mode and data
>>    loading
>> - Trigger prepareCommand on argc change in module command filters
>> - Restrict TTL from being negative and avoid crash in import-mode
>> - Fix chained replica crash when doing dual channel replication
>> - Skip slot cache optimization for AOF client to prevent key
>>    duplication and data corruption
>> - Fix used_memory_dataset underflow due to miscalculated
>>    used_memory_overhead
>> - Avoid duplicate calculations of network-bytes-out in slot stats
>>    with copy-avoidance
>> - Fix XREAD returning error on empty stream with + ID
>> - Track reply bytes in I/O threads if commandlog-reply-larger-than
>>    is -1
>> - This makes it possible to mitigate a performance regression in
>>    9.0.1 caused by the related bug fix
>>
>> Fixes references to TMPDIR [buildpaths] and avoids [already-stripped].
>>
>> Signed-off-by: Leon Anavi <leon.anavi@konsulko.com>
>> ---
>>   .../valkey/{valkey_9.0.1.bb => valkey_9.0.2.bb}        | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>   rename meta-oe/recipes-extended/valkey/{valkey_9.0.1.bb => valkey_9.0.2.bb} (87%)
>>
>> diff --git a/meta-oe/recipes-extended/valkey/valkey_9.0.1.bb b/meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
>> similarity index 87%
>> rename from meta-oe/recipes-extended/valkey/valkey_9.0.1.bb
>> rename to meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
>> index 1f27224772..3334f57599 100644
>> --- a/meta-oe/recipes-extended/valkey/valkey_9.0.1.bb
>> +++ b/meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
>> @@ -15,7 +15,7 @@ SRC_URI = "git://github.com/valkey-io/valkey.git;branch=9.0;protocol=https;tag=$
>>              file://0001-src-Do-not-reset-FINAL_LIBS.patch \
>>              file://GNU_SOURCE-7.patch \
>>              "
>> -SRCREV = "ab3c953b80289d88991095f53c1235fc2f8b44d6"
>> +SRCREV = "1ac4cfe4c877a6cb8cb2e28fa7094055ac06f64b"
>>
>>   RPROVIDES:${PN} = "virtual-redis"
>>
>> @@ -44,6 +44,11 @@ do_compile() {
>>   }
>>
>>   do_install() {
>> +    # Remove debug paths to avoid TMPDIR [buildpaths] errors
>> +    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-benchmark
>> +    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-server
>> +    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-cli
>> +
> I think these should be using ${S} instead or the files in ${D} should
> be changed after install.


Yes, you are right. Thanks! Let's keep it simple: I've just sent v2 of 
the patch that uses ${S}.

Best regards, Leon


>
>>       export PREFIX=${D}/${prefix}
>>       oe_runmake install
>>       install -d ${D}/${sysconfdir}/valkey
>> @@ -63,6 +68,7 @@ do_install() {
>>       fi
>>   }
>>
>> +
>>   CONFFILES:${PN} = "${sysconfdir}/valkey/valkey.conf"
>>
>>   INITSCRIPT_NAME = "valkey-server"
>> @@ -71,3 +77,5 @@ INITSCRIPT_PARAMS = "defaults 87"
>>   SYSTEMD_SERVICE:${PN} = "valkey.service"
>>
>>   CVE_STATUS[CVE-2022-3734] = "not-applicable-platform: CVE only applies for Windows."
>> +
>> +INSANE_SKIP:${PN} = "already-stripped"
>> --
>> 2.47.3
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#124129): https://lists.openembedded.org/g/openembedded-devel/message/124129
>> Mute This Topic: https://lists.openembedded.org/mt/117634817/3616702
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [anuj.mittal@oss.qualcomm.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta-oe/recipes-extended/valkey/valkey_9.0.1.bb b/meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
similarity index 87%
rename from meta-oe/recipes-extended/valkey/valkey_9.0.1.bb
rename to meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
index 1f27224772..3334f57599 100644
--- a/meta-oe/recipes-extended/valkey/valkey_9.0.1.bb
+++ b/meta-oe/recipes-extended/valkey/valkey_9.0.2.bb
@@ -15,7 +15,7 @@  SRC_URI = "git://github.com/valkey-io/valkey.git;branch=9.0;protocol=https;tag=$
            file://0001-src-Do-not-reset-FINAL_LIBS.patch \
            file://GNU_SOURCE-7.patch \
            "
-SRCREV = "ab3c953b80289d88991095f53c1235fc2f8b44d6"
+SRCREV = "1ac4cfe4c877a6cb8cb2e28fa7094055ac06f64b"
 
 RPROVIDES:${PN} = "virtual-redis"
 
@@ -44,6 +44,11 @@  do_compile() {
 }
 
 do_install() {
+    # Remove debug paths to avoid TMPDIR [buildpaths] errors
+    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-benchmark
+    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-server
+    sed -i -e 's#${TMPDIR}##g' ${UNPACKDIR}/${PN}-${PV}/src/valkey-cli
+
     export PREFIX=${D}/${prefix}
     oe_runmake install
     install -d ${D}/${sysconfdir}/valkey
@@ -63,6 +68,7 @@  do_install() {
     fi
 }
 
+
 CONFFILES:${PN} = "${sysconfdir}/valkey/valkey.conf"
 
 INITSCRIPT_NAME = "valkey-server"
@@ -71,3 +77,5 @@  INITSCRIPT_PARAMS = "defaults 87"
 SYSTEMD_SERVICE:${PN} = "valkey.service"
 
 CVE_STATUS[CVE-2022-3734] = "not-applicable-platform: CVE only applies for Windows."
+
+INSANE_SKIP:${PN} = "already-stripped"