diff mbox series

alsa-utils: fix packaging of alsabat

Message ID 20260126093655.2552127-1-max.oss.09@gmail.com
State Under Review
Headers show
Series alsa-utils: fix packaging of alsabat | expand

Commit Message

Max Krummenacher Jan. 26, 2026, 9:36 a.m. UTC
From: Max Krummenacher <max.krummenacher@toradex.com>

If bat is in PACKAGECONFIG two additional binaries are created which
by the dynamic package split creates two additional packages.
However due to explicitely adding the file alsabat-test.sh to the
alsabat package the alsa-utils-alsabat-test package now is empty
and not created.

Complete commit 4c6d5f96990d ("alsa-utils: fix packaging") which fixed
the same issue for all other affected packages.

Fixes: 26a28ee79350 ("alsa-utils: dynamically split the packages instead of doing it manually")
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
 meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Max Krummenacher Feb. 4, 2026, 9:50 a.m. UTC | #1
Hi all

Gentle ping.

The alsa-utils package is currently broken if one sets `bat` in PACKAGECONFIG.

Regards,
Max

On Mon, Jan 26, 2026 at 10:38 AM <max.oss.09@gmail.com> wrote:
>
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> If bat is in PACKAGECONFIG two additional binaries are created which
> by the dynamic package split creates two additional packages.
> However due to explicitely adding the file alsabat-test.sh to the
> alsabat package the alsa-utils-alsabat-test package now is empty
> and not created.
>
> Complete commit 4c6d5f96990d ("alsa-utils: fix packaging") which fixed
> the same issue for all other affected packages.
>
> Fixes: 26a28ee79350 ("alsa-utils: dynamically split the packages instead of doing it manually")
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
> ---
>  meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb
> index 6d75bff09e5c..b792302c9fae 100644
> --- a/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb
> +++ b/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb
> @@ -12,7 +12,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
>  DEPENDS = "alsa-lib ncurses libsamplerate0 bash"
>
>  # Only needed as the dynamic packaging was altered, remove on upgrade
> -PR = "r1"
> +PR = "r2"
>
>  # alsa-utils specified in SRC_URI due to alsa-utils-scripts recipe
>  SRC_URI = "https://www.alsa-project.org/files/pub/utils/alsa-utils-${PV}.tar.bz2"
> @@ -63,6 +63,7 @@ SUMMARY:${PN}-speaker-test   = "ALSA surround speaker test utility"
>
>  RRECOMMENDS:${PN}-alsactl = "alsa-states"
>
> +RPROVIDES:${PN}-alsabat += "${PN}-alsabat-test"
>  RPROVIDES:${PN}-aplay += "${PN}-arecord"
>  RPROVIDES:${PN}-amidi += "${PN}-aplaymidi ${PN}-aplaymidi2 ${PN}-arecordmidi ${PN}-arecordmidi2"
>
> --
> 2.42.0
>
Mathieu Dubois-Briand Feb. 4, 2026, 3:10 p.m. UTC | #2
On Wed Feb 4, 2026 at 10:50 AM CET, Max Krummenacher via lists.openembedded.org wrote:
> Hi all
>
> Gentle ping.
>

Sorry, I'm pretty sure I confused your patch with another alsa-utils one
at some point, and so dropped it by error.

It will be back in my branch soon.

Thanks,
Mathieu
diff mbox series

Patch

diff --git a/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb b/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb
index 6d75bff09e5c..b792302c9fae 100644
--- a/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb
+++ b/meta/recipes-multimedia/alsa/alsa-utils_1.2.15.2.bb
@@ -12,7 +12,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
 DEPENDS = "alsa-lib ncurses libsamplerate0 bash"
 
 # Only needed as the dynamic packaging was altered, remove on upgrade
-PR = "r1"
+PR = "r2"
 
 # alsa-utils specified in SRC_URI due to alsa-utils-scripts recipe
 SRC_URI = "https://www.alsa-project.org/files/pub/utils/alsa-utils-${PV}.tar.bz2"
@@ -63,6 +63,7 @@  SUMMARY:${PN}-speaker-test   = "ALSA surround speaker test utility"
 
 RRECOMMENDS:${PN}-alsactl = "alsa-states"
 
+RPROVIDES:${PN}-alsabat += "${PN}-alsabat-test"
 RPROVIDES:${PN}-aplay += "${PN}-arecord"
 RPROVIDES:${PN}-amidi += "${PN}-aplaymidi ${PN}-aplaymidi2 ${PN}-arecordmidi ${PN}-arecordmidi2"