diff mbox series

[meta-oe,3/3] freerdp3: upgrade 3.20.2 -> 3.22.0

Message ID 20260202135045.1476359-3-skandigraun@gmail.com
State New
Headers show
Series [meta-networking,1/3] ez-ipupdate: patch CVE-2003-0887 | expand

Commit Message

Gyorgy Sarvari Feb. 2, 2026, 1:50 p.m. UTC
Ptests passed successfully.

Dropped manpages PACKAGECONFIG: when it is enabled, it requires an executable that
is compiled from the project's source, but since it is cross-compiled, it is not
usable. The cmakefile also started to explicitly disable generating this tool
when cross-compiling is enabled.
Since this recipe has no native counterpart, and the manpages can't be generated
in this state, this option was removed.

Changes:
3.22.0:
- Complete overhaul of SDL client
- Introduction of new WINPR_ATTR_NODISCARD macro wrapping compiler or C language
  version specific [[nodiscard]] attributes
- Addition of WINPR_ATTR_NODISCARD to (some) public API functions so usage errors
  are producing warnings now
- Add some more stringify functions for logging
- CVE fixes: CVE-2026-23948, CVE-2026-24682, CVE-2026-24683, CVE-2026-24676,
  CVE-2026-24677, CVE-2026-24678, CVE-2026-24684, CVE-2026-24679,
  CVE-2026-24681, CVE-2026-24675, CVE-2026-24491, CVE-2026-24680
- [core,info] fix missing NULL check
- [gateway,tsg] fix TSG_PACKET_RESPONSE parsing
- Allow querying auth identity with kerberos when running as a server
- Sspi krb heimdal
- Tsg fix idleTimeout parsing
- [channels,smartcard] revert 649f7de
- [crypto] deprecate er and der modules
- [channels,rdpei] lock full update, not only parts
- [winpr,platform] add WINPR_ATTR_NODISCARD macro
- Wlog cleanup
- new stringify functions & touch API defines
- Add support for querying SECPKG_ATTR_PACKAGE_INFO to NTLM and Kerberos
- [channels,video] measure times in ns
- [utils] Nodiscard
- Error handling fixes
- [channels,drdynvc] check pointer before reset
- Winpr api def
- [winpr,platform] drop C23 [[nodiscard]]
- [gdi] add additional checks for a valid rdpGdi
- Sdl3 high dpiv2
- peer: Disconnect if Logon() returned FALSE
- [channels,rdpecam] fix PROPERTY_DESCRIPTION parsing
- [channel,rdpsnd] only clean up thread before free
- [channels,rdpei] add RDPINPUT_CONTACT_FLAG_UP

3.21.0:
- CVE fixes: CVE-2026-23530, CVE-2026-23531, CVE-2026-23532, CVE-2026-23533,
  CVE-2026-23534, CVE-2026-23732, CVE-2026-23883, CVE-2026-23884
- [client,sdl] fix monitor resolution
- [codec,progressive] fix progressive_rfx_upgrade_block
- Krb cache fix
- Rdpdr improved checks
- Codec advanced length checks
- Glyph fix length checks
- Wlog printf format string checks
- [warnings,format] fix format string warnings
- Double free fixes
- [clang-tidy] clean up code warnings

Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
---
 .../freerdp/{freerdp3_3.20.2.bb => freerdp3_3.22.0.bb}         | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 rename meta-oe/recipes-support/freerdp/{freerdp3_3.20.2.bb => freerdp3_3.22.0.bb} (97%)

Comments

Markus Volk Feb. 3, 2026, 10:12 p.m. UTC | #1
On Mon, Feb 2 2026 at 14:50:45 +01:00:00, Gyorgy Sarvari via 
lists.openembedded.org <skandigraun=gmail.com@lists.openembedded.org> 
wrote:
> Dropped manpages PACKAGECONFIG: when it is enabled, it requires an 
> executable that
> is compiled from the project's source, but since it is 
> cross-compiled, it is not
> usable.

This fails for me with:

| CMake Error at client/common/man/CMakeLists.txt:27 
(add_custom_target):
|   Error evaluating generator expression:
|
|     $<TARGET_FILE:generate_argument_manpage>
|
|   No target "generate_argument_manpage"
|
|
| CMake Error at client/common/man/CMakeLists.txt:23 
(add_custom_command):
|   Error evaluating generator expression:
|
|     $<TARGET_FILE:generate_argument_manpage>
|
|   No target "generate_argument_manpage"
|
|
| CMake Error at client/common/man/CMakeLists.txt:27 
(add_custom_target):
|   Error evaluating generator expression:
|
|     $<TARGET_FILE:generate_argument_manpage>
|
|   No target "generate_argument_manpage"
|
|
| CMake Error at client/common/man/CMakeLists.txt:23 
(add_custom_command):
|   Error evaluating generator expression:
|
|     $<TARGET_FILE:generate_argument_manpage>
|
|   No target "generate_argument_manpage"
|
|
| CMake Error at client/common/man/CMakeLists.txt:27 
(add_custom_target):
|   Error evaluating generator expression:
|
|     $<TARGET_FILE:generate_argument_manpage>
|
|   No target "generate_argument_manpage"
|
|
| CMake Error at client/common/man/CMakeLists.txt:23 
(add_custom_command):
|   Error evaluating generator expression:
|
|     $<TARGET_FILE:generate_argument_manpage>
|
|   No target "generate_argument_manpage"


Explicitly adding EXTRA_OECMAKE += "-DWITH_MANPAGES=OFF" solves the 
issue
Gyorgy Sarvari Feb. 4, 2026, 3:05 a.m. UTC | #2
On 2/3/26 23:12, Markus Volk wrote:
> On Mon, Feb 2 2026 at 14:50:45 +01:00:00, Gyorgy Sarvari via
> lists.openembedded.org <skandigraun=gmail.com@lists.openembedded.org>
> wrote:
>> Dropped manpages PACKAGECONFIG: when it is enabled, it requires an
>> executable that is compiled from the project's source, but since it
>> is cross-compiled, it is not usable.
>
> This fails for me with:
>
> | CMake Error at client/common/man/CMakeLists.txt:27 (add_custom_target):
> |   Error evaluating generator expression:
> |
> |     $<TARGET_FILE:generate_argument_manpage>
> |
> |   No target "generate_argument_manpage"
> |
> |
> | CMake Error at client/common/man/CMakeLists.txt:23 (add_custom_command):
> |   Error evaluating generator expression:
> |
> |     $<TARGET_FILE:generate_argument_manpage>
> |
> |   No target "generate_argument_manpage"
> |
> |
> | CMake Error at client/common/man/CMakeLists.txt:27 (add_custom_target):
> |   Error evaluating generator expression:
> |
> |     $<TARGET_FILE:generate_argument_manpage>
> |
> |   No target "generate_argument_manpage"
> |
> |
> | CMake Error at client/common/man/CMakeLists.txt:23 (add_custom_command):
> |   Error evaluating generator expression:
> |
> |     $<TARGET_FILE:generate_argument_manpage>
> |
> |   No target "generate_argument_manpage"
> |
> |
> | CMake Error at client/common/man/CMakeLists.txt:27 (add_custom_target):
> |   Error evaluating generator expression:
> |
> |     $<TARGET_FILE:generate_argument_manpage>
> |
> |   No target "generate_argument_manpage"
> |
> |
> | CMake Error at client/common/man/CMakeLists.txt:23 (add_custom_command):
> |   Error evaluating generator expression:
> |
> |     $<TARGET_FILE:generate_argument_manpage>
> |
> |   No target "generate_argument_manpage"
>
>
> Explicitly adding EXTRA_OECMAKE += "-DWITH_MANPAGES=OFF" solves the issue

Huhh, not sure how I managed to mess this up. Thanks a lot for testing!
v2 sent
diff mbox series

Patch

diff --git a/meta-oe/recipes-support/freerdp/freerdp3_3.20.2.bb b/meta-oe/recipes-support/freerdp/freerdp3_3.22.0.bb
similarity index 97%
rename from meta-oe/recipes-support/freerdp/freerdp3_3.20.2.bb
rename to meta-oe/recipes-support/freerdp/freerdp3_3.22.0.bb
index 81f160a848..ce4af4227e 100644
--- a/meta-oe/recipes-support/freerdp/freerdp3_3.20.2.bb
+++ b/meta-oe/recipes-support/freerdp/freerdp3_3.22.0.bb
@@ -8,7 +8,7 @@  RDEPENDS:${PN}-ptest += "cmake coreutils"
 
 inherit pkgconfig cmake ptest
 
-SRCREV = "ef106b0c5adf739085ff4e8f45ef384e5a1c7bb3"
+SRCREV = "e3ef4c71138f76516299cb3637d2d0c59b2a3737"
 SRC_URI = "git://github.com/FreeRDP/FreeRDP.git;branch=master;protocol=https;tag=${PV} \
            file://run-ptest"
 
@@ -49,7 +49,6 @@  PACKAGECONFIG[gstreamer] = "-DWITH_GSTREAMER_1_0=ON,-DWITH_GSTREAMER_1_0=OFF,gst
 PACKAGECONFIG[cups] = "-DWITH_CUPS=ON,-DWITH_CUPS=OFF,cups"
 PACKAGECONFIG[fuse] = "-DWITH_FUSE=ON,-DWITH_FUSE=OFF,fuse3,fuse3"
 PACKAGECONFIG[pcsc] = "-DWITH_PCSC=ON,-DWITH_PCSC=OFF,pcsc-lite"
-PACKAGECONFIG[manpages] = "-DWITH_MANPAGES=ON,-DWITH_MANPAGES=OFF, libxslt-native docbook-xsl-stylesheets-native"
 PACKAGECONFIG[ffmpeg] = "-DWITH_DSP_FFMPEG=ON -DWITH_FFMPEG=ON -DWITH_SWSCALE=ON, -DWITH_DSP_FFMPEG=OFF -DWITH_FFMPEG=OFF -DWITH_SWSCALE=OFF,ffmpeg"
 PACKAGECONFIG[krb5] = "-DWITH_KRB5=ON -DWITH_KRB5_NO_NTLM_FALLBACK=OFF,-DWITH_KRB5=OFF,krb5"
 PACKAGECONFIG[openh264] = "-DWITH_OPENH264=ON,-DWITH_OPENH264=OFF,openh264"