| Message ID | 20260123094603.2835-2-shoudil@qti.qualcomm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [meta-oe] android-tools-conf-configfs: handle multiple UDC controllers | expand |
Hi, On Fri, Jan 23, 2026 at 09:46:04AM +0000, Shoudi Li wrote: In the headers: `From: Shoudi Li <quaresma.jose@gmail.com> ` What is going on? > From: Shoudi Li <shoudil@qti.qualcomm.com> > > For the boards with multiple UDC ports, adb funtion will be impacted due > to below error. > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > ls: write error: Device or resource busy > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> Missing SoB or 'quaresma.jose@gmail.com'.
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> escreveu (sexta, 23/01/2026 à(s) 17:24): > Hi, > > > On Fri, Jan 23, 2026 at 09:46:04AM +0000, Shoudi Li wrote: > In the headers: `From: Shoudi Li <quaresma.jose@gmail.com> ` > > What is going on? The same issue as before. I will send a v2 > > > > From: Shoudi Li <shoudil@qti.qualcomm.com> > > > > For the boards with multiple UDC ports, adb funtion will be impacted due > > to below error. > > > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > > ls: write error: Device or resource busy > > > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> > > Missing SoB or 'quaresma.jose@gmail.com'. > > > -- > With best wishes > Dmitry >
On Fri, Jan 23, 2026 at 5:46 PM Jose Quaresma via lists.openembedded.org <quaresma.jose=gmail.com@lists.openembedded.org> wrote: > > From: Shoudi Li <shoudil@qti.qualcomm.com> > > For the boards with multiple UDC ports, adb funtion will be impacted due > to below error. > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > ls: write error: Device or resource busy > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> > --- > .../android-tools-conf-configfs/android-gadget-start | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > index ca6c3df275..76b5e29624 100644 > --- a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > +++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start For some reason, there are two *android-tools-conf-configfs* recipes which seem identical except for this and a few other minor changes. I think this one in dynamic-layers/selinux should be removed instead of aligning it with the other recipe. > @@ -2,6 +2,8 @@ > > set -e > > -sleep 3 > +sleep 10 > > -ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > +ls /sys/class/udc/ | head -n 1 | xargs echo -n > /sys/kernel/config/usb_gadget/adb/UDC > + > +echo "Setting UDC $(ls /sys/class/udc/ | head -n 1) for USB ADB Gadget usage" > -- > 2.52.0 > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#123778): https://lists.openembedded.org/g/openembedded-devel/message/123778 > Mute This Topic: https://lists.openembedded.org/mt/117415388/3616702 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [anuj.mittal@oss.qualcomm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Sat, Jan 24, 2026 at 05:40:59PM +0800, Anuj Mittal wrote: > On Fri, Jan 23, 2026 at 5:46 PM Jose Quaresma via > lists.openembedded.org > <quaresma.jose=gmail.com@lists.openembedded.org> wrote: > > > > From: Shoudi Li <shoudil@qti.qualcomm.com> > > > > For the boards with multiple UDC ports, adb funtion will be impacted due > > to below error. > > > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > > ls: write error: Device or resource busy > > > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> > > --- > > .../android-tools-conf-configfs/android-gadget-start | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > index ca6c3df275..76b5e29624 100644 > > --- a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > +++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > For some reason, there are two *android-tools-conf-configfs* recipes > which seem identical except for this and a few other minor changes. I > think this one in dynamic-layers/selinux should be removed instead of > aligning it with the other recipe. Looks like it. Commit d3f4e6851243 ("android-tools 10: import version from meta-clang"), which added the second copy, isn't clear, why the second copy was necessary.
Hi Dmitry, the reason I added a second version of android-tools is explained in the pull-request which added android-tools version 10: https://github.com/openembedded/meta-openembedded/pull/664#issuecomment-1468861667 (one version depends on meta-selinux and the other does not). However I was not the one adding a second version of android-tools-conf. I don't see a good reason to have two copies of the recipe android-tools-conf, since this recipe doesn't depend on meta-selinux. This was probably just a mistake. On Sat, Jan 24, 2026 at 9:08 PM Dmitry Baryshkov < dmitry.baryshkov@oss.qualcomm.com> wrote: > On Sat, Jan 24, 2026 at 05:40:59PM +0800, Anuj Mittal wrote: > > On Fri, Jan 23, 2026 at 5:46 PM Jose Quaresma via > > lists.openembedded.org > > <quaresma.jose=gmail.com@lists.openembedded.org> wrote: > > > > > > From: Shoudi Li <shoudil@qti.qualcomm.com> > > > > > > For the boards with multiple UDC ports, adb funtion will be impacted > due > > > to below error. > > > > > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > > > ls: write error: Device or resource busy > > > > > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> > > > --- > > > .../android-tools-conf-configfs/android-gadget-start | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git > a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > > index ca6c3df275..76b5e29624 100644 > > > --- > a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > > +++ > b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > > > For some reason, there are two *android-tools-conf-configfs* recipes > > which seem identical except for this and a few other minor changes. I > > think this one in dynamic-layers/selinux should be removed instead of > > aligning it with the other recipe. > > Looks like it. Commit d3f4e6851243 ("android-tools 10: import version > from meta-clang"), which added the second copy, isn't clear, why the > second copy was necessary. > > -- > With best wishes > Dmitry >
Sorry, I misread the order of the git history: I was the one adding a second version of android-tools-conf. However since this recipe doesn't need meta-selinux, it should simply be removed. Only android-tools which has DEPENDS = "... libselinux" needs to be duplicated. On Sat, Jan 24, 2026 at 11:22 PM Etienne Cordonnier <ecordonnier@snap.com> wrote: > Hi Dmitry, > the reason I added a second version of android-tools is explained in the > pull-request which added android-tools version 10: > https://github.com/openembedded/meta-openembedded/pull/664#issuecomment-1468861667 > (one version depends on meta-selinux and the other does not). > > However I was not the one adding a second version of android-tools-conf. I > don't see a good reason to have two copies of the recipe > android-tools-conf, since this recipe doesn't depend on meta-selinux. This > was probably just a mistake. > > On Sat, Jan 24, 2026 at 9:08 PM Dmitry Baryshkov < > dmitry.baryshkov@oss.qualcomm.com> wrote: > >> On Sat, Jan 24, 2026 at 05:40:59PM +0800, Anuj Mittal wrote: >> > On Fri, Jan 23, 2026 at 5:46 PM Jose Quaresma via >> > lists.openembedded.org >> > <quaresma.jose=gmail.com@lists.openembedded.org> wrote: >> > > >> > > From: Shoudi Li <shoudil@qti.qualcomm.com> >> > > >> > > For the boards with multiple UDC ports, adb funtion will be impacted >> due >> > > to below error. >> > > >> > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC >> > > ls: write error: Device or resource busy >> > > >> > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> >> > > --- >> > > .../android-tools-conf-configfs/android-gadget-start | 6 >> ++++-- >> > > 1 file changed, 4 insertions(+), 2 deletions(-) >> > > >> > > diff --git >> a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start >> b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start >> > > index ca6c3df275..76b5e29624 100644 >> > > --- >> a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start >> > > +++ >> b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start >> > >> > For some reason, there are two *android-tools-conf-configfs* recipes >> > which seem identical except for this and a few other minor changes. I >> > think this one in dynamic-layers/selinux should be removed instead of >> > aligning it with the other recipe. >> >> Looks like it. Commit d3f4e6851243 ("android-tools 10: import version >> from meta-clang"), which added the second copy, isn't clear, why the >> second copy was necessary. >> >> -- >> With best wishes >> Dmitry >> >
On Sat, Jan 24, 2026 at 1:41 AM Anuj Mittal via lists.openembedded.org <anuj.mittal=oss.qualcomm.com@lists.openembedded.org> wrote: > On Fri, Jan 23, 2026 at 5:46 PM Jose Quaresma via > lists.openembedded.org > <quaresma.jose=gmail.com@lists.openembedded.org> wrote: > > > > From: Shoudi Li <shoudil@qti.qualcomm.com> > > > > For the boards with multiple UDC ports, adb funtion will be impacted due > > to below error. > > > > ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > > ls: write error: Device or resource busy > > > > Signed-off-by: Shoudi Li <shoudil@qti.qualcomm.com> > > --- > > .../android-tools-conf-configfs/android-gadget-start | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git > a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > index ca6c3df275..76b5e29624 100644 > > --- > a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > +++ > b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start > > For some reason, there are two *android-tools-conf-configfs* recipes > which seem identical except for this and a few other minor changes. I > think this one in dynamic-layers/selinux should be removed instead of > aligning it with the other recipe. > Right, I think its because there was selinux dependency. Things might have changed so I would prefer that we delete the one in meta-openembedded/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools and if we need something from meta-selinux, that could be added as a bbappend in dynamic layer e.g. dependency on selinux or somesuch > > > @@ -2,6 +2,8 @@ > > > > set -e > > > > -sleep 3 > > +sleep 10 > > > > -ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC > > +ls /sys/class/udc/ | head -n 1 | xargs echo -n > > /sys/kernel/config/usb_gadget/adb/UDC > > + > > +echo "Setting UDC $(ls /sys/class/udc/ | head -n 1) for USB ADB Gadget > usage" > > -- > > 2.52.0 > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#123822): > https://lists.openembedded.org/g/openembedded-devel/message/123822 > Mute This Topic: https://lists.openembedded.org/mt/117415388/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start index ca6c3df275..76b5e29624 100644 --- a/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start +++ b/meta-oe/dynamic-layers/selinux/recipes-devtool/android-tools/android-tools-conf-configfs/android-gadget-start @@ -2,6 +2,8 @@ set -e -sleep 3 +sleep 10 -ls /sys/class/udc/ > /sys/kernel/config/usb_gadget/adb/UDC +ls /sys/class/udc/ | head -n 1 | xargs echo -n > /sys/kernel/config/usb_gadget/adb/UDC + +echo "Setting UDC $(ls /sys/class/udc/ | head -n 1) for USB ADB Gadget usage"