| Message ID | 20251216003229.2229848-1-jm@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ryan Eatmon |
| Headers | show |
| Series | [meta-ti,scarthgap] meta-ti-bsp: Add support for beaglebadge | expand |
meta-ti / na / 20251216003229.2229848-1-jm
PRC Results: FAIL
=========================================================
check-yocto-patches: FAIL
=========================================================
Patches
----------------------------------------
FAIL - [meta-ti][scarthgap][PATCH] meta-ti-bsp: Add support for beaglebadge
WARN: Commit message does not include file/recipe name: meta-ti-bsp: Add support for beaglebadge. (COMMIT-MESSAGE-2)
patch
WARN: Commit message should not include directory path to recipe: meta-ti-bsp: Add support for beaglebadge.
meta-ti-bsp (COMMIT-MESSAGE-3)
patch
ERROR: Missing Signed-off-by in commit message. (SIGNED-OFF-BY-1)
patch
For details on the above errors/warnings visit: https://lists.yoctoproject.org/g/meta-ti/wiki/40887
On 12/15/2025 6:32 PM, Judith Mendez wrote: > Add support for the beaglebadge which is an am62l > based device that requires new build configration > for u-boot and TF-A sources. > --- > meta-ti-bsp/conf/machine/beaglebadge-ti.conf | 19 +++++++++++++++++++ > .../conf/machine/include/beaglebadge.inc | 9 +++++++++ > .../trusted-firmware-a-ti.inc | 3 +++ > 3 files changed, 31 insertions(+) > create mode 100644 meta-ti-bsp/conf/machine/beaglebadge-ti.conf > create mode 100644 meta-ti-bsp/conf/machine/include/beaglebadge.inc > > diff --git a/meta-ti-bsp/conf/machine/beaglebadge-ti.conf b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf > new file mode 100644 > index 00000000..a9d59823 > --- /dev/null > +++ b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf > @@ -0,0 +1,19 @@ > +#@TYPE: Machine > +#@NAME: AM62L Badge > +#@DESCRIPTION: Machine configuration for the TI AM62L Badge > + > +require conf/machine/include/beaglebadge.inc > + > +IMAGE_FSTYPES += "ubifs ubi" > + > +MKUBIFS_ARGS ?= "-F -m 4096 -e 258048 -c 8500" > + > +UBINIZE_ARGS ?= "-m 4096 -p 256KiB -s 1024 -O 1024" > + > +KERNEL_DEVICETREE_PREFIX = " \ > + ti/k3-am62l3-badge \ > +" > + > +KERNEL_DEVICETREE = "" > + > +UBOOT_MACHINE = "am62lx_badge_defconfig" > diff --git a/meta-ti-bsp/conf/machine/include/beaglebadge.inc b/meta-ti-bsp/conf/machine/include/beaglebadge.inc > new file mode 100644 > index 00000000..5700050a > --- /dev/null > +++ b/meta-ti-bsp/conf/machine/include/beaglebadge.inc > @@ -0,0 +1,9 @@ > +require conf/machine/include/k3.inc > +SOC_FAMILY:append = ":am62lxx" > + > +MACHINE_FEATURES += "screen" > + > +TFA_BOARD = "am62l-badge" > +TFA_K3_SYSTEM_SUSPEND = "1" > + > +OPTEEMACHINE = "k3-am62lx" You should be able to simplify this file down by just having: require conf/machine/include/am62lxx.inc TFA_BOARD = "am62l-badge" Only if we majorly change what goes in this file should we then duplicate the entries. > diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > index 9e733448..7ef3dfb7 100644 > --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > @@ -14,6 +14,8 @@ SRCREV_tfa:am62lxx = "7252a99fb781075db1987d8ce2c7e37324297427" > SRC_URI_TRUSTED_FIRMWARE_A:am62lxx = "git://github.com/TexasInstruments/arm-trusted-firmware.git;protocol=https" > SRCBRANCH:am62lxx = "ti-master" > > +SRCREV_tfa:beaglebadge-ti = "76800058f24e3eb3fcacdb12106a881ae279f8c3" > + This file is confusing. Since beaglebadge-ti adds am62lxx to the SOC_FAMILY *it is an am62lxx*. So I don't think you need any of the changes in this file at all. The only real difference is the SRCREV_tfa, but I'm thinking you are just trying to pick a newer commit that has support for it, so you should change the SRCREV_tfa:am62lxx and not create a new override. Does the new board really need a different SRCREV? Or is just a newer one that picks up support for it? > SRC_URI = "${SRC_URI_TRUSTED_FIRMWARE_A};name=tfa;branch=${SRCBRANCH}" > > COMPATIBLE_MACHINE = "k3" > @@ -24,6 +26,7 @@ TFA_SPD = "opteed" > > # For am62lxx, install bl1 & bl31 using TFA_INSTALL_TARGET > TFA_INSTALL_TARGET:am62lxx = "bl31 bl1" > +TFA_INSTALL_TARGET:beaglebadge-ti = "bl31 bl1" > > EXTRA_OEMAKE += "${@ 'K3_USART=' + d.getVar('TFA_K3_USART') if d.getVar('TFA_K3_USART') else ''}" > EXTRA_OEMAKE += "${@ 'BL32_BASE=' + d.getVar('TFA_K3_BL32_BASE') if d.getVar('TFA_K3_BL32_BASE') else ''}"
On 12/15/25 6:32 PM, Mendez, Judith via lists.yoctoproject.org wrote: > Add support for the beaglebadge which is an am62l Are we calling it this now? (meta-ti is a public list so I guess so) Will probably be capitalized like "BeagleBadge", same for "AM62L". > based device that requires new build configration s/configration/configuration > for u-boot and TF-A sources. s/u-boot/U-Boot > --- > meta-ti-bsp/conf/machine/beaglebadge-ti.conf | 19 +++++++++++++++++++ > .../conf/machine/include/beaglebadge.inc | 9 +++++++++ > .../trusted-firmware-a-ti.inc | 3 +++ > 3 files changed, 31 insertions(+) > create mode 100644 meta-ti-bsp/conf/machine/beaglebadge-ti.conf > create mode 100644 meta-ti-bsp/conf/machine/include/beaglebadge.inc > > diff --git a/meta-ti-bsp/conf/machine/beaglebadge-ti.conf b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf > new file mode 100644 > index 00000000..a9d59823 > --- /dev/null > +++ b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf > @@ -0,0 +1,19 @@ > +#@TYPE: Machine > +#@NAME: AM62L Badge > +#@DESCRIPTION: Machine configuration for the TI AM62L Badge > + > +require conf/machine/include/beaglebadge.inc > + > +IMAGE_FSTYPES += "ubifs ubi" > + > +MKUBIFS_ARGS ?= "-F -m 4096 -e 258048 -c 8500" > + > +UBINIZE_ARGS ?= "-m 4096 -p 256KiB -s 1024 -O 1024" > + > +KERNEL_DEVICETREE_PREFIX = " \ > + ti/k3-am62l3-badge \ > +" > + > +KERNEL_DEVICETREE = "" > + > +UBOOT_MACHINE = "am62lx_badge_defconfig" > diff --git a/meta-ti-bsp/conf/machine/include/beaglebadge.inc b/meta-ti-bsp/conf/machine/include/beaglebadge.inc > new file mode 100644 > index 00000000..5700050a > --- /dev/null > +++ b/meta-ti-bsp/conf/machine/include/beaglebadge.inc > @@ -0,0 +1,9 @@ > +require conf/machine/include/k3.inc > +SOC_FAMILY:append = ":am62lxx" > + > +MACHINE_FEATURES += "screen" > + > +TFA_BOARD = "am62l-badge" > +TFA_K3_SYSTEM_SUSPEND = "1" This line isn't needed. Also, we probably do not need an include for this when everything is the same a am62lxx.inc (other than the TFA_BOARD which you can just override in the .conf file). > + > +OPTEEMACHINE = "k3-am62lx" > diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > index 9e733448..7ef3dfb7 100644 > --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc > @@ -14,6 +14,8 @@ SRCREV_tfa:am62lxx = "7252a99fb781075db1987d8ce2c7e37324297427" > SRC_URI_TRUSTED_FIRMWARE_A:am62lxx = "git://github.com/TexasInstruments/arm-trusted-firmware.git;protocol=https" > SRCBRANCH:am62lxx = "ti-master" > > +SRCREV_tfa:beaglebadge-ti = "76800058f24e3eb3fcacdb12106a881ae279f8c3" > + > SRC_URI = "${SRC_URI_TRUSTED_FIRMWARE_A};name=tfa;branch=${SRCBRANCH}" > > COMPATIBLE_MACHINE = "k3" > @@ -24,6 +26,7 @@ TFA_SPD = "opteed" > > # For am62lxx, install bl1 & bl31 using TFA_INSTALL_TARGET > TFA_INSTALL_TARGET:am62lxx = "bl31 bl1" > +TFA_INSTALL_TARGET:beaglebadge-ti = "bl31 bl1" Line not needed, this board will also match the "am62lxx" line above. Andrew > > EXTRA_OEMAKE += "${@ 'K3_USART=' + d.getVar('TFA_K3_USART') if d.getVar('TFA_K3_USART') else ''}" > EXTRA_OEMAKE += "${@ 'BL32_BASE=' + d.getVar('TFA_K3_BL32_BASE') if d.getVar('TFA_K3_BL32_BASE') else ''}"
On 12/16/25 8:52 AM, Ryan Eatmon wrote: > > > On 12/15/2025 6:32 PM, Judith Mendez wrote: >> Add support for the beaglebadge which is an am62l >> based device that requires new build configration >> for u-boot and TF-A sources. >> --- >> meta-ti-bsp/conf/machine/beaglebadge-ti.conf | 19 +++++++++++++++++++ >> .../conf/machine/include/beaglebadge.inc | 9 +++++++++ >> .../trusted-firmware-a-ti.inc | 3 +++ >> 3 files changed, 31 insertions(+) >> create mode 100644 meta-ti-bsp/conf/machine/beaglebadge-ti.conf >> create mode 100644 meta-ti-bsp/conf/machine/include/beaglebadge.inc >> >> diff --git a/meta-ti-bsp/conf/machine/beaglebadge-ti.conf b/meta-ti- >> bsp/conf/machine/beaglebadge-ti.conf >> new file mode 100644 >> index 00000000..a9d59823 >> --- /dev/null >> +++ b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf >> @@ -0,0 +1,19 @@ >> +#@TYPE: Machine >> +#@NAME: AM62L Badge >> +#@DESCRIPTION: Machine configuration for the TI AM62L Badge >> + >> +require conf/machine/include/beaglebadge.inc >> + >> +IMAGE_FSTYPES += "ubifs ubi" >> + >> +MKUBIFS_ARGS ?= "-F -m 4096 -e 258048 -c 8500" >> + >> +UBINIZE_ARGS ?= "-m 4096 -p 256KiB -s 1024 -O 1024" >> + >> +KERNEL_DEVICETREE_PREFIX = " \ >> + ti/k3-am62l3-badge \ >> +" >> + >> +KERNEL_DEVICETREE = "" >> + >> +UBOOT_MACHINE = "am62lx_badge_defconfig" >> diff --git a/meta-ti-bsp/conf/machine/include/beaglebadge.inc b/meta- >> ti-bsp/conf/machine/include/beaglebadge.inc >> new file mode 100644 >> index 00000000..5700050a >> --- /dev/null >> +++ b/meta-ti-bsp/conf/machine/include/beaglebadge.inc >> @@ -0,0 +1,9 @@ >> +require conf/machine/include/k3.inc >> +SOC_FAMILY:append = ":am62lxx" >> + >> +MACHINE_FEATURES += "screen" >> + >> +TFA_BOARD = "am62l-badge" >> +TFA_K3_SYSTEM_SUSPEND = "1" >> + >> +OPTEEMACHINE = "k3-am62lx" > > > You should be able to simplify this file down by just having: > > require conf/machine/include/am62lxx.inc > > TFA_BOARD = "am62l-badge" > > > Only if we majorly change what goes in this file should we then > duplicate the entries. > > >> diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted- >> firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/ >> trusted-firmware-a-ti.inc >> index 9e733448..7ef3dfb7 100644 >> --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a- >> ti.inc >> +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a- >> ti.inc >> @@ -14,6 +14,8 @@ SRCREV_tfa:am62lxx = >> "7252a99fb781075db1987d8ce2c7e37324297427" >> SRC_URI_TRUSTED_FIRMWARE_A:am62lxx = "git://github.com/ >> TexasInstruments/arm-trusted-firmware.git;protocol=https" >> SRCBRANCH:am62lxx = "ti-master" >> +SRCREV_tfa:beaglebadge-ti = "76800058f24e3eb3fcacdb12106a881ae279f8c3" >> + > > This file is confusing. Since beaglebadge-ti adds am62lxx to the > SOC_FAMILY *it is an am62lxx*. So I don't think you need any of the > changes in this file at all. > > The only real difference is the SRCREV_tfa, but I'm thinking you are > just trying to pick a newer commit that has support for it, so you > should change the SRCREV_tfa:am62lxx and not create a new override. > > > Does the new board really need a different SRCREV? Or is just a newer > one that picks up support for it? Latest commit in TF-A supports beaglebage, so will update am62l commit shaw then, thanks > >> SRC_URI = "${SRC_URI_TRUSTED_FIRMWARE_A};name=tfa;branch=${SRCBRANCH}" >> COMPATIBLE_MACHINE = "k3" >> @@ -24,6 +26,7 @@ TFA_SPD = "opteed" >> # For am62lxx, install bl1 & bl31 using TFA_INSTALL_TARGET >> TFA_INSTALL_TARGET:am62lxx = "bl31 bl1" >> +TFA_INSTALL_TARGET:beaglebadge-ti = "bl31 bl1" >> EXTRA_OEMAKE += "${@ 'K3_USART=' + d.getVar('TFA_K3_USART') if >> d.getVar('TFA_K3_USART') else ''}" >> EXTRA_OEMAKE += "${@ 'BL32_BASE=' + d.getVar('TFA_K3_BL32_BASE') if >> d.getVar('TFA_K3_BL32_BASE') else ''}" >
diff --git a/meta-ti-bsp/conf/machine/beaglebadge-ti.conf b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf new file mode 100644 index 00000000..a9d59823 --- /dev/null +++ b/meta-ti-bsp/conf/machine/beaglebadge-ti.conf @@ -0,0 +1,19 @@ +#@TYPE: Machine +#@NAME: AM62L Badge +#@DESCRIPTION: Machine configuration for the TI AM62L Badge + +require conf/machine/include/beaglebadge.inc + +IMAGE_FSTYPES += "ubifs ubi" + +MKUBIFS_ARGS ?= "-F -m 4096 -e 258048 -c 8500" + +UBINIZE_ARGS ?= "-m 4096 -p 256KiB -s 1024 -O 1024" + +KERNEL_DEVICETREE_PREFIX = " \ + ti/k3-am62l3-badge \ +" + +KERNEL_DEVICETREE = "" + +UBOOT_MACHINE = "am62lx_badge_defconfig" diff --git a/meta-ti-bsp/conf/machine/include/beaglebadge.inc b/meta-ti-bsp/conf/machine/include/beaglebadge.inc new file mode 100644 index 00000000..5700050a --- /dev/null +++ b/meta-ti-bsp/conf/machine/include/beaglebadge.inc @@ -0,0 +1,9 @@ +require conf/machine/include/k3.inc +SOC_FAMILY:append = ":am62lxx" + +MACHINE_FEATURES += "screen" + +TFA_BOARD = "am62l-badge" +TFA_K3_SYSTEM_SUSPEND = "1" + +OPTEEMACHINE = "k3-am62lx" diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc index 9e733448..7ef3dfb7 100644 --- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc +++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a-ti.inc @@ -14,6 +14,8 @@ SRCREV_tfa:am62lxx = "7252a99fb781075db1987d8ce2c7e37324297427" SRC_URI_TRUSTED_FIRMWARE_A:am62lxx = "git://github.com/TexasInstruments/arm-trusted-firmware.git;protocol=https" SRCBRANCH:am62lxx = "ti-master" +SRCREV_tfa:beaglebadge-ti = "76800058f24e3eb3fcacdb12106a881ae279f8c3" + SRC_URI = "${SRC_URI_TRUSTED_FIRMWARE_A};name=tfa;branch=${SRCBRANCH}" COMPATIBLE_MACHINE = "k3" @@ -24,6 +26,7 @@ TFA_SPD = "opteed" # For am62lxx, install bl1 & bl31 using TFA_INSTALL_TARGET TFA_INSTALL_TARGET:am62lxx = "bl31 bl1" +TFA_INSTALL_TARGET:beaglebadge-ti = "bl31 bl1" EXTRA_OEMAKE += "${@ 'K3_USART=' + d.getVar('TFA_K3_USART') if d.getVar('TFA_K3_USART') else ''}" EXTRA_OEMAKE += "${@ 'BL32_BASE=' + d.getVar('TFA_K3_BL32_BASE') if d.getVar('TFA_K3_BL32_BASE') else ''}"