diff mbox series

[meta-oe] libmng: correct version of libmng

Message ID 20251203090342.2024473-1-changqing.li@windriver.com
State Accepted
Headers show
Series [meta-oe] libmng: correct version of libmng | expand

Commit Message

Changqing Li Dec. 3, 2025, 9:03 a.m. UTC
From: Changqing Li <changqing.li@windriver.com>

Current version is 2.0.3, the lastrelease of libmng is in 2015,
add a patch to fix it

Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
 ...0001-configura.ac-update-the-version.patch | 32 +++++++++++++++++++
 .../recipes-graphics/libmng/libmng_2.0.3.bb   |  3 +-
 2 files changed, 34 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-graphics/libmng/libmng/0001-configura.ac-update-the-version.patch

Comments

Ross Burton Dec. 3, 2025, 11:08 a.m. UTC | #1
On 3 Dec 2025, at 09:03, Changqing Li via lists.openembedded.org <changqing.li=windriver.com@lists.openembedded.org> wrote:
> 
> From: Changqing Li <changqing.li@windriver.com>
> 
> Current version is 2.0.3, the lastrelease of libmng is in 2015,
> add a patch to fix it

Last release a decade ago, for a image format that was designed to replace GIF, but no browsers actually support, and has been superseded by APNG which is supported by all browsers and a W3C Recommendation?

Sounds like the follow-up patch to this cleanup should be to delete the recipe…

Ross
Changqing Li Dec. 4, 2025, 2:35 a.m. UTC | #2
On 12/3/25 19:08, Ross Burton wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On 3 Dec 2025, at 09:03, Changqing Li via lists.openembedded.org<changqing.li=windriver.com@lists.openembedded.org> wrote:
>> From: Changqing Li<changqing.li@windriver.com>
>>
>> Current version is 2.0.3, the lastrelease of libmng is in 2015,
>> add a patch to fix it
> Last release a decade ago, for a image format that was designed to replace GIF, but no browsers actually support, and has been superseded by APNG which is supported by all browsers and a W3C Recommendation?
>
> Sounds like the follow-up patch to this cleanup should be to delete the recipe…

Thanks for sharing the background.

I searched under meta-openembeded, there is one recipe might depend on this.

https://git.openembedded.org/meta-openembedded/tree/meta-gnome/recipes-gimp/gimp/gimp_3.0.6.bb?id=1d3c3ad93c962ee1c27d88076b63d08e53c8b318#n80

Another recipe that depend on this:

https://code.qt.io/cgit/yocto/meta-qt6.git/tree/recipes-qt/qt6/qtimageformats_git.bb?h=6.10#n19

Seems we cannot delete the recipe unless we don't support those 
PACKAGECONFIG mng.

//Changqing

>
> Ross
Ross Burton Dec. 4, 2025, 11:04 a.m. UTC | #3
> On 4 Dec 2025, at 02:35, Changqing Li <changqing.li@windriver.com> wrote:
> 
> 
> On 12/3/25 19:08, Ross Burton wrote:
>> CAUTION: This email comes from a non Wind River email account!
>> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>> 
>> On 3 Dec 2025, at 09:03, Changqing Li via lists.openembedded.org <changqing.li=windriver.com@lists.openembedded.org> wrote:
>> 
>>> From: Changqing Li <changqing.li@windriver.com>
>>> 
>>> Current version is 2.0.3, the lastrelease of libmng is in 2015,
>>> add a patch to fix it
>>> 
>> Last release a decade ago, for a image format that was designed to replace GIF, but no browsers actually support, and has been superseded by APNG which is supported by all browsers and a W3C Recommendation?
>> 
>> Sounds like the follow-up patch to this cleanup should be to delete the recipe…
> Thanks for sharing the background.
> I searched under meta-openembeded, there is one recipe might depend on this.
> https://git.openembedded.org/meta-openembedded/tree/meta-gnome/recipes-gimp/gimp/gimp_3.0.6.bb?id=1d3c3ad93c962ee1c27d88076b63d08e53c8b318#n80
> Another recipe that depend on this:
> https://code.qt.io/cgit/yocto/meta-qt6.git/tree/recipes-qt/qt6/qtimageformats_git.bb?h=6.10#n19
> Seems we cannot delete the recipe unless we don't support those PACKAGECONFIG mng.
> //Changqing

The gimp option is easily removed (or at least, disabled by default) in the same patch set, and meta-qt will just have to update. MNG _is_ dead, so there’s no reason to keep the code around in our layers.

Ross
Khem Raj Dec. 4, 2025, 2:14 p.m. UTC | #4
On Thu, Dec 4, 2025 at 3:05 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:

>
>
> > On 4 Dec 2025, at 02:35, Changqing Li <changqing.li@windriver.com>
> wrote:
> >
> >
> > On 12/3/25 19:08, Ross Burton wrote:
> >> CAUTION: This email comes from a non Wind River email account!
> >> Do not click links or open attachments unless you recognize the sender
> and know the content is safe.
> >>
> >> On 3 Dec 2025, at 09:03, Changqing Li via lists.openembedded.org <
> changqing.li=windriver.com@lists.openembedded.org> wrote:
> >>
> >>> From: Changqing Li <changqing.li@windriver.com>
> >>>
> >>> Current version is 2.0.3, the lastrelease of libmng is in 2015,
> >>> add a patch to fix it
> >>>
> >> Last release a decade ago, for a image format that was designed to
> replace GIF, but no browsers actually support, and has been superseded by
> APNG which is supported by all browsers and a W3C Recommendation?
> >>
> >> Sounds like the follow-up patch to this cleanup should be to delete the
> recipe…
> > Thanks for sharing the background.
> > I searched under meta-openembeded, there is one recipe might depend on
> this.
> >
> https://git.openembedded.org/meta-openembedded/tree/meta-gnome/recipes-gimp/gimp/gimp_3.0.6.bb?id=1d3c3ad93c962ee1c27d88076b63d08e53c8b318#n80
> > Another recipe that depend on this:
> >
> https://code.qt.io/cgit/yocto/meta-qt6.git/tree/recipes-qt/qt6/qtimageformats_git.bb?h=6.10#n19
> > Seems we cannot delete the recipe unless we don't support those
> PACKAGECONFIG mng.
> > //Changqing
>
> The gimp option is easily removed (or at least, disabled by default) in
> the same patch set, and meta-qt will just have to update. MNG _is_ dead, so
> there’s no reason to keep the code around in our layers.
>
>
There was a need of it in webkit too IIRC in past.
I agree, for now I have moved with the patch and if we can get more
awareness of its removal then perhaps we should revisit and remove it.


> Ross
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#122318):
> https://lists.openembedded.org/g/openembedded-devel/message/122318
> Mute This Topic: https://lists.openembedded.org/mt/116591341/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta-oe/recipes-graphics/libmng/libmng/0001-configura.ac-update-the-version.patch b/meta-oe/recipes-graphics/libmng/libmng/0001-configura.ac-update-the-version.patch
new file mode 100644
index 0000000000..f0f644f807
--- /dev/null
+++ b/meta-oe/recipes-graphics/libmng/libmng/0001-configura.ac-update-the-version.patch
@@ -0,0 +1,32 @@ 
+From 8bf709daf0fe0657b55dad50a3a04854140c69a3 Mon Sep 17 00:00:00 2001
+From: Changqing Li <changqing.li@windriver.com>
+Date: Wed, 3 Dec 2025 13:57:39 +0800
+Subject: [PATCH] configura.ac: update the version
+
+current version is 2.0.3
+
+Upstream-Status: Inactive-Upstream [ lastrelease: 2015-04-20 ]
+
+https://sourceforge.net/projects/libmng/files/libmng-devel/
+
+Signed-off-by: Changqing Li <changqing.li@windriver.com>
+---
+ configure.ac | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/configure.ac b/configure.ac
+index 04f9c7a..a7ca9d8 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -3,7 +3,7 @@ AC_PREREQ(2.65)
+ #
+ define([MAJ_NR],[2])
+ define([MIN_NR],[0])
+-define([REL_NR],[2])
++define([REL_NR],[3])
+ #
+ #AC_INIT (PACKAGE, VERSION, [BUG-REPORT], [TARNAME], [URL])
+ AC_INIT( [libmng],[MAJ_NR.MIN_NR.REL_NR],
+-- 
+2.34.1
+
diff --git a/meta-oe/recipes-graphics/libmng/libmng_2.0.3.bb b/meta-oe/recipes-graphics/libmng/libmng_2.0.3.bb
index c92696b8bf..fe76520d15 100644
--- a/meta-oe/recipes-graphics/libmng/libmng_2.0.3.bb
+++ b/meta-oe/recipes-graphics/libmng/libmng_2.0.3.bb
@@ -8,7 +8,8 @@  LIC_FILES_CHKSUM = "file://LICENSE;md5=32becdb8930f90eab219a8021130ec09"
 SECTION = "devel"
 DEPENDS = "zlib"
 
-SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.gz"
+SRC_URI = "${SOURCEFORGE_MIRROR}/${BPN}/${BP}.tar.gz \
+           file://0001-configura.ac-update-the-version.patch"
 
 SRC_URI[sha256sum] = "cf112a1fb02f5b1c0fce5cab11ea8243852c139e669c44014125874b14b7dfaa"