diff mbox series

[meta-gnome,1/3] gtksourceview4: Adjust for setting S in gnomebase.bbclass

Message ID 20251119044347.2884483-1-raj.khem@gmail.com
State New
Headers show
Series [meta-gnome,1/3] gtksourceview4: Adjust for setting S in gnomebase.bbclass | expand

Commit Message

Khem Raj Nov. 19, 2025, 4:43 a.m. UTC
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Ross Burton <ross.burton@arm.com>
---
 .../recipes-gnome/gtksourceview/gtksourceview4_4.8.4.bb     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Ross Burton Nov. 19, 2025, 10:41 a.m. UTC | #1
On 19 Nov 2025, at 04:43, Khem Raj <raj.khem@gmail.com> wrote:
> -SRC_URI = "${GNOME_MIRROR}/gtksourceview/4.8/${PNAME}-${PV}.tar.xz \
> +SRC_URI = "${GNOME_MIRROR}/gtksourceview/${@oe.utils.trim_version("${PV}", 2)}/${GNOMEBN}-${PV}.tar.xz \
>            file://0001-remove-pointless-check.patch"
> SRC_URI[sha256sum] = "7ec9d18fb283d1f84a3a3eff3b7a72b09a10c9c006597b3fbabbb5958420a87d"

You can change the SRC_URI to be just += the patch, as gnomebase has a default SRC_URI too.

Ross
Khem Raj Nov. 19, 2025, 4:33 p.m. UTC | #2
On Wed, Nov 19, 2025 at 2:42 AM Ross Burton <Ross.Burton@arm.com> wrote:

> On 19 Nov 2025, at 04:43, Khem Raj <raj.khem@gmail.com> wrote:
> > -SRC_URI = "${GNOME_MIRROR}/gtksourceview/4.8/${PNAME}-${PV}.tar.xz \
> > +SRC_URI =
> "${GNOME_MIRROR}/gtksourceview/${@oe.utils.trim_version("${PV}",
> 2)}/${GNOMEBN}-${PV}.tar.xz \
> >            file://0001-remove-pointless-check.patch"
> > SRC_URI[sha256sum] =
> "7ec9d18fb283d1f84a3a3eff3b7a72b09a10c9c006597b3fbabbb5958420a87d"
>
> You can change the SRC_URI to be just += the patch, as gnomebase has a
> default SRC_URI too.
>
>
Thanks for the fix


> Ross
diff mbox series

Patch

diff --git a/meta-gnome/recipes-gnome/gtksourceview/gtksourceview4_4.8.4.bb b/meta-gnome/recipes-gnome/gtksourceview/gtksourceview4_4.8.4.bb
index b9ff4ef459..01d91d31bf 100644
--- a/meta-gnome/recipes-gnome/gtksourceview/gtksourceview4_4.8.4.bb
+++ b/meta-gnome/recipes-gnome/gtksourceview/gtksourceview4_4.8.4.bb
@@ -6,15 +6,13 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"

 DEPENDS = "gtk+3 libxml2 glib-2.0-native"

-PNAME = "gtksourceview"
-
-S = "${UNPACKDIR}/${PNAME}-${PV}"
+GNOMEBN = "gtksourceview"

 inherit gnomebase lib_package gettext features_check gtk-doc gobject-introspection vala

 ANY_OF_DISTRO_FEATURES = "${GTK3DISTROFEATURES}"

-SRC_URI = "${GNOME_MIRROR}/gtksourceview/4.8/${PNAME}-${PV}.tar.xz \
+SRC_URI = "${GNOME_MIRROR}/gtksourceview/${@oe.utils.trim_version("${PV}", 2)}/${GNOMEBN}-${PV}.tar.xz \
            file://0001-remove-pointless-check.patch"
 SRC_URI[sha256sum] = "7ec9d18fb283d1f84a3a3eff3b7a72b09a10c9c006597b3fbabbb5958420a87d"