diff mbox series

[meta-ti,scarthgap,v4] meta-ti-bsp: optee: Ensure libckteec.so symlink is installed

Message ID 20251117083407.3719468-1-s-joshi@ti.com
State Rejected
Delegated to: Ryan Eatmon
Headers show
Series [meta-ti,scarthgap,v4] meta-ti-bsp: optee: Ensure libckteec.so symlink is installed | expand

Commit Message

Suhaas Joshi Nov. 17, 2025, 8:34 a.m. UTC 
Presently, /usr/lib/libckteec.so is not installed. Instead, the only
symlink present is /usr/lib/libckteec.so.0 which points to
libckteec.so.0.1.0. This makes OpenSSL commands fail since it looks for
/usr/bin/libckteec.so.

So ensure that this symlink is installed by explicitly adding a
FILES:${PN} assignment.

Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
---
v3 -> v4:
* I realized that libckteec.so.0* and the PKCS#11 TA file were both already installed in the SDK.
  Therefore, in v4, I have removed the logic for that since its redundant now. CFG_PKCS11_TA and
  CFG_REE_FS are enabled by-default.
* v4 only fixes one issue: the absence of libckteec.so. /usr/bin/libckteec.so should link to
  /usr/bin/libckteec.so.0 which then links to /usr/bin/libckteec.so.0.1.0.
* Link to v3:
https://lore.kernel.org/yocto-meta-ti/20251113104522.2443817-1-prc@list.ti.com/T/#t
---
 .../recipes-security/optee/optee-client-ti-overrides.inc     | 1 +
 meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend   | 5 +++++
 2 files changed, 6 insertions(+)
 create mode 100644 meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc

Comments

PRC Automation Nov. 17, 2025, 8:40 a.m. UTC | #1 
meta-ti / na / 20251117083407.3719468-1-s-joshi

PRC Results: PASS

=========================================================
  check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
WARN - [meta-ti][scarthgap][PATCH v4] meta-ti-bsp: optee: Ensure libckteec.so symlink is installed
    WARN: Commit message does not include file/recipe name: meta-ti-bsp: optee: Ensure libckteec.so symlink is installed. (COMMIT-MESSAGE-2)
        patch
    
    WARN: Commit message should not include directory path to recipe: meta-ti-bsp: optee: Ensure libckteec.so symlink is installed.
              meta-ti-bsp: (COMMIT-MESSAGE-3)
        patch



=========================================================
  apply-yocto-patch: PASS
=========================================================
scarthgap
=====================
Summary:
- Patch Series: [meta-ti][scarthgap][PATCH v4] meta-ti-bsp: optee: Ensure libckteec.so symlink is installed
- Submitter: From: Suhaas Joshi <s-joshi@ti.com>
- Date: Date: Mon, 17 Nov 2025 14:04:08 +0530
- Num Patches: 1
- Mailing List (public inbox) Commit SHA: b7db69a9dc1494589c99704730dcecaead2489e7

Applied to:
- Repository: lcpd-prc-meta-ti
- Base Branch: scarthgap-wip
- Commit Author: LCPD Automation Script <lcpdbld@list.ti.com>
- Commit Subject: CI/CD Auto-Merger: cicd.scarthgap.202511140456
- Commit SHA: f483464c72055cdcb81853e06afc89719e73073f

Patches
----------------------------------------
All patches applied



=========================================================
  check-yocto-repo: PASS
=========================================================
scarthgap
=====================
PASS
Andrew Davis Nov. 17, 2025, 7:06 p.m. UTC | #2 
On 11/17/25 2:34 AM, Suhaas Joshi via lists.yoctoproject.org wrote:
> Presently, /usr/lib/libckteec.so is not installed. Instead, the only
> symlink present is /usr/lib/libckteec.so.0 which points to
> libckteec.so.0.1.0. This makes OpenSSL commands fail since it looks for
> /usr/bin/libckteec.so.
> 

Seems like this would be an issue for others, have you sent this fix
upstream to meta-arm?

Andrew

> So ensure that this symlink is installed by explicitly adding a
> FILES:${PN} assignment.
> 
> Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
> ---
> v3 -> v4:
> * I realized that libckteec.so.0* and the PKCS#11 TA file were both already installed in the SDK.
>    Therefore, in v4, I have removed the logic for that since its redundant now. CFG_PKCS11_TA and
>    CFG_REE_FS are enabled by-default.
> * v4 only fixes one issue: the absence of libckteec.so. /usr/bin/libckteec.so should link to
>    /usr/bin/libckteec.so.0 which then links to /usr/bin/libckteec.so.0.1.0.
> * Link to v3:
> https://lore.kernel.org/yocto-meta-ti/20251113104522.2443817-1-prc@list.ti.com/T/#t
> ---
>   .../recipes-security/optee/optee-client-ti-overrides.inc     | 1 +
>   meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend   | 5 +++++
>   2 files changed, 6 insertions(+)
>   create mode 100644 meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> 
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> new file mode 100644
> index 00000000..dd6a9d01
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> @@ -0,0 +1 @@
> +FILES:${PN} += "${libdir}/libckteec.so*"
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> index f193e78b..0cee127f 100644
> --- a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> +++ b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> @@ -2,3 +2,8 @@ OPTEE_TI_VERSION = ""
>   OPTEE_TI_VERSION:ti-soc = "${BPN}-ti-version.inc"
>   
>   require ${OPTEE_TI_VERSION}
> +
> +OPTEE_TI_OVERRIDES = ""
> +OPTEE_TI_OVERRIDES:ti-soc = "${BPN}-ti-overrides.inc"
> +
> +require ${OPTEE_TI_OVERRIDES}
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#19278): https://lists.yoctoproject.org/g/meta-ti/message/19278
> Mute This Topic: https://lists.yoctoproject.org/mt/116334516/3619733
> Group Owner: meta-ti+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Suhaas Joshi Nov. 18, 2025, 8:14 a.m. UTC | #3 
On 13:06-20251117, Andrew Davis wrote:
> On 11/17/25 2:34 AM, Suhaas Joshi via lists.yoctoproject.org wrote:
> > Presently, /usr/lib/libckteec.so is not installed. Instead, the only
> > symlink present is /usr/lib/libckteec.so.0 which points to
> > libckteec.so.0.1.0. This makes OpenSSL commands fail since it looks for
> > /usr/bin/libckteec.so.
> > 
> 
> Seems like this would be an issue for others, have you sent this fix
> upstream to meta-arm?

No, I have not. Will send it soon, once this patch is accepted.

Thanks
Suhaas
>
> Andrew
> 
> > So ensure that this symlink is installed by explicitly adding a
> > FILES:${PN} assignment.
> > 
> > Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
> > ---
> > v3 -> v4:
> > * I realized that libckteec.so.0* and the PKCS#11 TA file were both already installed in the SDK.
> >    Therefore, in v4, I have removed the logic for that since its redundant now. CFG_PKCS11_TA and
> >    CFG_REE_FS are enabled by-default.
> > * v4 only fixes one issue: the absence of libckteec.so. /usr/bin/libckteec.so should link to
> >    /usr/bin/libckteec.so.0 which then links to /usr/bin/libckteec.so.0.1.0.
> > * Link to v3:
> > https://lore.kernel.org/yocto-meta-ti/20251113104522.2443817-1-prc@list.ti.com/T/#t
> > ---
> >   .../recipes-security/optee/optee-client-ti-overrides.inc     | 1 +
> >   meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend   | 5 +++++
> >   2 files changed, 6 insertions(+)
> >   create mode 100644 meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> > 
> > diff --git a/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> > new file mode 100644
> > index 00000000..dd6a9d01
> > --- /dev/null
> > +++ b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> > @@ -0,0 +1 @@
> > +FILES:${PN} += "${libdir}/libckteec.so*"
> > diff --git a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> > index f193e78b..0cee127f 100644
> > --- a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> > +++ b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> > @@ -2,3 +2,8 @@ OPTEE_TI_VERSION = ""
> >   OPTEE_TI_VERSION:ti-soc = "${BPN}-ti-version.inc"
> >   require ${OPTEE_TI_VERSION}
> > +
> > +OPTEE_TI_OVERRIDES = ""
> > +OPTEE_TI_OVERRIDES:ti-soc = "${BPN}-ti-overrides.inc"
> > +
> > +require ${OPTEE_TI_OVERRIDES}
> > 
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#19278): https://lists.yoctoproject.org/g/meta-ti/message/19278
> > Mute This Topic: https://lists.yoctoproject.org/mt/116334516/3619733
> > Group Owner: meta-ti+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 
>
Andrew Davis Nov. 18, 2025, 4:29 p.m. UTC | #4 
On 11/18/25 2:14 AM, Suhaas Joshi wrote:
> On 13:06-20251117, Andrew Davis wrote:
>> On 11/17/25 2:34 AM, Suhaas Joshi via lists.yoctoproject.org wrote:
>>> Presently, /usr/lib/libckteec.so is not installed. Instead, the only
>>> symlink present is /usr/lib/libckteec.so.0 which points to
>>> libckteec.so.0.1.0. This makes OpenSSL commands fail since it looks for
>>> /usr/bin/libckteec.so.
>>>
>>
>> Seems like this would be an issue for others, have you sent this fix
>> upstream to meta-arm?
> 
> No, I have not. Will send it soon, once this patch is accepted.
> 

Why wait? "Upstream first", maybe the ARM/OP-TEE folks will have
a different/better solution you can simply back-port to meta-ti.

Andrew

> Thanks
> Suhaas
>>
>> Andrew
>>
>>> So ensure that this symlink is installed by explicitly adding a
>>> FILES:${PN} assignment.
>>>
>>> Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
>>> ---
>>> v3 -> v4:
>>> * I realized that libckteec.so.0* and the PKCS#11 TA file were both already installed in the SDK.
>>>     Therefore, in v4, I have removed the logic for that since its redundant now. CFG_PKCS11_TA and
>>>     CFG_REE_FS are enabled by-default.
>>> * v4 only fixes one issue: the absence of libckteec.so. /usr/bin/libckteec.so should link to
>>>     /usr/bin/libckteec.so.0 which then links to /usr/bin/libckteec.so.0.1.0.
>>> * Link to v3:
>>> https://lore.kernel.org/yocto-meta-ti/20251113104522.2443817-1-prc@list.ti.com/T/#t
>>> ---
>>>    .../recipes-security/optee/optee-client-ti-overrides.inc     | 1 +
>>>    meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend   | 5 +++++
>>>    2 files changed, 6 insertions(+)
>>>    create mode 100644 meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
>>>
>>> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
>>> new file mode 100644
>>> index 00000000..dd6a9d01
>>> --- /dev/null
>>> +++ b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
>>> @@ -0,0 +1 @@
>>> +FILES:${PN} += "${libdir}/libckteec.so*"
>>> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
>>> index f193e78b..0cee127f 100644
>>> --- a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
>>> +++ b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
>>> @@ -2,3 +2,8 @@ OPTEE_TI_VERSION = ""
>>>    OPTEE_TI_VERSION:ti-soc = "${BPN}-ti-version.inc"
>>>    require ${OPTEE_TI_VERSION}
>>> +
>>> +OPTEE_TI_OVERRIDES = ""
>>> +OPTEE_TI_OVERRIDES:ti-soc = "${BPN}-ti-overrides.inc"
>>> +
>>> +require ${OPTEE_TI_OVERRIDES}
>>>
>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> View/Reply Online (#19278): https://lists.yoctoproject.org/g/meta-ti/message/19278
>>> Mute This Topic: https://lists.yoctoproject.org/mt/116334516/3619733
>>> Group Owner: meta-ti+owner@lists.yoctoproject.org
>>> Unsubscribe: https://lists.yoctoproject.org/g/meta-ti/unsub [afd@ti.com]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>>
Denys Dmytriyenko Nov. 18, 2025, 7:01 p.m. UTC | #5 
On Mon, Nov 17, 2025 at 02:04:08PM +0530, Suhaas Joshi via lists.yoctoproject.org wrote:
> Presently, /usr/lib/libckteec.so is not installed. Instead, the only
> symlink present is /usr/lib/libckteec.so.0 which points to
> libckteec.so.0.1.0. This makes OpenSSL commands fail since it looks for
> /usr/bin/libckteec.so.
> 
> So ensure that this symlink is installed by explicitly adding a
> FILES:${PN} assignment.
> 
> Signed-off-by: Suhaas Joshi <s-joshi@ti.com>
> ---
> v3 -> v4:
> * I realized that libckteec.so.0* and the PKCS#11 TA file were both already installed in the SDK.
>   Therefore, in v4, I have removed the logic for that since its redundant now. CFG_PKCS11_TA and
>   CFG_REE_FS are enabled by-default.
> * v4 only fixes one issue: the absence of libckteec.so. /usr/bin/libckteec.so should link to
>   /usr/bin/libckteec.so.0 which then links to /usr/bin/libckteec.so.0.1.0.

NAK

This patch seems to be unnecessary.

After 4 revisions it was determined that the necessary library is getting 
built and packaged.

I just checked and all the symlinks are also getting created. In accordance 
with Distro packaging guidelines, which OE follows, the *.so file is assumed 
to be a development symlink, hence it gets packaged into a corresponding *-dev 
package.

Simply pulling *.so symlink into the main package is not the right way to 
handle it. Doing so will trigger a QA error that will require a "dev-so" flag 
in INSANE_SKIP list - while not immediately violating YP Compat requirements, 
it's still not recommended.


> * Link to v3:
> https://lore.kernel.org/yocto-meta-ti/20251113104522.2443817-1-prc@list.ti.com/T/#t
> ---
>  .../recipes-security/optee/optee-client-ti-overrides.inc     | 1 +
>  meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend   | 5 +++++
>  2 files changed, 6 insertions(+)
>  create mode 100644 meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> 
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> new file mode 100644
> index 00000000..dd6a9d01
> --- /dev/null
> +++ b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
> @@ -0,0 +1 @@
> +FILES:${PN} += "${libdir}/libckteec.so*"
> diff --git a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> index f193e78b..0cee127f 100644
> --- a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> +++ b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
> @@ -2,3 +2,8 @@ OPTEE_TI_VERSION = ""
>  OPTEE_TI_VERSION:ti-soc = "${BPN}-ti-version.inc"
>  
>  require ${OPTEE_TI_VERSION}
> +
> +OPTEE_TI_OVERRIDES = ""
> +OPTEE_TI_OVERRIDES:ti-soc = "${BPN}-ti-overrides.inc"
> +
> +require ${OPTEE_TI_OVERRIDES}
> -- 
> 2.34.1
diff mbox series

Patch

diff --git a/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
new file mode 100644
index 00000000..dd6a9d01
--- /dev/null
+++ b/meta-ti-bsp/recipes-security/optee/optee-client-ti-overrides.inc
@@ -0,0 +1 @@ 
+FILES:${PN} += "${libdir}/libckteec.so*"
diff --git a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
index f193e78b..0cee127f 100644
--- a/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
+++ b/meta-ti-bsp/recipes-security/optee/optee-client_%.bbappend
@@ -2,3 +2,8 @@  OPTEE_TI_VERSION = ""
 OPTEE_TI_VERSION:ti-soc = "${BPN}-ti-version.inc"
 
 require ${OPTEE_TI_VERSION}
+
+OPTEE_TI_OVERRIDES = ""
+OPTEE_TI_OVERRIDES:ti-soc = "${BPN}-ti-overrides.inc"
+
+require ${OPTEE_TI_OVERRIDES}