diff mbox series

[meta-oe,2/4] audiofile: add ptest support

Message ID 20251113120611.2590707-2-skandigraun@gmail.com
State Accepted
Headers show
Series [meta-oe,1/4] audiofile: patch CVE-2019-13147 and CVE-2022-24599 | expand

Commit Message

Gyorgy Sarvari Nov. 13, 2025, 12:06 p.m. UTC 
It's under 15 seconds to execute it.

Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
---
 .../include/ptest-packagelists-meta-oe.inc     |  1 +
 .../audiofile/audiofile_0.3.6.bb               | 18 +++++++++++++++++-
 .../audiofile/files/run-ptest                  | 14 ++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)
 create mode 100644 meta-oe/recipes-multimedia/audiofile/files/run-ptest

Comments

Khem Raj Nov. 13, 2025, 10:29 p.m. UTC | #1 
Its a good addition but fails to build with clang.

https://errors.yoctoproject.org/Errors/Details/888035/

On Thu, Nov 13, 2025 at 4:06 AM Gyorgy Sarvari via lists.openembedded.org
<skandigraun=gmail.com@lists.openembedded.org> wrote:

> It's under 15 seconds to execute it.
>
> Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
> ---
>  .../include/ptest-packagelists-meta-oe.inc     |  1 +
>  .../audiofile/audiofile_0.3.6.bb               | 18 +++++++++++++++++-
>  .../audiofile/files/run-ptest                  | 14 ++++++++++++++
>  3 files changed, 32 insertions(+), 1 deletion(-)
>  create mode 100644 meta-oe/recipes-multimedia/audiofile/files/run-ptest
>
> diff --git a/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> b/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> index 1d5932c315..96e0d87bd4 100644
> --- a/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> +++ b/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> @@ -8,6 +8,7 @@
>  # ptests which take less than ~30s each
>  PTESTS_FAST_META_OE = "\
>      asio \
> +    audiofile \
>      cli11 \
>      cmocka \
>      cunit \
> diff --git a/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> b/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> index fd80729bd2..f734a41dfc 100644
> --- a/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> +++ b/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=4fbd65380cdd255951079008b364516c \
>
>  SRC_URI = " \
>      ${GNOME_MIRROR}/audiofile/0.3/${BP}.tar.xz \
> +    file://run-ptest \
>      file://0001-fix-negative-shift-constants.patch \
>      file://0002-fix-build-on-gcc6.patch \
>      file://0003-fix-CVE-2015-7747.patch \
> @@ -23,7 +24,7 @@ SRC_URI = " \
>  "
>  SRC_URI[sha256sum] =
> "ea2449ad3f201ec590d811db9da6d02ffc5e87a677d06b92ab15363d8cb59782"
>
> -inherit autotools lib_package pkgconfig
> +inherit autotools lib_package pkgconfig ptest
>
>  CXXFLAGS += "-std=c++14"
>
> @@ -33,3 +34,18 @@ DEPENDS = " \
>      libogg \
>      flac \
>  "
> +
> +do_compile_ptest(){
> +    oe_runmake -C gtest libgtest.la
> +    cd test
> +    # Query the TESTS variable value, remove the $(...) parts from it,
> +    # compile as make target along with FLAC (which is an optional test)
> +    oe_runmake `make -p | grep "^TESTS = " | sed 's/$([^)]*)//g' | cut
> -d= -f2` FLAC
> +}
> +
> +do_install_ptest(){
> +    install -d ${D}${PTEST_PATH}/test
> +    for t in test/.libs/*; do
> +        install $t ${D}${PTEST_PATH}/test/
> +    done
> +}
> diff --git a/meta-oe/recipes-multimedia/audiofile/files/run-ptest
> b/meta-oe/recipes-multimedia/audiofile/files/run-ptest
> new file mode 100644
> index 0000000000..cdf1677bde
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/audiofile/files/run-ptest
> @@ -0,0 +1,14 @@
> +#!/bin/sh
> +
> +RES=0
> +cd test
> +for t in *; do
> +  if ./$t; then
> +    echo PASS: $t
> +  else
> +    echo FAIL: $t
> +    RES=1
> +  fi
> +done
> +
> +exit $RES
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#121646):
> https://lists.openembedded.org/g/openembedded-devel/message/121646
> Mute This Topic: https://lists.openembedded.org/mt/116272850/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
Khem Raj Nov. 14, 2025, 1:38 a.m. UTC | #2 
I have send a patch that makes clang happy. Please test it out and let me
know
secondly the run-ptest script has trailing white-spaces, please delete them
in v2 series.

On Thu, Nov 13, 2025 at 4:06 AM Gyorgy Sarvari via lists.openembedded.org
<skandigraun=gmail.com@lists.openembedded.org> wrote:

> It's under 15 seconds to execute it.
>
> Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
> ---
>  .../include/ptest-packagelists-meta-oe.inc     |  1 +
>  .../audiofile/audiofile_0.3.6.bb               | 18 +++++++++++++++++-
>  .../audiofile/files/run-ptest                  | 14 ++++++++++++++
>  3 files changed, 32 insertions(+), 1 deletion(-)
>  create mode 100644 meta-oe/recipes-multimedia/audiofile/files/run-ptest
>
> diff --git a/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> b/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> index 1d5932c315..96e0d87bd4 100644
> --- a/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> +++ b/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
> @@ -8,6 +8,7 @@
>  # ptests which take less than ~30s each
>  PTESTS_FAST_META_OE = "\
>      asio \
> +    audiofile \
>      cli11 \
>      cmocka \
>      cunit \
> diff --git a/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> b/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> index fd80729bd2..f734a41dfc 100644
> --- a/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> +++ b/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
> @@ -10,6 +10,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=4fbd65380cdd255951079008b364516c \
>
>  SRC_URI = " \
>      ${GNOME_MIRROR}/audiofile/0.3/${BP}.tar.xz \
> +    file://run-ptest \
>      file://0001-fix-negative-shift-constants.patch \
>      file://0002-fix-build-on-gcc6.patch \
>      file://0003-fix-CVE-2015-7747.patch \
> @@ -23,7 +24,7 @@ SRC_URI = " \
>  "
>  SRC_URI[sha256sum] =
> "ea2449ad3f201ec590d811db9da6d02ffc5e87a677d06b92ab15363d8cb59782"
>
> -inherit autotools lib_package pkgconfig
> +inherit autotools lib_package pkgconfig ptest
>
>  CXXFLAGS += "-std=c++14"
>
> @@ -33,3 +34,18 @@ DEPENDS = " \
>      libogg \
>      flac \
>  "
> +
> +do_compile_ptest(){
> +    oe_runmake -C gtest libgtest.la
> +    cd test
> +    # Query the TESTS variable value, remove the $(...) parts from it,
> +    # compile as make target along with FLAC (which is an optional test)
> +    oe_runmake `make -p | grep "^TESTS = " | sed 's/$([^)]*)//g' | cut
> -d= -f2` FLAC
> +}
> +
> +do_install_ptest(){
> +    install -d ${D}${PTEST_PATH}/test
> +    for t in test/.libs/*; do
> +        install $t ${D}${PTEST_PATH}/test/
> +    done
> +}
> diff --git a/meta-oe/recipes-multimedia/audiofile/files/run-ptest
> b/meta-oe/recipes-multimedia/audiofile/files/run-ptest
> new file mode 100644
> index 0000000000..cdf1677bde
> --- /dev/null
> +++ b/meta-oe/recipes-multimedia/audiofile/files/run-ptest
> @@ -0,0 +1,14 @@
> +#!/bin/sh
> +
> +RES=0
> +cd test
> +for t in *; do
> +  if ./$t; then
> +    echo PASS: $t
> +  else
> +    echo FAIL: $t
> +    RES=1
> +  fi
> +done
> +
> +exit $RES
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#121646):
> https://lists.openembedded.org/g/openembedded-devel/message/121646
> Mute This Topic: https://lists.openembedded.org/mt/116272850/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [
> raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
diff mbox series

Patch

diff --git a/meta-oe/conf/include/ptest-packagelists-meta-oe.inc b/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
index 1d5932c315..96e0d87bd4 100644
--- a/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
+++ b/meta-oe/conf/include/ptest-packagelists-meta-oe.inc
@@ -8,6 +8,7 @@ 
 # ptests which take less than ~30s each
 PTESTS_FAST_META_OE = "\
     asio \
+    audiofile \
     cli11 \
     cmocka \
     cunit \
diff --git a/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb b/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
index fd80729bd2..f734a41dfc 100644
--- a/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
+++ b/meta-oe/recipes-multimedia/audiofile/audiofile_0.3.6.bb
@@ -10,6 +10,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c \
 
 SRC_URI = " \
     ${GNOME_MIRROR}/audiofile/0.3/${BP}.tar.xz \
+    file://run-ptest \
     file://0001-fix-negative-shift-constants.patch \
     file://0002-fix-build-on-gcc6.patch \
     file://0003-fix-CVE-2015-7747.patch \
@@ -23,7 +24,7 @@  SRC_URI = " \
 "
 SRC_URI[sha256sum] = "ea2449ad3f201ec590d811db9da6d02ffc5e87a677d06b92ab15363d8cb59782"
 
-inherit autotools lib_package pkgconfig
+inherit autotools lib_package pkgconfig ptest
 
 CXXFLAGS += "-std=c++14"
 
@@ -33,3 +34,18 @@  DEPENDS = " \
     libogg \
     flac \
 "
+
+do_compile_ptest(){
+    oe_runmake -C gtest libgtest.la
+    cd test
+    # Query the TESTS variable value, remove the $(...) parts from it,
+    # compile as make target along with FLAC (which is an optional test)
+    oe_runmake `make -p | grep "^TESTS = " | sed 's/$([^)]*)//g' | cut -d= -f2` FLAC
+}
+
+do_install_ptest(){
+    install -d ${D}${PTEST_PATH}/test
+    for t in test/.libs/*; do
+        install $t ${D}${PTEST_PATH}/test/
+    done
+}
diff --git a/meta-oe/recipes-multimedia/audiofile/files/run-ptest b/meta-oe/recipes-multimedia/audiofile/files/run-ptest
new file mode 100644
index 0000000000..cdf1677bde
--- /dev/null
+++ b/meta-oe/recipes-multimedia/audiofile/files/run-ptest
@@ -0,0 +1,14 @@ 
+#!/bin/sh
+
+RES=0
+cd test
+for t in *; do
+  if ./$t; then                                          
+    echo PASS: $t                          
+  else                                     
+    echo FAIL: $t                          
+    RES=1                                  
+  fi                                       
+done                                       
+                                           
+exit $RES