diff mbox series

go-helloworld: fix license

Message ID 20251113081148.32411-1-peter.marko@siemens.com
State New
Headers show
Series go-helloworld: fix license | expand

Commit Message

Marko, Peter Nov. 13, 2025, 8:11 a.m. UTC
From: Peter Marko <peter.marko@siemens.com>

The example repo doesn't seem to have ever been under MIT.
It started with Apache-2.0, later changed to standard go license BSD-3.

The license file exists in the sources, so use that one instead of
taking it from the OE-Core license directory.

Note that this was already fixed in scarthgap and kirkstone, but it was
not submitted to master. Also the old releases still had Apache, so this
patch is different now with new versioni of thie component.

License-Update: Fix license declaration.

Signed-off-by: Peter Marko <peter.marko@siemens.com>
---
 meta/recipes-extended/go-examples/go-helloworld_0.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Quentin Schulz Nov. 13, 2025, 9:52 a.m. UTC | #1
Hi Peter,

On 11/13/25 9:11 AM, Peter Marko via lists.openembedded.org wrote:
> From: Peter Marko <peter.marko@siemens.com>
> 
> The example repo doesn't seem to have ever been under MIT.
> It started with Apache-2.0, later changed to standard go license BSD-3.
> 
> The license file exists in the sources, so use that one instead of
> taking it from the OE-Core license directory.
> 
> Note that this was already fixed in scarthgap and kirkstone, but it was
> not submitted to master. Also the old releases still had Apache, so this
> patch is different now with new versioni of thie component.
> 

It was submitted for master/walnascar but never merged:

https://lore.kernel.org/openembedded-core/20250812-go-helloworld-lic-v1-1-07ce00a0f252@cherry.de/

Cheers,
Quentin
Marko, Peter Nov. 13, 2025, 10:31 a.m. UTC | #2
> -----Original Message-----
> From: Quentin Schulz <quentin.schulz@cherry.de>
> Sent: Thursday, November 13, 2025 10:52
> To: Marko, Peter (FT D EU SK BFS1) <Peter.Marko@siemens.com>;
> openembedded-core@lists.openembedded.org
> Subject: Re: [OE-core][PATCH] go-helloworld: fix license
> 
> Hi Peter,
> 
> On 11/13/25 9:11 AM, Peter Marko via lists.openembedded.org wrote:
> > From: Peter Marko <peter.marko@siemens.com>
> >
> > The example repo doesn't seem to have ever been under MIT.
> > It started with Apache-2.0, later changed to standard go license BSD-3.
> >
> > The license file exists in the sources, so use that one instead of
> > taking it from the OE-Core license directory.
> >
> > Note that this was already fixed in scarthgap and kirkstone, but it was
> > not submitted to master. Also the old releases still had Apache, so this
> > patch is different now with new versioni of thie component.
> >
> 
> It was submitted for master/walnascar but never merged:
> 
> https://lore.kernel.org/openembedded-core/20250812-go-helloworld-lic-v1-1-
> 07ce00a0f252@cherry.de/

OK, sorry, I'll send a v2 with updated comment.
Peter

> 
> Cheers,
> Quentin
Quentin Schulz Nov. 13, 2025, 10:34 a.m. UTC | #3
Hi Peter,

On 11/13/25 11:31 AM, Peter Marko via lists.openembedded.org wrote:
> 
> 
>> -----Original Message-----
>> From: Quentin Schulz <quentin.schulz@cherry.de>
>> Sent: Thursday, November 13, 2025 10:52
>> To: Marko, Peter (FT D EU SK BFS1) <Peter.Marko@siemens.com>;
>> openembedded-core@lists.openembedded.org
>> Subject: Re: [OE-core][PATCH] go-helloworld: fix license
>>
>> Hi Peter,
>>
>> On 11/13/25 9:11 AM, Peter Marko via lists.openembedded.org wrote:
>>> From: Peter Marko <peter.marko@siemens.com>
>>>
>>> The example repo doesn't seem to have ever been under MIT.
>>> It started with Apache-2.0, later changed to standard go license BSD-3.
>>>
>>> The license file exists in the sources, so use that one instead of
>>> taking it from the OE-Core license directory.
>>>
>>> Note that this was already fixed in scarthgap and kirkstone, but it was
>>> not submitted to master. Also the old releases still had Apache, so this
>>> patch is different now with new versioni of thie component.
>>>
>>
>> It was submitted for master/walnascar but never merged:
>>
>> https://lore.kernel.org/openembedded-core/20250812-go-helloworld-lic-v1-1-
>> 07ce00a0f252@cherry.de/
> 
> OK, sorry, I'll send a v2 with updated comment.

No need to.

Just don't know why it wasn't picked up in the first place (the unusual 
[master walnascar] probably escaped some human or software filtering :) )

And then I forgot to ping :)

Cheers,
Quentin
diff mbox series

Patch

diff --git a/meta/recipes-extended/go-examples/go-helloworld_0.1.bb b/meta/recipes-extended/go-examples/go-helloworld_0.1.bb
index e12dcb15f6..0a8668dd4d 100644
--- a/meta/recipes-extended/go-examples/go-helloworld_0.1.bb
+++ b/meta/recipes-extended/go-examples/go-helloworld_0.1.bb
@@ -2,8 +2,8 @@  SUMMARY = "This is a simple example recipe that cross-compiles a Go program."
 SECTION = "examples"
 HOMEPAGE = "https://golang.org/"
 
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/MIT;md5=0835ade698e0bcf8506ecda2f7b4f302"
+LICENSE = "BSD-3-Clause"
+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=7998cb338f82d15c0eff93b7004d272a"
 
 SRC_URI = "git://go.googlesource.com/example;branch=master;protocol=https;destsuffix=${GO_SRCURI_DESTSUFFIX}"
 SRCREV = "8b405629c4a5215871be932097e099c05ec5cb2e"