diff mbox series

arm/oeqa/fvp: update for new ignore_ssh_fails argument to run()

Message ID 20251012104900.2505243-1-ross.burton@arm.com
State New
Headers show
Series arm/oeqa/fvp: update for new ignore_ssh_fails argument to run() | expand

Commit Message

Ross Burton Oct. 12, 2025, 10:49 a.m. UTC
The OESSHTarget object now has a ignore_ssh_fails keyword argument[1],
so update this subclass to match.

As the implementation of run() here simply forwards the arguments, we
can use *args, **kwargs so that future changes don't cause problems.

[1] oe-core afe118d4f2d ("oeqa: target: ssh: Fail on SSH error even when errors are ignored")

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta-arm/lib/oeqa/controllers/fvp.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jon Mason Oct. 17, 2025, 1:03 p.m. UTC | #1
On Sun, 12 Oct 2025 11:49:00 +0100, Ross Burton wrote:
> The OESSHTarget object now has a ignore_ssh_fails keyword argument[1],
> so update this subclass to match.
> 
> As the implementation of run() here simply forwards the arguments, we
> can use *args, **kwargs so that future changes don't cause problems.
> 
> [1] oe-core afe118d4f2d ("oeqa: target: ssh: Fail on SSH error even when errors are ignored")
> 
> [...]

Applied, thanks!

[1/1] arm/oeqa/fvp: update for new ignore_ssh_fails argument to run()
      commit: 595e4a439a93fc16e22236dba577575b18272675

Best regards,
diff mbox series

Patch

diff --git a/meta-arm/lib/oeqa/controllers/fvp.py b/meta-arm/lib/oeqa/controllers/fvp.py
index dddc10ee3a..9ded121321 100644
--- a/meta-arm/lib/oeqa/controllers/fvp.py
+++ b/meta-arm/lib/oeqa/controllers/fvp.py
@@ -76,10 +76,10 @@  class OEFVPTarget(OESSHTarget):
     def stop(self, **kwargs):
         self.transition(OEFVPTargetState.OFF)
 
-    def run(self, cmd, timeout=None):
+    def run(self, *args, **kwargs):
         # Running a command implies the LINUX state
         self.transition(OEFVPTargetState.LINUX)
-        return super().run(cmd, timeout)
+        return super().run(*args, **kwargs)
 
     def _setup_consoles(self):
         with open(self.fvp_log.name, 'rb') as logfile: