| Message ID | fefec75a-d849-430a-a503-1369dee54671@gmail.com |
|---|---|
| State | Rejected |
| Delegated to: | Steve Sakoman |
| Headers | show |
| Series | [scarthgap] vim: fix xxd-native RPROVIDES | expand |
On Sun, Sep 28, 2025 at 9:14 AM Clayton Casciato <majortomtosourcecontrol@gmail.com> wrote: > > BBCLASSEXTEND doesn't handle overrides with suffixed ${PN} for > native class, e.g.: > > RPROVIDES:${PN}-xxd = "xxd" > > becomes: > > RPROVIDES:vim-native-xxd = "xxd-native" > > instead of: > > RPROVIDES:vim-xxd-native = "xxd-native" > > This results in "Nothing RPROVIDES xxd-native" error when > something RDEPENDS on xxd-native because there's no such > package as vim-native-xxd. > > Use ${BPN} and explicitly handle RPROVIDES. > > Since native class does not produce packages, other variables > using :${PN}-xxd override don't matter. And nativesdk class > is not affected, as it uses a prefix, not suffix. > > Signed-off-by: Denys Dmytriyenko <denys@konsulko.com> > Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com> > --- > Sponsor: 21SoftWare LLC > > Patch from: > https://lists.openembedded.org/g/openembedded-core/topic/109930389 Richard rejected this patch for master in the above thread, so I can't take it for a stable release. Steve > > Walnascar: > e2fd81e221c2 ("native: Improve ${PN}-XXX package name handling") > > meta/recipes-support/vim/vim_9.1.bb | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/meta/recipes-support/vim/vim_9.1.bb b/meta/recipes-support/vim/vim_9.1.bb > index fee9f055e9..8968b8cb07 100644 > --- a/meta/recipes-support/vim/vim_9.1.bb > +++ b/meta/recipes-support/vim/vim_9.1.bb > @@ -11,7 +11,9 @@ BBCLASSEXTEND = "native nativesdk" > > PACKAGES =+ "${PN}-xxd" > FILES:${PN}-xxd = "${bindir}/xxd" > -RPROVIDES:${PN}-xxd = "xxd" > +RPROVIDES:${BPN}-xxd = "xxd" > +RPROVIDES:${BPN}-xxd-native = "xxd-native" > +RPROVIDES:nativesdk-${BPN}-xxd = "nativesdk-xxd" > > ALTERNATIVE:${PN}-xxd = "xxd" > ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
diff --git a/meta/recipes-support/vim/vim_9.1.bb b/meta/recipes-support/vim/vim_9.1.bb index fee9f055e9..8968b8cb07 100644 --- a/meta/recipes-support/vim/vim_9.1.bb +++ b/meta/recipes-support/vim/vim_9.1.bb @@ -11,7 +11,9 @@ BBCLASSEXTEND = "native nativesdk" PACKAGES =+ "${PN}-xxd" FILES:${PN}-xxd = "${bindir}/xxd" -RPROVIDES:${PN}-xxd = "xxd" +RPROVIDES:${BPN}-xxd = "xxd" +RPROVIDES:${BPN}-xxd-native = "xxd-native" +RPROVIDES:nativesdk-${BPN}-xxd = "nativesdk-xxd" ALTERNATIVE:${PN}-xxd = "xxd" ALTERNATIVE_TARGET[xxd] = "${bindir}/xxd"
BBCLASSEXTEND doesn't handle overrides with suffixed ${PN} for native class, e.g.: RPROVIDES:${PN}-xxd = "xxd" becomes: RPROVIDES:vim-native-xxd = "xxd-native" instead of: RPROVIDES:vim-xxd-native = "xxd-native" This results in "Nothing RPROVIDES xxd-native" error when something RDEPENDS on xxd-native because there's no such package as vim-native-xxd. Use ${BPN} and explicitly handle RPROVIDES. Since native class does not produce packages, other variables using :${PN}-xxd override don't matter. And nativesdk class is not affected, as it uses a prefix, not suffix. Signed-off-by: Denys Dmytriyenko <denys@konsulko.com> Signed-off-by: Clayton Casciato <majortomtosourcecontrol@gmail.com> --- Sponsor: 21SoftWare LLC Patch from: https://lists.openembedded.org/g/openembedded-core/topic/109930389 Walnascar: e2fd81e221c2 ("native: Improve ${PN}-XXX package name handling") meta/recipes-support/vim/vim_9.1.bb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)