| Message ID | 20250926081914.3127272-1-hongxu.jia@windriver.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [meta-python,v4,1/6] python3-frozenlist: support reproducibility | expand |
On 9/26/25 1:19 AM, hongxu via lists.openembedded.org wrote: > In order to make the generated library be reproducible, build wheel > in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's > option -fdebug-prefix-map could work as expected > > Note: To support reproducibility, it also requires oe-core commit [1] to be merged > > [1] https://git.openembedded.org/openembedded-core/commit/?id=61d98d12eca1c7bdf3b7387a820c83d3b8fad965 > > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > --- > .../0001-build-wheel-in-place.patch | 31 +++++++++++++++++++ > .../python/python3-frozenlist_1.7.0.bb | 3 ++ > 2 files changed, 34 insertions(+) > create mode 100644 meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > > diff --git a/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > new file mode 100644 > index 0000000000..84f81da775 > --- /dev/null > +++ b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > @@ -0,0 +1,31 @@ > +From 606843ad079d9d0dac1172533d42b5a2327b99ed Mon Sep 17 00:00:00 2001 > +From: Hongxu Jia <hongxu.jia@windriver.com> > +Date: Wed, 17 Sep 2025 15:41:09 +0800 > +Subject: [PATCH] build wheel in place > + > +In order to make the generated library be reproducible, build wheel > +in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's > +option -fdebug-prefix-map could work as expected > + > +Upstream-Status: Pending This is worth submitting upstream. > +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > +--- > + packaging/pep517_backend/_backend.py | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/packaging/pep517_backend/_backend.py b/packaging/pep517_backend/_backend.py > +index 61cad34..d5d839e 100644 > +--- a/packaging/pep517_backend/_backend.py > ++++ b/packaging/pep517_backend/_backend.py > +@@ -316,7 +316,7 @@ def build_wheel( > + """ > + with maybe_prebuild_c_extensions( > + line_trace_cython_when_unset=False, > +- build_inplace=False, > ++ build_inplace=True, > + config_settings=config_settings, > + ): > + return _setuptools_build_wheel( > +-- > +2.34.1 > + > diff --git a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb > index 7d813a026c..d832494c82 100644 > --- a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb > +++ b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb > @@ -7,6 +7,9 @@ SRC_URI[sha256sum] = "2e310d81923c2437ea8670467121cc3e9b0f76d3043cc1d2331d56c7fb > > inherit pypi python_setuptools_build_meta cython > > +SRC_URI += " \ > + file://0001-build-wheel-in-place.patch \ > +" > DEPENDS += " \ > python3-expandvars-native \ > " > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#119899): https://lists.openembedded.org/g/openembedded-devel/message/119899 > Mute This Topic: https://lists.openembedded.org/mt/115445260/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- >
Ooh I knew I remembered the frozenlist name from somewhere. FWIW, there’s an upstream ticket for this issue: https://github.com/aio-libs/frozenlist/issues/577. And I filed https://github.com/aio-libs/yarl/issues/1551 which is related. Ross > On 26 Sep 2025, at 18:10, Khem Raj via lists.openembedded.org <raj.khem=gmail.com@lists.openembedded.org> wrote: > > > > On 9/26/25 1:19 AM, hongxu via lists.openembedded.org wrote: >> In order to make the generated library be reproducible, build wheel >> in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's >> option -fdebug-prefix-map could work as expected >> Note: To support reproducibility, it also requires oe-core commit [1] to be merged >> [1] https://git.openembedded.org/openembedded-core/commit/?id=61d98d12eca1c7bdf3b7387a820c83d3b8fad965 >> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> >> --- >> .../0001-build-wheel-in-place.patch | 31 +++++++++++++++++++ >> .../python/python3-frozenlist_1.7.0.bb | 3 ++ >> 2 files changed, 34 insertions(+) >> create mode 100644 meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch >> diff --git a/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch >> new file mode 100644 >> index 0000000000..84f81da775 >> --- /dev/null >> +++ b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch >> @@ -0,0 +1,31 @@ >> +From 606843ad079d9d0dac1172533d42b5a2327b99ed Mon Sep 17 00:00:00 2001 >> +From: Hongxu Jia <hongxu.jia@windriver.com> >> +Date: Wed, 17 Sep 2025 15:41:09 +0800 >> +Subject: [PATCH] build wheel in place >> + >> +In order to make the generated library be reproducible, build wheel >> +in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's >> +option -fdebug-prefix-map could work as expected >> + >> +Upstream-Status: Pending > > This is worth submitting upstream. > >> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> >> +--- >> + packaging/pep517_backend/_backend.py | 2 +- >> + 1 file changed, 1 insertion(+), 1 deletion(-) >> + >> +diff --git a/packaging/pep517_backend/_backend.py b/packaging/pep517_backend/_backend.py >> +index 61cad34..d5d839e 100644 >> +--- a/packaging/pep517_backend/_backend.py >> ++++ b/packaging/pep517_backend/_backend.py >> +@@ -316,7 +316,7 @@ def build_wheel( >> + """ >> + with maybe_prebuild_c_extensions( >> + line_trace_cython_when_unset=False, >> +- build_inplace=False, >> ++ build_inplace=True, >> + config_settings=config_settings, >> + ): >> + return _setuptools_build_wheel( >> +-- >> +2.34.1 >> + >> diff --git a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb >> index 7d813a026c..d832494c82 100644 >> --- a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb >> +++ b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb >> @@ -7,6 +7,9 @@ SRC_URI[sha256sum] = "2e310d81923c2437ea8670467121cc3e9b0f76d3043cc1d2331d56c7fb >> inherit pypi python_setuptools_build_meta cython >> +SRC_URI += " \ >> + file://0001-build-wheel-in-place.patch \ >> +" >> DEPENDS += " \ >> python3-expandvars-native \ >> " > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#119935): https://lists.openembedded.org/g/openembedded-devel/message/119935 > Mute This Topic: https://lists.openembedded.org/mt/115445260/6875888 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ross.burton@arm.com] > -=-=-=-=-=-=-=-=-=-=-=- >
On Fri, Sep 26, 2025 at 12:51 PM Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> wrote: > Ooh I knew I remembered the frozenlist name from somewhere. > > FWIW, there’s an upstream ticket for this issue: > https://github.com/aio-libs/frozenlist/issues/577. And I filed > https://github.com/aio-libs/yarl/issues/1551 which is related. > > Ross > > > On 26 Sep 2025, at 18:10, Khem Raj via lists.openembedded.org <raj.khem= > gmail.com@lists.openembedded.org> wrote: > > > > > > > > On 9/26/25 1:19 AM, hongxu via lists.openembedded.org wrote: > >> In order to make the generated library be reproducible, build wheel > >> in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's > >> option -fdebug-prefix-map could work as expected Thank you! > > >> Note: To support reproducibility, it also requires oe-core commit [1] > to be merged > >> [1] > https://git.openembedded.org/openembedded-core/commit/?id=61d98d12eca1c7bdf3b7387a820c83d3b8fad965 > >> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > >> --- > >> .../0001-build-wheel-in-place.patch | 31 +++++++++++++++++++ > >> .../python/python3-frozenlist_1.7.0.bb | 3 ++ > >> 2 files changed, 34 insertions(+) > >> create mode 100644 > meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > >> diff --git > a/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > >> new file mode 100644 > >> index 0000000000..84f81da775 > >> --- /dev/null > >> +++ > b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch > >> @@ -0,0 +1,31 @@ > >> +From 606843ad079d9d0dac1172533d42b5a2327b99ed Mon Sep 17 00:00:00 2001 > >> +From: Hongxu Jia <hongxu.jia@windriver.com> > >> +Date: Wed, 17 Sep 2025 15:41:09 +0800 > >> +Subject: [PATCH] build wheel in place > >> + > >> +In order to make the generated library be reproducible, build wheel > >> +in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's > >> +option -fdebug-prefix-map could work as expected > >> + > >> +Upstream-Status: Pending I agree with Khem. This is worth submitting upstream. Also, I would STRONGLY advise we stop using “Pending”. Let us do the work to do an MVP submission upstream and point to that. ANY kind of messaging upstream is a step towards the right direction. The reason is we actually tend to never follow through and submit. This will begin to bite us with the new world of CRA. > > > > > This is worth submitting upstream. > > > >> +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> > >> +--- > >> + packaging/pep517_backend/_backend.py | 2 +- > >> + 1 file changed, 1 insertion(+), 1 deletion(-) > >> + > >> +diff --git a/packaging/pep517_backend/_backend.py > b/packaging/pep517_backend/_backend.py > >> +index 61cad34..d5d839e 100644 > >> +--- a/packaging/pep517_backend/_backend.py > >> ++++ b/packaging/pep517_backend/_backend.py > >> +@@ -316,7 +316,7 @@ def build_wheel( > >> + """ > >> + with maybe_prebuild_c_extensions( > >> + line_trace_cython_when_unset=False, > >> +- build_inplace=False, > >> ++ build_inplace=True, > >> + config_settings=config_settings, > >> + ): > >> + return _setuptools_build_wheel( > >> +-- > >> +2.34.1 > >> + > >> diff --git a/meta-python/recipes-devtools/python/ > python3-frozenlist_1.7.0.bb b/meta-python/recipes-devtools/python/ > python3-frozenlist_1.7.0.bb > >> index 7d813a026c..d832494c82 100644 > >> --- a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb > >> +++ b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb > >> @@ -7,6 +7,9 @@ SRC_URI[sha256sum] = > "2e310d81923c2437ea8670467121cc3e9b0f76d3043cc1d2331d56c7fb > >> inherit pypi python_setuptools_build_meta cython > >> +SRC_URI += " \ > >> + file://0001-build-wheel-in-place.patch \ > >> +" > >> DEPENDS += " \ > >> python3-expandvars-native \ > >> " > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#119938): > https://lists.openembedded.org/g/openembedded-devel/message/119938 > Mute This Topic: https://lists.openembedded.org/mt/115445260/924729 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [ > ticotimo@gmail.com] > -=-=-=-=-=-=-=-=-=-=-=- > >
diff --git a/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch new file mode 100644 index 0000000000..84f81da775 --- /dev/null +++ b/meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch @@ -0,0 +1,31 @@ +From 606843ad079d9d0dac1172533d42b5a2327b99ed Mon Sep 17 00:00:00 2001 +From: Hongxu Jia <hongxu.jia@windriver.com> +Date: Wed, 17 Sep 2025 15:41:09 +0800 +Subject: [PATCH] build wheel in place + +In order to make the generated library be reproducible, build wheel +in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's +option -fdebug-prefix-map could work as expected + +Upstream-Status: Pending +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> +--- + packaging/pep517_backend/_backend.py | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/packaging/pep517_backend/_backend.py b/packaging/pep517_backend/_backend.py +index 61cad34..d5d839e 100644 +--- a/packaging/pep517_backend/_backend.py ++++ b/packaging/pep517_backend/_backend.py +@@ -316,7 +316,7 @@ def build_wheel( + """ + with maybe_prebuild_c_extensions( + line_trace_cython_when_unset=False, +- build_inplace=False, ++ build_inplace=True, + config_settings=config_settings, + ): + return _setuptools_build_wheel( +-- +2.34.1 + diff --git a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb index 7d813a026c..d832494c82 100644 --- a/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb +++ b/meta-python/recipes-devtools/python/python3-frozenlist_1.7.0.bb @@ -7,6 +7,9 @@ SRC_URI[sha256sum] = "2e310d81923c2437ea8670467121cc3e9b0f76d3043cc1d2331d56c7fb inherit pypi python_setuptools_build_meta cython +SRC_URI += " \ + file://0001-build-wheel-in-place.patch \ +" DEPENDS += " \ python3-expandvars-native \ "
In order to make the generated library be reproducible, build wheel in source dir other than tmp dir (/tmp/xxxxxx), then yocto toolchain's option -fdebug-prefix-map could work as expected Note: To support reproducibility, it also requires oe-core commit [1] to be merged [1] https://git.openembedded.org/openembedded-core/commit/?id=61d98d12eca1c7bdf3b7387a820c83d3b8fad965 Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> --- .../0001-build-wheel-in-place.patch | 31 +++++++++++++++++++ .../python/python3-frozenlist_1.7.0.bb | 3 ++ 2 files changed, 34 insertions(+) create mode 100644 meta-python/recipes-devtools/python/python3-frozenlist/0001-build-wheel-in-place.patch