diff mbox series

[meta-oe,v2,1/6] ocl-icd, opencl-icd-loader: drop RPROVIDES for virtual-opencl-icd

Message ID 20250918014442.1436475-1-dmitry.baryshkov@oss.qualcomm.com
State New
Headers show
Series [meta-oe,v2,1/6] ocl-icd, opencl-icd-loader: drop RPROVIDES for virtual-opencl-icd | expand

Commit Message

Dmitry Baryshkov Sept. 18, 2025, 1:44 a.m. UTC 
These two packages don't provide ICD drivers at runtime. They provide
the libOpenCL.so.1. Corresponding package is selected at the build time
via the PROVIDES_virtual/opencl-icd. Drop the useless and incorrect
RPROVIDES for virtual-opencl-icd.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 meta-oe/conf/layer.conf                                     | 1 -
 meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb                | 1 -
 meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb | 2 --
 3 files changed, 4 deletions(-)

Comments

Khem Raj Sept. 18, 2025, 3:02 a.m. UTC | #1 
Hi Dmitry

Thanks for v2, it looks more complete. Sadly, it does not apply for
me. It will be helpful if you rebase it on master-next and resend

Thanks
-Khem


On Wed, Sep 17, 2025 at 6:44 PM Dmitry Baryshkov via
lists.openembedded.org
<dmitry.baryshkov=oss.qualcomm.com@lists.openembedded.org> wrote:
>
> These two packages don't provide ICD drivers at runtime. They provide
> the libOpenCL.so.1. Corresponding package is selected at the build time
> via the PROVIDES_virtual/opencl-icd. Drop the useless and incorrect
> RPROVIDES for virtual-opencl-icd.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  meta-oe/conf/layer.conf                                     | 1 -
>  meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb                | 1 -
>  meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb | 2 --
>  3 files changed, 4 deletions(-)
>
> diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf
> index bddfabc2195b..2f3da6170e89 100644
> --- a/meta-oe/conf/layer.conf
> +++ b/meta-oe/conf/layer.conf
> @@ -59,7 +59,6 @@ PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf"
>  # Configures whether coreutils or uutils-coreutils is used.
>  PREFERRED_PROVIDER_coreutils = "coreutils"
>  PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader"
> -PREFERRED_RPROVIDER_virtual-opencl-icd ?= "opencl-icd-loader"
>  PREFERRED_RPROVIDER_virtual-redis ?= "redis"
>
>  SIGGEN_EXCLUDERECIPES_ABISAFE += " \
> diff --git a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
> index 9e32242e3151..b266d6af6d91 100644
> --- a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
> +++ b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
> @@ -14,6 +14,5 @@ inherit autotools
>
>  DEPENDS = "ruby-native"
>  PROVIDES = "virtual/opencl-icd"
> -RPROVIDES:${PN} = "virtual-opencl-icd"
>
>  BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb b/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
> index 2ff9a6ae7ea5..d5337af8e5fb 100644
> --- a/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
> +++ b/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
> @@ -9,8 +9,6 @@ inherit pkgconfig cmake
>  DEPENDS += "opencl-headers"
>
>  PROVIDES = "virtual/opencl-icd"
> -RPROVIDES:${PN} = "virtual-opencl-icd"
> -
>
>  SRCREV = "861b68b290e76d08e7241608479c16431f529945"
>  SRC_URI = "git://github.com/KhronosGroup/OpenCL-ICD-Loader.git;branch=main;protocol=https"
> --
> 2.47.3
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#119491): https://lists.openembedded.org/g/openembedded-devel/message/119491
> Mute This Topic: https://lists.openembedded.org/mt/115303503/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Dmitry Baryshkov Sept. 18, 2025, 3:05 a.m. UTC | #2 
On 18/09/2025 06:02, Khem Raj wrote:
> Hi Dmitry
> 
> Thanks for v2, it looks more complete. Sadly, it does not apply for
> me. It will be helpful if you rebase it on master-next and resend

Sure, I've send v3 based on master-next.

> 
> Thanks
> -Khem
> 
> 
> On Wed, Sep 17, 2025 at 6:44 PM Dmitry Baryshkov via
> lists.openembedded.org
> <dmitry.baryshkov=oss.qualcomm.com@lists.openembedded.org> wrote:
>>
>> These two packages don't provide ICD drivers at runtime. They provide
>> the libOpenCL.so.1. Corresponding package is selected at the build time
>> via the PROVIDES_virtual/opencl-icd. Drop the useless and incorrect
>> RPROVIDES for virtual-opencl-icd.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>>   meta-oe/conf/layer.conf                                     | 1 -
>>   meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb                | 1 -
>>   meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb | 2 --
>>   3 files changed, 4 deletions(-)
>>
>> diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf
>> index bddfabc2195b..2f3da6170e89 100644
>> --- a/meta-oe/conf/layer.conf
>> +++ b/meta-oe/conf/layer.conf
>> @@ -59,7 +59,6 @@ PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf"
>>   # Configures whether coreutils or uutils-coreutils is used.
>>   PREFERRED_PROVIDER_coreutils = "coreutils"
>>   PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader"
>> -PREFERRED_RPROVIDER_virtual-opencl-icd ?= "opencl-icd-loader"
>>   PREFERRED_RPROVIDER_virtual-redis ?= "redis"
>>
>>   SIGGEN_EXCLUDERECIPES_ABISAFE += " \
>> diff --git a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
>> index 9e32242e3151..b266d6af6d91 100644
>> --- a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
>> +++ b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
>> @@ -14,6 +14,5 @@ inherit autotools
>>
>>   DEPENDS = "ruby-native"
>>   PROVIDES = "virtual/opencl-icd"
>> -RPROVIDES:${PN} = "virtual-opencl-icd"
>>
>>   BBCLASSEXTEND = "native nativesdk"
>> diff --git a/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb b/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
>> index 2ff9a6ae7ea5..d5337af8e5fb 100644
>> --- a/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
>> +++ b/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
>> @@ -9,8 +9,6 @@ inherit pkgconfig cmake
>>   DEPENDS += "opencl-headers"
>>
>>   PROVIDES = "virtual/opencl-icd"
>> -RPROVIDES:${PN} = "virtual-opencl-icd"
>> -
>>
>>   SRCREV = "861b68b290e76d08e7241608479c16431f529945"
>>   SRC_URI = "git://github.com/KhronosGroup/OpenCL-ICD-Loader.git;branch=main;protocol=https"
>> --
>> 2.47.3
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#119491): https://lists.openembedded.org/g/openembedded-devel/message/119491
>> Mute This Topic: https://lists.openembedded.org/mt/115303503/1997914
>> Group Owner: openembedded-devel+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
diff mbox series

Patch

diff --git a/meta-oe/conf/layer.conf b/meta-oe/conf/layer.conf
index bddfabc2195b..2f3da6170e89 100644
--- a/meta-oe/conf/layer.conf
+++ b/meta-oe/conf/layer.conf
@@ -59,7 +59,6 @@  PREFERRED_PROVIDER_android-tools-conf ?= "android-tools-conf"
 # Configures whether coreutils or uutils-coreutils is used.
 PREFERRED_PROVIDER_coreutils = "coreutils"
 PREFERRED_PROVIDER_virtual/opencl-icd ?= "opencl-icd-loader"
-PREFERRED_RPROVIDER_virtual-opencl-icd ?= "opencl-icd-loader"
 PREFERRED_RPROVIDER_virtual-redis ?= "redis"
 
 SIGGEN_EXCLUDERECIPES_ABISAFE += " \
diff --git a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
index 9e32242e3151..b266d6af6d91 100644
--- a/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
+++ b/meta-oe/recipes-core/opencl/ocl-icd_2.3.2.bb
@@ -14,6 +14,5 @@  inherit autotools
 
 DEPENDS = "ruby-native"
 PROVIDES = "virtual/opencl-icd"
-RPROVIDES:${PN} = "virtual-opencl-icd"
 
 BBCLASSEXTEND = "native nativesdk"
diff --git a/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb b/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
index 2ff9a6ae7ea5..d5337af8e5fb 100644
--- a/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
+++ b/meta-oe/recipes-core/opencl/opencl-icd-loader_2024.05.08.bb
@@ -9,8 +9,6 @@  inherit pkgconfig cmake
 DEPENDS += "opencl-headers"
 
 PROVIDES = "virtual/opencl-icd"
-RPROVIDES:${PN} = "virtual-opencl-icd"
-
 
 SRCREV = "861b68b290e76d08e7241608479c16431f529945"
 SRC_URI = "git://github.com/KhronosGroup/OpenCL-ICD-Loader.git;branch=main;protocol=https"