diff mbox series

[meta-oe,scarthgap] linuxptp: Add systemd instance specifier for ptp4l dependency

Message ID 20250915095310.800122-2-csokas.bence@prolan.hu
State New
Headers show
Series [meta-oe,scarthgap] linuxptp: Add systemd instance specifier for ptp4l dependency | expand

Commit Message

Csókás Bence Sept. 15, 2025, 9:53 a.m. UTC
From: Martin Schwan <m.schwan@phytec.de>

Add the instance specifier to the ptp4l dependency for the phc2sys
service, so the corresponding service is automatically started
correctly. This fixes the following error messages, when starting the
phc2sys@... service:

    Failed to restart phc2sys@eth0.service: Unit ptp4l.service not found.

Signed-off-by: Martin Schwan <m.schwan@phytec.de>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
(cherry picked from commit 31f0b9d3d51a65b1c3d63eb6520e7ab174a8550c)
Signed-off-by: Bence Csókás <csokas.bence@prolan.hu>
---
 .../linuxptp/linuxptp/systemd/phc2sys@.service.in             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


base-commit: 205638f9edf8e1aa1fbcf28555625fe56f2701a5

Comments

Gyorgy Sarvari Sept. 15, 2025, 11:20 a.m. UTC | #1
Note that this has been part of Scarthgap since a few hours ago:
https://git.openembedded.org/meta-openembedded/commit/?h=scarthgap&id=10fc22193840ad6f8d08aa05af0f1823714bfaaa

On 9/15/25 11:53, Csókás Bence via lists.openembedded.org wrote:
> From: Martin Schwan <m.schwan@phytec.de>
>
> Add the instance specifier to the ptp4l dependency for the phc2sys
> service, so the corresponding service is automatically started
> correctly. This fixes the following error messages, when starting the
> phc2sys@... service:
>
>     Failed to restart phc2sys@eth0.service: Unit ptp4l.service not found.
>
> Signed-off-by: Martin Schwan <m.schwan@phytec.de>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> (cherry picked from commit 31f0b9d3d51a65b1c3d63eb6520e7ab174a8550c)
> Signed-off-by: Bence Csókás <csokas.bence@prolan.hu>
> ---
>  .../linuxptp/linuxptp/systemd/phc2sys@.service.in             | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in b/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in
> index f66dd2d010..7d1d975ea3 100644
> --- a/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in
> +++ b/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in
> @@ -1,8 +1,8 @@
>  [Unit]
>  Description=Synchronize system clock or PTP hardware clock (PHC)
>  Documentation=man:phc2sys
> -Requires=ptp4l.service
> -After=ptp4l.service
> +Requires=ptp4l@%i.service
> +After=ptp4l@%i.service
>  Before=time-sync.target
>  
>  [Service]
>
> base-commit: 205638f9edf8e1aa1fbcf28555625fe56f2701a5
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#119406): https://lists.openembedded.org/g/openembedded-devel/message/119406
> Mute This Topic: https://lists.openembedded.org/mt/115251470/6084445
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [skandigraun@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
Csókás Bence Sept. 15, 2025, 12:09 p.m. UTC | #2
Hi,

On 2025. 09. 15. 13:20, Gyorgy Sarvari wrote:
> Note that this has been part of Scarthgap since a few hours ago:
> https://git.openembedded.org/meta-openembedded/commit/?h=scarthgap&id=10fc22193840ad6f8d08aa05af0f1823714bfaaa

Yes, after I sent it, I noticed Anuj's Pull Request submitted on Friday. 
However, I did not see that it was merged. But yes, apparently it got 
pulled in the morning.

Sorry for the noise.

Bence
diff mbox series

Patch

diff --git a/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in b/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in
index f66dd2d010..7d1d975ea3 100644
--- a/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in
+++ b/meta-oe/recipes-connectivity/linuxptp/linuxptp/systemd/phc2sys@.service.in
@@ -1,8 +1,8 @@ 
 [Unit]
 Description=Synchronize system clock or PTP hardware clock (PHC)
 Documentation=man:phc2sys
-Requires=ptp4l.service
-After=ptp4l.service
+Requires=ptp4l@%i.service
+After=ptp4l@%i.service
 Before=time-sync.target
 
 [Service]