diff mbox series

[1/3] spirv-llvm-translator: small recipe cleanup

Message ID 20250905110845.3139349-1-ross.burton@arm.com
State New
Headers show
Series [1/3] spirv-llvm-translator: small recipe cleanup | expand

Commit Message

Ross Burton Sept. 5, 2025, 11:08 a.m. UTC
- There is no need for python3native, as this recipe doesn't depend on
  other python modules.

- Inherit lib_package so the llvm-spirv binary is in a separate package
  to the libLLVMSPIRVLib.so library.

- Remove obsolete CMake options that no longer appear to be required.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../spir/spirv-llvm-translator_20.1.4.bb               | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

Comments

Khem Raj Sept. 5, 2025, 5:29 p.m. UTC | #1
what is the effect of

-    -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-    -DCMAKE_SKIP_RPATH=ON \

On Fri, Sep 5, 2025 at 4:08 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:
>
> - There is no need for python3native, as this recipe doesn't depend on
>   other python modules.
>
> - Inherit lib_package so the llvm-spirv binary is in a separate package
>   to the libLLVMSPIRVLib.so library.
>
> - Remove obsolete CMake options that no longer appear to be required.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  .../spir/spirv-llvm-translator_20.1.4.bb               | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb
> index 64a73ce55aa..3a090b7b5cb 100644
> --- a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb
> +++ b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb
> @@ -15,18 +15,10 @@ UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
>
>  DEPENDS = "llvm spirv-tools spirv-headers"
>
> -inherit cmake pkgconfig python3native
> +inherit cmake pkgconfig lib_package
>
> -# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
> -# for CMAKE_SHARED_LIBS=OFF see https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/1868
>  EXTRA_OECMAKE = "\
>      -DBUILD_SHARED_LIBS=ON \
> -    -DCMAKE_BUILD_TYPE=Release \
> -    -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
> -    -DCMAKE_SKIP_RPATH=ON \
> -    -DLLVM_EXTERNAL_LIT=lit \
> -    -DLLVM_INCLUDE_TESTS=ON \
> -    -Wno-dev \
>      -DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR=${STAGING_INCDIR}/.. \
>  "
>
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#222992): https://lists.openembedded.org/g/openembedded-core/message/222992
> Mute This Topic: https://lists.openembedded.org/mt/115080036/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
diff mbox series

Patch

diff --git a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb
index 64a73ce55aa..3a090b7b5cb 100644
--- a/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb
+++ b/meta/recipes-graphics/spir/spirv-llvm-translator_20.1.4.bb
@@ -15,18 +15,10 @@  UPSTREAM_CHECK_GITTAGREGEX = "v(?P<pver>\d+(\.\d+)+)"
 
 DEPENDS = "llvm spirv-tools spirv-headers"
 
-inherit cmake pkgconfig python3native
+inherit cmake pkgconfig lib_package
 
-# Specify any options you want to pass to cmake using EXTRA_OECMAKE:
-# for CMAKE_SHARED_LIBS=OFF see https://github.com/KhronosGroup/SPIRV-LLVM-Translator/issues/1868
 EXTRA_OECMAKE = "\
     -DBUILD_SHARED_LIBS=ON \
-    -DCMAKE_BUILD_TYPE=Release \
-    -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-    -DCMAKE_SKIP_RPATH=ON \
-    -DLLVM_EXTERNAL_LIT=lit \
-    -DLLVM_INCLUDE_TESTS=ON \
-    -Wno-dev \
     -DLLVM_EXTERNAL_SPIRV_HEADERS_SOURCE_DIR=${STAGING_INCDIR}/.. \
 "