| Message ID | 20250812-wip-arm64-crypto-v1-1-5c2cd9d8f1bb@phytec.de |
|---|---|
| State | New |
| Headers | show |
| Series | arch-arm.inc: Only add -mcpu options if it exists | expand |
Am Dienstag, dem 12.08.2025 um 11:51 +0200 schrieb Martin Schwan via lists.openembedded.org: > Only add feature modifiers to the -mcpu and/or -march option, if > -mcpu/-march is actually specified. For some very basic tunes, like > "aarch64" without any ARM version, the -mcpu option is omitted and thus > no feature modifiers should be added. > > Fixes: 754345d6063c ("feature-arm-crypto: Add +nocrypto to -mcpu when crypto > not in features") > > Signed-off-by: Martin Schwan <m.schwan@phytec.de> Reported-by: Yannic Moog <y.moog@phytec.de> Tested-by: Yannic Moog <y.moog@phytec.de> Tested on aarch64 NXP imx. > --- > meta/conf/machine/include/arm/arch-arm.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/conf/machine/include/arm/arch-arm.inc > b/meta/conf/machine/include/arm/arch-arm.inc > index > f1e92e19c6156da171de952fcb74bd05b95c8685..56616772fadd92c0c2dd01a9c4983f1fa573 > fa95 100644 > --- a/meta/conf/machine/include/arm/arch-arm.inc > +++ b/meta/conf/machine/include/arm/arch-arm.inc > @@ -17,4 +17,4 @@ TARGET_FPU = "${@d.getVar('TUNE_CCARGS_MFLOAT') or 'soft'}" > > # Some -march settings need a +X option passed in. Since we cannot guarantee > that any specified TUNE_CCARGS option is set in any order, we must hard code > the order here to allow for it. > TUNE_CCARGS_MARCH_OPTS ??= "" > -TUNE_CCARGS .= "${TUNE_CCARGS_MARCH}${TUNE_CCARGS_MARCH_OPTS}" > +TUNE_CCARGS .= "${TUNE_CCARGS_MARCH}${@d.getVar('TUNE_CCARGS_MARCH_OPTS') if > d.getVar('TUNE_CCARGS_MARCH') else ''}" > > --- > base-commit: 1dec53b350d7d2edcc880f640b1cb2fd31ff7f0b > change-id: 20250812-wip-arm64-crypto-ca0068c74b3c > > Best regards, > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#221759): > https://lists.openembedded.org/g/openembedded-core/message/221759 > Mute This Topic: https://lists.openembedded.org/mt/114663068/8280565 > Group Owner: openembedded-core+owner@lists.openembedded.org > Unsubscribe: > https://lists.openembedded.org/g/openembedded-core/unsub [y.moog@phytec.de] > -=-=-=-=-=-=-=-=-=-=-=-
Hi Martin, Yannic, Thanks for the patch and the test but... On 8/12/25 11:51 AM, Martin Schwan via lists.openembedded.org wrote: > [You don't often get email from m.schwan=phytec.de@lists.openembedded.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > Only add feature modifiers to the -mcpu and/or -march option, if > -mcpu/-march is actually specified. For some very basic tunes, like > "aarch64" without any ARM version, the -mcpu option is omitted and thus > no feature modifiers should be added. > > Fixes: 754345d6063c ("feature-arm-crypto: Add +nocrypto to -mcpu when crypto not in features") > ...this has already been sent and rejected, see https://lore.kernel.org/openembedded-core/20250805171619.1357193-1-raj.khem@gmail.com/ Please see the v2 here instead: https://lore.kernel.org/openembedded-core/20250806050838.3311037-1-raj.khem@gmail.com/T/#u Could you please test and review that patch instead? Thanks! Cheers, Quentin
Hi Quentin, Am Dienstag, dem 12.08.2025 um 12:10 +0200 schrieb Quentin Schulz: > Hi Martin, Yannic, > > Thanks for the patch and the test but... > > On 8/12/25 11:51 AM, Martin Schwan via lists.openembedded.org wrote: > > [You don't often get email from m.schwan=phytec.de@lists.openembedded.org. > > Learn why this is important at > > https://aka.ms/LearnAboutSenderIdentification ] > > > > Only add feature modifiers to the -mcpu and/or -march option, if > > -mcpu/-march is actually specified. For some very basic tunes, like > > "aarch64" without any ARM version, the -mcpu option is omitted and thus > > no feature modifiers should be added. > > > > Fixes: 754345d6063c ("feature-arm-crypto: Add +nocrypto to -mcpu when crypto > > not in features") > > > > ...this has already been sent and rejected, see > https://lore.kernel.org/openembedded-core/20250805171619.1357193-1-raj.khem@gmail.com/ > > Please see the v2 here instead: > https://lore.kernel.org/openembedded-core/20250806050838.3311037-1-raj.khem@gmail.com/T/#u > > Could you please test and review that patch instead? Thanks! Thanks, will do. Yannic > > Cheers, > Quentin
diff --git a/meta/conf/machine/include/arm/arch-arm.inc b/meta/conf/machine/include/arm/arch-arm.inc index f1e92e19c6156da171de952fcb74bd05b95c8685..56616772fadd92c0c2dd01a9c4983f1fa573fa95 100644 --- a/meta/conf/machine/include/arm/arch-arm.inc +++ b/meta/conf/machine/include/arm/arch-arm.inc @@ -17,4 +17,4 @@ TARGET_FPU = "${@d.getVar('TUNE_CCARGS_MFLOAT') or 'soft'}" # Some -march settings need a +X option passed in. Since we cannot guarantee that any specified TUNE_CCARGS option is set in any order, we must hard code the order here to allow for it. TUNE_CCARGS_MARCH_OPTS ??= "" -TUNE_CCARGS .= "${TUNE_CCARGS_MARCH}${TUNE_CCARGS_MARCH_OPTS}" +TUNE_CCARGS .= "${TUNE_CCARGS_MARCH}${@d.getVar('TUNE_CCARGS_MARCH_OPTS') if d.getVar('TUNE_CCARGS_MARCH') else ''}"
Only add feature modifiers to the -mcpu and/or -march option, if -mcpu/-march is actually specified. For some very basic tunes, like "aarch64" without any ARM version, the -mcpu option is omitted and thus no feature modifiers should be added. Fixes: 754345d6063c ("feature-arm-crypto: Add +nocrypto to -mcpu when crypto not in features") Signed-off-by: Martin Schwan <m.schwan@phytec.de> --- meta/conf/machine/include/arm/arch-arm.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 1dec53b350d7d2edcc880f640b1cb2fd31ff7f0b change-id: 20250812-wip-arm64-crypto-ca0068c74b3c Best regards,