diff mbox series

runqemu: fix special characters bug

Message ID 20250801064828.2904332-1-libo.chen.cn@windriver.com
State Accepted, archived
Commit 3c186fe7741adecb0887e36c8a9164a58fc16437
Headers show
Series runqemu: fix special characters bug | expand

Commit Message

Chen, Libo (CN) Aug. 1, 2025, 6:48 a.m. UTC 
From: Libo Chen <libo.chen.cn@windriver.com>

Fix the following bug for runqemu with a file path which contains
vmlinux characters.

runqemu - ERROR - wic doesn't need kernel

Signed-off-by: Libo Chen <libo.chen.cn@windriver.com>
---
 scripts/runqemu | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Alexander Kanavin Aug. 1, 2025, 12:32 p.m. UTC | #1 
On Fri, 1 Aug 2025 at 08:48, Chen, Libo (CN) via
lists.openembedded.org
<libo.chen.cn=windriver.com@lists.openembedded.org> wrote:

> Fix the following bug for runqemu with a file path which contains
> vmlinux characters.

What are vmlinux characters? Can you show an example, so it's easier
to understand exactly what issue the patch is fixing.

Alex
Chen, Libo (CN) Aug. 6, 2025, 2:45 a.m. UTC | #2 
Alex,

Thanks for your comments. I sent V2 patch for review with more clear commit description.

Libo

>-----Original Message-----
>From: Alexander Kanavin <alex.kanavin@gmail.com>
>Sent: Friday, August 1, 2025 8:33 PM
>To: Chen, Libo (CN) <Libo.Chen.CN@windriver.com>
>Cc: openembedded-core@lists.openembedded.org
>Subject: Re: [OE-core] [PATCH] runqemu: fix special characters bug
>
>CAUTION: This email comes from a non Wind River email account!
>Do not click links or open attachments unless you recognize the sender and know
>the content is safe.
>
>On Fri, 1 Aug 2025 at 08:48, Chen, Libo (CN) via lists.openembedded.org
><libo.chen.cn=windriver.com@lists.openembedded.org> wrote:
>
>> Fix the following bug for runqemu with a file path which contains
>> vmlinux characters.
>
>What are vmlinux characters? Can you show an example, so it's easier to
>understand exactly what issue the patch is fixing.
>
>Alex
diff mbox series

Patch

diff --git a/scripts/runqemu b/scripts/runqemu
index 3d77046972..137a4f0feb 100755
--- a/scripts/runqemu
+++ b/scripts/runqemu
@@ -368,12 +368,13 @@  class BaseConfig(object):
         - Check whether it is an NFS dir
         - Check whether it is an OVMF flash file
         """
+        n = os.path.basename(p)
         if p.endswith('.qemuboot.conf'):
             self.qemuboot = p
             self.qbconfload = True
-        elif re.search('\\.bin$', p) or re.search('bzImage', p) or \
-             re.search('zImage', p) or re.search('vmlinux', p) or \
-             re.search('fitImage', p) or re.search('uImage', p):
+        elif re.search('\\.bin$', n) or re.search('bzImage', n) or \
+             re.search('zImage', n) or re.search('vmlinux', n) or \
+             re.search('fitImage', n) or re.search('uImage', n):
             self.kernel =  p
         elif os.path.isfile(p) and ('-image-' in os.path.basename(p) or '.rootfs.' in os.path.basename(p)):
             self.rootfs = p