diff mbox series

[1/1] bitbake.conf: Add xz to HOSTTOOLS

Message ID b35dc1cc758d4ea4a58f26403bc0ab0cc88637a3.1753776105.git.liezhi.yang@windriver.com
State Accepted, archived
Commit 9c0bc6edf5e6706597563924f62bbab6fdd38ac2
Headers show
Series [1/1] bitbake.conf: Add xz to HOSTTOOLS | expand

Commit Message

Robert Yang July 29, 2025, 8:03 a.m. UTC
From: Robert Yang <liezhi.yang@windriver.com>

The uninative tarball requires xz to decompress:
WARNING: Disabling uninative as unable to install uninative tarball:
WARNING: tar (child): xz: Cannot exec: No such file or directory

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/conf/bitbake.conf | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Quentin Schulz Aug. 1, 2025, 10:48 a.m. UTC | #1
Hi Robert,

On 7/29/25 10:03 AM, Robert Yang via lists.openembedded.org wrote:
> From: Robert Yang <liezhi.yang@windriver.com>
> 
> The uninative tarball requires xz to decompress:
> WARNING: Disabling uninative as unable to install uninative tarball:
> WARNING: tar (child): xz: Cannot exec: No such file or directory
> 

Is this something we should be making uninative specific maybe? Maybe 
something like we did for ip, ping, ps, scp ,ssh, ssty which are added 
if e.g. testimage.bbclass is inherited?

> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   meta/conf/bitbake.conf | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index b02459c18f..fb26e72669 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -524,15 +524,12 @@ HOSTTOOLS += " \
>       python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh \
>       sha1sum sha224sum sha256sum sha384sum sha512sum \
>       sleep sort split stat strings strip tail tar tee test touch tr true truncate uname \
> -    uniq unzstd wc wget which xargs zstd \
> +    uniq unzstd wc wget which xargs zstd xz \

I think we want this to stay alphabetically ordered?

Looks good to me otherwise. It seems we already have xz listed in the 
dependencies in the docs (almalinux, fedora, opensuse and ubuntu 
according to my git-grep :) ), so no update required on that front?

Cheers,
Quentin
diff mbox series

Patch

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index b02459c18f..fb26e72669 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -524,15 +524,12 @@  HOSTTOOLS += " \
     python3 pzstd ranlib readelf readlink realpath rm rmdir rpcgen sed seq sh \
     sha1sum sha224sum sha256sum sha384sum sha512sum \
     sleep sort split stat strings strip tail tar tee test touch tr true truncate uname \
-    uniq unzstd wc wget which xargs zstd \
+    uniq unzstd wc wget which xargs zstd xz \
 "
 
 # Tools needed to run testimage runtime image testing
 HOSTTOOLS += "${@'ip ping ps scp ssh stty' if (bb.utils.contains_any('IMAGE_CLASSES', 'testimage testsdk', True, False, d) or any(x in (d.getVar("BBINCLUDED") or "") for x in ["testimage.bbclass", "testsdk.bbclass"])) else ''}"
 
-# Used by archiver.bbclass when compression is xz
-HOSTTOOLS += "${@'xz' if (('archiver.bbclass' in (d.getVar('BBINCLUDED') or '')) and (d.getVarFlag('ARCHIVER_MODE', 'compression') == 'xz')) else ''}"
-
 # Link to these if present
 HOSTTOOLS_NONFATAL += "aws gcc-ar gpg gpg-agent ld.bfd ld.gold nc pigz sftp socat ssh sudo"